Merge pull request #22862 from department-of-veterans-affairs/release…

…/FY24Q4.5.0 Release R2.5.0
department-of-veterans-affairs · Sep 19, 2024 · ba1fd59 · ba1fd59
2 parents e34da00 + bb83d03
commit ba1fd59
Show file tree

Hide file tree

Showing 130 changed files with 5,090 additions and 1,327 deletions.
diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml
@@ -45,6 +45,15 @@ jobs:
         ports:
           - 1521:1521
 
+      localstack:
+        image: localstack/localstack:0.14.5
+        ports:
+          - 4566:4566
+        env:
+          SERVICES: "sqs"
+        volumes:
+          - /var/run/docker.sock:/var/run/docker.sock
+
     strategy:
       fail-fast: false
       matrix:
@@ -188,6 +197,9 @@ jobs:
       - name: "Wait for database"
         run: dockerize -wait tcp://postgres:5432 -timeout 1m
 
+      - name: "Wait for localstack"
+        run: dockerize -wait tcp://localstack:4566 -timeout 30s
+
       - name: "Wait for FACOLS"
         run: ./ci-bin/capture-log "bundle exec rake local:vacols:wait_for_connection"
 

diff --git a/Dockerfile b/Dockerfile
@@ -66,10 +66,6 @@ RUN apt install -y ${CASEFLOW} &&  \
 # install jemalloc
 RUN apt install -y --no-install-recommends libjemalloc-dev
 
-
-# install datadog agent
-RUN DD_INSTALL_ONLY=true DD_AGENT_MAJOR_VERSION=7 DD_API_KEY=$(cat config/datadog.key) bash -c "$(curl -L https://raw.githubusercontent.com/DataDog/datadog-agent/master/cmd/agent/install_script.sh)"
-
 RUN rm -rf /var/lib/apt/lists/*
 
 # Installing the version of bundler that corresponds to the Gemfile.lock

diff --git a/Gemfile b/Gemfile
@@ -22,8 +22,6 @@ gem "connect_mpi", git: "https://github.com/department-of-veterans-affairs/conne
 gem "connect_vbms", git: "https://github.com/department-of-veterans-affairs/connect_vbms.git", ref: "9807d9c9f0f3e3494a60b6693dc4f455c1e3e922"
 gem "console_tree_renderer", git: "https://github.com/department-of-veterans-affairs/console-tree-renderer.git", tag: "v0.1.1"
 gem "countries"
-gem "ddtrace"
-gem "dogstatsd-ruby"
 gem "dry-schema", "~> 1.4"
 gem "fast_jsonapi"
 gem "fuzzy_match"
@@ -33,8 +31,28 @@ gem "icalendar"
 gem "kaminari"
 gem "logstasher"
 gem "moment_timezone-rails"
-gem "newrelic_rpm"
 gem "nokogiri", ">= 1.11.0.rc4"
+
+gem "opentelemetry-exporter-otlp", require: false
+gem "opentelemetry-sdk", require: false
+
+gem "opentelemetry-instrumentation-action_pack", require: false
+gem "opentelemetry-instrumentation-action_view", require: false
+gem "opentelemetry-instrumentation-active_job", require: false
+gem "opentelemetry-instrumentation-active_model_serializers", require: false
+gem "opentelemetry-instrumentation-active_record", require: false
+gem "opentelemetry-instrumentation-aws_sdk", require: false
+gem "opentelemetry-instrumentation-concurrent_ruby", require: false
+gem "opentelemetry-instrumentation-faraday", require: false
+gem "opentelemetry-instrumentation-http", require: false
+gem "opentelemetry-instrumentation-http_client", require: false
+gem "opentelemetry-instrumentation-net_http", require: false
+gem "opentelemetry-instrumentation-pg", require: false
+gem "opentelemetry-instrumentation-rack", require: false
+gem "opentelemetry-instrumentation-rails", require: false
+gem "opentelemetry-instrumentation-rake", require: false
+gem "opentelemetry-instrumentation-redis", require: false
+
 gem "paper_trail", "~> 12.0"
 # Used to speed up reporting
 gem "parallel"
@@ -59,7 +77,7 @@ gem "rainbow"
 # React
 gem "react_on_rails", "11.3.0"
 gem "redis-mutex"
-gem "redis-namespace"
+gem "redis-namespace", "~> 1.11.0"
 gem "redis-rails", "~> 5.0.2"
 gem "request_store"
 gem "roo", "~> 2.7"
@@ -119,7 +137,8 @@ group :test, :development, :demo, :make_docs do
   gem "rubocop-performance"
   gem "rubocop-rails"
   gem "scss_lint", require: false
-  gem "simplecov", git: "https://github.com/colszowka/simplecov.git", require: false
+  gem "simplecov", require: false
+  gem "simplecov-lcov", require: false
   gem "single_cov"
   gem "sniffybara", git: "https://github.com/department-of-veterans-affairs/sniffybara.git"
   gem "sql_tracker"

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,12 +1,3 @@
-GIT
-  remote: https://github.com/colszowka/simplecov.git
-  revision: 783c9d7e9995f3ea9baf9fbb517c1d0ceb12acdb
-  specs:
-    simplecov (0.15.1)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-
 GIT
   remote: https://github.com/department-of-veterans-affairs/caseflow-commons
   revision: 9bd3635fbd8094d25160669f38d8699e2f1d7a98
@@ -1458,7 +1449,7 @@ GEM
     backport (1.2.0)
     base64 (0.2.0)
     benchmark (0.3.0)
-    benchmark-ips (2.7.2)
+    benchmark-ips (2.14.0)
     bootsnap (1.7.5)
       msgpack (~> 1.0)
     brakeman (4.7.1)
@@ -1529,8 +1520,6 @@ GEM
       database_cleaner-core (~> 2.0.0)
     database_cleaner-core (2.0.1)
     date (3.3.3)
-    ddtrace (0.34.1)
-      msgpack
     dead_end (4.0.0)
     debase (0.2.4.1)
       debase-ruby_core_source (>= 0.10.2)
@@ -1548,8 +1537,7 @@ GEM
       ruby-statistics (>= 2.1)
       thor (>= 0.19, < 2)
     diff-lcs (1.3)
-    docile (1.1.5)
-    dogstatsd-ruby (4.4.0)
+    docile (1.4.1)
     dotenv (2.8.1)
     dotenv-rails (2.8.1)
       dotenv (= 2.8.1)
@@ -1614,13 +1602,16 @@ GEM
     foreman (0.87.2)
     formatador (0.2.5)
     fuzzy_match (2.1.0)
-    get_process_mem (0.2.4)
+    get_process_mem (0.2.7)
       ffi (~> 1.0)
     git (1.13.2)
       addressable (~> 2.8)
       rchardet (~> 1.8)
     globalid (1.2.1)
       activesupport (>= 6.1)
+    google-protobuf (3.25.4)
+    googleapis-common-protos-types (1.15.0)
+      google-protobuf (>= 3.18, < 5.a)
     govdelivery-tms (2.8.4)
       activesupport
       faraday
@@ -1644,7 +1635,8 @@ GEM
       builder (>= 2.1.2)
     hana (1.3.6)
     hashdiff (1.0.0)
-    heapy (0.1.4)
+    heapy (0.2.0)
+      thor
     holidays (6.6.1)
     httpclient (2.8.3)
     httpi (2.4.4)
@@ -1664,7 +1656,6 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    json (2.3.0)
     json-schema (4.3.0)
       addressable (>= 2.8)
     json_schemer (0.2.16)
@@ -1709,7 +1700,7 @@ GEM
       net-pop
       net-smtp
     marcel (1.0.4)
-    memory_profiler (0.9.14)
+    memory_profiler (1.0.2)
     meta_request (0.7.2)
       rack-contrib (>= 1.1, < 3)
       railties (>= 3.0.0, < 7)
@@ -1719,7 +1710,7 @@ GEM
     mime-types-data (3.2019.1009)
     mini_histogram (0.3.1)
     mini_mime (1.1.2)
-    mini_portile2 (2.8.5)
+    mini_portile2 (2.8.7)
     minitest (5.19.0)
     moment_timezone-rails (0.5.0)
     momentjs-rails (2.29.4.1)
@@ -1737,7 +1728,6 @@ GEM
       timeout
     net-smtp (0.3.3)
       net-protocol
-    newrelic_rpm (6.5.0.357)
     nio4r (2.5.9)
     no_proxy_fix (0.1.2)
     nokogiri (1.15.5)
@@ -1751,6 +1741,92 @@ GEM
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
+    opentelemetry-api (1.1.0)
+    opentelemetry-common (0.19.7)
+      opentelemetry-api (~> 1.0)
+    opentelemetry-exporter-otlp (0.24.2)
+      google-protobuf (~> 3.19)
+      googleapis-common-protos-types (~> 1.3)
+      opentelemetry-api (~> 1.1)
+      opentelemetry-common (~> 0.19.6)
+      opentelemetry-sdk (~> 1.2)
+      opentelemetry-semantic_conventions
+    opentelemetry-instrumentation-action_pack (0.5.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+      opentelemetry-instrumentation-rack (~> 0.21)
+    opentelemetry-instrumentation-action_view (0.4.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-active_support (~> 0.1)
+      opentelemetry-instrumentation-base (~> 0.20)
+    opentelemetry-instrumentation-active_job (0.4.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-active_model_serializers (0.19.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-active_record (0.5.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+      ruby2_keywords
+    opentelemetry-instrumentation-active_support (0.3.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-aws_sdk (0.3.2)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-base (0.21.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-registry (~> 0.1)
+    opentelemetry-instrumentation-concurrent_ruby (0.20.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-faraday (0.22.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.19.3)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-http (0.21.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-http_client (0.21.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.19.3)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-net_http (0.21.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.19.3)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-pg (0.23.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-rack (0.22.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.19.3)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-rails (0.25.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-action_pack (~> 0.5.0)
+      opentelemetry-instrumentation-action_view (~> 0.4.0)
+      opentelemetry-instrumentation-active_job (~> 0.4.0)
+      opentelemetry-instrumentation-active_record (~> 0.5.0)
+      opentelemetry-instrumentation-active_support (~> 0.3.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-rake (0.1.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-instrumentation-redis (0.24.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.19.3)
+      opentelemetry-instrumentation-base (~> 0.21.0)
+    opentelemetry-registry (0.2.0)
+      opentelemetry-api (~> 1.1)
+    opentelemetry-sdk (1.2.1)
+      opentelemetry-api (~> 1.1)
+      opentelemetry-common (~> 0.19.3)
+      opentelemetry-registry (~> 0.2)
+      opentelemetry-semantic_conventions
+    opentelemetry-semantic_conventions (1.10.0)
+      opentelemetry-api (~> 1.0)
     paper_trail (12.3.0)
       activerecord (>= 5.2)
       request_store (~> 1.1)
@@ -1840,8 +1916,8 @@ GEM
       redis-namespace (~> 1.0)
     redis-mutex (4.0.2)
       redis-classy (~> 2.0)
-    redis-namespace (1.6.0)
-      redis (>= 3.0.4)
+    redis-namespace (1.11.0)
+      redis (>= 4)
     redis-rack (2.0.4)
       rack (>= 1.5, < 3)
       redis-store (>= 1.2, < 2)
@@ -1919,6 +1995,7 @@ GEM
     ruby-prof (1.4.1)
     ruby-progressbar (1.13.0)
     ruby-statistics (3.0.2)
+    ruby2_keywords (0.0.5)
     ruby_dep (1.5.0)
     ruby_parser (3.20.3)
       sexp_processor (~> 4.16)
@@ -1963,7 +2040,13 @@ GEM
       thor
     shoulda-matchers (5.3.0)
       activesupport (>= 5.2.0)
-    simplecov-html (0.10.2)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.1)
+    simplecov-lcov (0.8.0)
+    simplecov_json_formatter (0.1.4)
     single_cov (1.3.2)
     sixarm_ruby_unaccent (1.2.0)
     socksify (1.7.1)
@@ -2072,10 +2155,8 @@ DEPENDENCIES
   countries
   danger (~> 6.2.2)
   database_cleaner-active_record (= 2.0.0)
-  ddtrace
   debase
   derailed_benchmarks
-  dogstatsd-ruby
   dotenv-rails
   dry-schema (~> 1.4)
   factory_bot_rails (~> 5.2)
@@ -2095,8 +2176,25 @@ DEPENDENCIES
   logstasher
   meta_request
   moment_timezone-rails
-  newrelic_rpm
   nokogiri (>= 1.11.0.rc4)
+  opentelemetry-exporter-otlp
+  opentelemetry-instrumentation-action_pack
+  opentelemetry-instrumentation-action_view
+  opentelemetry-instrumentation-active_job
+  opentelemetry-instrumentation-active_model_serializers
+  opentelemetry-instrumentation-active_record
+  opentelemetry-instrumentation-aws_sdk
+  opentelemetry-instrumentation-concurrent_ruby
+  opentelemetry-instrumentation-faraday
+  opentelemetry-instrumentation-http
+  opentelemetry-instrumentation-http_client
+  opentelemetry-instrumentation-net_http
+  opentelemetry-instrumentation-pg
+  opentelemetry-instrumentation-rack
+  opentelemetry-instrumentation-rails
+  opentelemetry-instrumentation-rake
+  opentelemetry-instrumentation-redis
+  opentelemetry-sdk
   paper_trail (~> 12.0)
   parallel
   paranoia (~> 2.2)
@@ -2115,7 +2213,7 @@ DEPENDENCIES
   rb-readline
   react_on_rails (= 11.3.0)
   redis-mutex
-  redis-namespace
+  redis-namespace (~> 1.11.0)
   redis-rails (~> 5.0.2)
   request_store
   roo (~> 2.7)
@@ -2139,7 +2237,8 @@ DEPENDENCIES
   sentry-raven
   shoryuken (= 3.1.11)
   shoulda-matchers
-  simplecov!
+  simplecov
+  simplecov-lcov
   single_cov
   sniffybara!
   solargraph

diff --git a/Makefile.example b/Makefile.example
@@ -289,7 +289,7 @@ one-test-headless: # run the rspec test headless.
 	CI=1 bundle exec rspec $(RUN_ARGS) --format progress
 
 run-all-queues: ## start shoryuken with all queues
-	bundle exec shoryuken -q caseflow_development_send_notifications caseflow_development_high_priority caseflow_development_low_priority  -R
+	bundle exec shoryuken -q caseflow_development_send_notifications.fifo caseflow_development_high_priority caseflow_development_low_priority  -R
 
 run-low-priority: ## start shoryuken with just the low priority queue
 	bundle exec shoryuken -q caseflow_development_low_priority  -R
@@ -298,7 +298,7 @@ run-high-priority: ## start shoryuken with just the high priority queue
 	bundle exec shoryuken -q caseflow_development_high_priority  -R
 
 run-send-notifications: ## start shoryuken with just the send_notification queue
-	bundle exec shoryuken -q caseflow_development_send_notifications  -R
+	bundle exec shoryuken -q caseflow_development_send_notifications.fifo  -R
 
 jest: ## Run jest tests
 	cd client && yarn jest