Skip to content

Commit

Permalink
Feature/appeals 49670 49667 phase ii release tested (#23257) (#23269) (
Browse files Browse the repository at this point in the history
…#23281)

* APPEALS-36688- Build out Decision Review Created API route & Controller (#20569)

* added skeleton for api route

* removed duplicate code

* removed development envs for api and moved to creating an ApiKey

* removing any changes to development.rb

* removed extra auth code

* removed before action

---------



* APPEALS-38232 -Build out Decision Review Created Event Failure API route & Controller (#20601)

* APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method

* APPEALS-38232 - add comments to RSpec

* Jonathan/appeals 36684 (#20516)

* initial Events migration and model creation

* created model for DecisionReviewCreatedEvent

* updated comment with example

* added spec for DRCE model

* APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model

* APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass

* cleaned lint

* saving DRCE spec changes

* fixed spec test

* changed has_many to has_one

* updated event model spec

* added validation for ER poly associations

* changed association to has_one

* added new method and updated tests

* added foreign key after running checks

* some PR comment changes

* refactored methods in EventConcern

---------




* added migration, scopes and specs for events (#20707)

* fixed migration to update existing events table

* rollbacked to fix schema

* schema fixes

---------



* Jr/APPEALS-38926  (#20714)

* APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic

* APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class

* APPEALS-38926 Added new info column to update transaction and added it to the RSpec test

* APPEALS-38926 - added comments to the Service Class

* APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails

* APPEALS-38926 - fixed lint

* Jonathan/appeals 36689 (#20671)

* created new service class

* add rspec test cases

* service class methods

* controller action and spec

* controller update

* CC fixes

* removed accidental line

* changed to find_or_create_by

* reworked error for redis lock

* additional rspec for controller

* fixed test

* rspec fix

* delete lock key afterwards

* moved Event creation back into lock block

---------



* APPEALS-39663 Create CreateUserOnEvent service class and add logic to create user if needed (#20838)

* added user creation class & test

* removed extra lines

* add comment to class

* added context for args from avro

---------



* Jr/APPEALS-39664 (#20898)

* APPEALS-39664 - Created updated_vacols_on_optin module class, and removed  extra private

* APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated

* APPEALS-39664 - Created RSpec Test - PASS,  Updated method name.

* APPEALS-39664 - Added Error Handling to Sub Service Class

* APPEALS-39664 - Removed un-needed comments

* APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service

* APPEALS-39664 - Added Custom Error , and updated all .perform! to .process!

* APPEALS-39664 - Updated RSpec Test to reflect changes - all pass

* Updated comment for decision_review_created Service Class

* Will/appeals 36691 (#20909)

* Created attribute for failed claims on event and displaying failed claim

* passing all failed events back to serializer

* added controller tests for failed_claims and added class method for finding claims on events

* renamed failed_claims to claim_errors

---------



* JR/APPEALS-40954 Create CreateIntake service class and add logic to create Intake (#20967)

* APPEALS-40954 - Added Sudo Code for CreateIntake Logic

* APPEALS-40954 - added logic to CreateIntake module

* APPEALS-40954 - added Create Intake spec  with error handling - All pass

* APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service

* APPEALS-40954 - updated folder name and namespace

* APPEALS-40954 - Updated RSpec to match folder

* APPEALS-40954- Upated decision review created servie include to match folder

* Fixed failing test due to folder structure change

* Jonathan/appeals 40950 (#20965)

* Added new veteran creation module

* saving test changes

* rspec

* fixed datetime assign

* renamed var

---------



* APPEALS-40950 - update var veteran to vbms_veteran (#21050)

* APPEALS-40950 - update var veteran to vbms_veteran

* updated private method in controller to match happy path params dcr to drc

* Create CreateClaimantOnEvent service class and add logic to create claimant if needed (#21044)

* created service class and basic unit tests

* added conditionals for veteran claimants and will create veteran claimant now

* modified create claimant to use eventing data

* change to a class

* creating claimant correctly

* test fixes

* removed old comments

* fixed type for veteran_is_not_claimant

* changed specs to match pulling out hash params and removed event.reference id

* moved back to dot notation

* updated comments

* fixed create claimant issue

* updated process to use bang method and returning claimant

---------



* APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#21108)

* moved metricsService call to top of method

* modified rspec case

* moved metric logging spec case higher up

---------



* Resolved merge conflicts while merging master into feature/APPEALS-28… (#21167)

* Jonathan/APPEALS-41957 (#21171)

* added interface + parser class

* edited veteran parse methods

* renamed var to "payload"

* started refactor

* more refactor + rspec

* added EPE attr

* dateTime conversions

* added class comments

* rubocop lint changes

* fixed test case

---------



* Jr/appeals 41931 (#21192)

* APPEALS-41931 - Created create_ep_establishment file and class

* APPEALS-41931 - added process! method that creates epe from payload

* APPEALS-41931 - added logic for EventRecord being created and error handling

* APPEALS-41931 - added comments to process method

* APPEALS-41931 - set up rspec test

* APPEALS-41931 - removed lint

* APPEALS-41931-created Rspec and Test Pass

* APPEALS-41931 - cleaned lint and added error test 100% code coverage

* APPEALS-41931- fixed lint

* APPEALS-41931- fixed lint and fixed %100 code cov

* APPEALS-41931 - cleaned up lint and warn for Service Class

* APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class

* APPEALS-41931 - refactor code to implement new parser

* fixed linting issues

* APPEALS-41931 - Updated Comments for CreateEpEstablishment

* APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc

* edits

* Will/appeals 41929 (#21205)

* added an error and commented out call for createclaim

* added new parser logic

* merge request changes

* fixed rubocop issues and added checks for claim review attributes

---------



* APPEALS-42631- Create Rspec for Parser with sample payload method, and add additional parser methods  (#21294)

* APPEALS-42631 - create example.json

* APPEALS-42631 - implemented example_response and load_example method and works as expected

* APPEALS-42631 - created RSpec for DecisionReviewCreatedParser

* APPEALS-42631 - Refactored parser and Added RSpec for current praser

* APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods

* APPEALS-42631 - updated code per TL Comments

* APPEALS-421631- added additional comments and fixing lint

* APPEALS-41934 (#21251)

* initial commit

* implementation & error

* renamed method

* rspec

* saving refactor progress

* finished refactoring class

* added comment

* minor parser/rspec updates

---------



* added RI parser methods to rspec (#21322)

* added RI parser methods to rspec

* updated config for Consumer

---------



* Update DecisionReviewCreated to make all calls and link all intake records (#21334)

* updated decision review created to uncomment actions and updated specs

* remove binding.pry

* removed comments

* fixed a bunch of broken tests

* fixed last broken tests

* fixed params for methods and specs

---------



* APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382)

* APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended

* APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests

* APPEALS-43446 fixed error message

* Jr/ama controller refactor (#21365)

* fixed test and refactored controller

* saving changes

* init commit passing all the way to request_issues

* all pass and functions as expected

* lint

* lint

* updated initializer to use deep_symbolize_keys

* updated headers to be more dry

* added missing Intake attributes

* fixed failing tests

* updated createIntake test

* fixed veteran rspec

* fixed RI test

* APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382)

* APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended

* APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests

* APPEALS-43446 fixed error message

* updated intake

* modified intake

---------



* redo init commit

* updated imp. logic

* attorney widget fix

* Create end to end , happy path rspec's for Decision Created event Feature (#21395)

* updated more tests and fixed user creation

* added in person creation

* corrected headers and fixed broken tests

* added type

* fixed failing spec

* creating event when person is created

* updated spec to account for both events being created

* ignored long lines for spec file

* linting fixes

* fixed more linting errors/ ignored long lines

---------



* Jonathan/appeals 43589 (#21397)

* saving

* saving user class error progress

* error handling for user creation

* updated error handling/raises

* validator methods

* validations

* update logical date converter

* changed veteran service class to use file_number

* added fields to hlr

* updated epe data

* removed byebug

* fixed typos

* Edit 5: adding detail_id to Intake

* EDIT 6: add claimant_participant_id to epe

* Edit 8: Intake is correctly linked to veteran

* Edit 7: RI additions

* fixed spacing

* fixed typo

* saving rspec changes

* rspec updates

* added datetime conversion for person dob

* fixed rspec

* remove unused methods

---------



* feature/APPEALS-35707-29633-29632 (uat) (#21435)

* 🔀 Squash merge AlecK/APPEALS-35707 - Replace `database_cleaner` with `database_cleaner-active_record`

* 🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances

* 🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash

* awillis/APPEALS-45152 (#21506)

* APPEALS-45152 Updated the logic in create_claimant_on_event.rb to always generate a claimant record.  Updated RSPEC.

* APPEALS-45152 Cleaned up RSPEC.

* APPEALS-45152 Fixed Failing RSPEC within decision_review_created_spec.rb

* APPEALS-45152 Updated RSPEC within decision_review_created_spec.rb with addtional checks.

* APPEALS-44319 (#21449) (#21541)

* added logic for legacy issues in DRC

* more legacy logic

* updated rspec context lang

* error cov

---------




* Konstantin/APPEALS-45175 (#21517)

* logical_date_converter re-written to work with yyyymmdd numbers from json payload

* comments removed

* comments removed2

* method rewitten

* json example fixed

* date in scenario_b_spec.rb replaced by valid ones, additional check for empty string parameter added to the logical_date_converter

* removed filter for non rating request issue dropdown (#21480)

* removed filter for non rating request issue dropdown

* removed excluded types as we don't need to check this anymore

* fixed broken test

* added category back

* no longer need test to check for missing categories since we're returning them all.

---------



* Column added to RequestIssues table (#21578)

* added migration and simple spec to test

* fixed schema deleted issues

* updated spec to verify data being set

* error was no longer trigger from update. removed check and passed in correct variable

---------




* added bgs_source to parser, controller and serializer along with specs (#21621)



* Konstantin/appeals 45180 (#21591)

* bug is fixed, condition added to DecisionReviewCreatedController

* rspec test added

* json message updated

* comment added

* Update decision_review_created_controller.rb

comment updated

---------



* cmartine/APPEALS-42621 (#21599)

* Add remove_comp_and_pen_intake feature toggle to intakes controller

* Add new compensation and pension removal message to COPY.json

* Disable comp and pen radio buttons if remove_comp_and_pen_intake toggle is on

* Frontend test updates

* Add tooltip checks for review page integration tests

* fix frontend test lint errors

* frontend tests changes

* Fix linter errors

---------




* nrithner/APPEALS-45263 (#21617)

* Add remove_comp_and_pen_intake feature toggle to intakes controller

* Add new compensation and pension removal message to COPY.json

* Disable comp and pen radio buttons if remove_comp_and_pen_intake toggle is on

* Frontend test updates

* Add tooltip checks for review page integration tests

* fix frontend test lint errors

* frontend tests changes

* Add banner for non-vha

* Add banner for VHA employee

* Refactor conditionals

* Refactor logic for banners to display

* Add dangerouslySetHtml to banner

* Add test for no VHA employee

with vha_claim_review_establishment disabled.

* Add VHA employee scenario to display REMOVE_INTAKE_COMP_AND_PEN

* Complete non vha user scenarios

* Complete VHA employee scenarios

* Remove comments

* Fix linter errors

* Remove spaces preceding question marks

* Correct linting errors

---------





* Konstantin/appeals 45149 (#21644)

* RequestIssueSerializer attributes added

* development_item_reference_id, same_office, legacy_opt_in_approved attributes were added

* merge conflicts resolved

* merge conflict resolved

* fixed

* all datapoints were added

* empty line removed

* comment removed

* refactored

* app/controllers/api/docs/v3/ama_issues.yaml updated with new attributes

* example of request issue updated app/controllers/api/docs/v3/ama_issues.yaml

* null to nil edited in example ama_issues.yaml

* example ama_issues.yaml updated

* example ama_issues.yaml updated2

* linters fixed

* linters fixed2

* linters are fixed

* APPEALS-45883 - Remove End Product Establishment records within the Event Records table in Caseflow (#21745)

* APPEALS-45883 - changes to remove the creating of Event Records for epe

* APPEALS-45883 - remove removed event params from method calls

* APPEALS-45883 removed Event Double

* APPEALS-48553 updated event_record spec

* removed eventing from create claim review (#21718)

* removed eventing from create claim review

* checking why file is not being found for event_record

* removed event var and require dependency

* spec fixes

* updated specs

* fixed revert

---------




* Nrithner/appeals 45913 (#21716)

* Convert from milliseconds to datetime

* Add expection to have datetime after parsing

* Fix linting issues

* APPEALS - 45914 & 45915  (#21744)

* Decision review parser and spec changes

* remove byebug

* Added db seed and testing (#21284)

* Added db seed and testing

* Change ApiKey seed name to ConsumerApiKey, and associated changes

---------





* re-merge Cmartine/appeals 46861 (#21855)

* Edit DecisionReviewCreatedController to respond with ok status if event exists and is completed, edit test

* Move checking if event exists and is completed into event model, edit tests

* Fix linter errors

---------



* Nrithner/appeals 46860 (#21856)

* Set event info back to default

default state for info is an empty
json object

* Correct linting errors

* Test happy path with rspec

* Refactor rspec example

* Converte module to class

* Remove module import

---------



* Jonathan/appeals 45899/45878 (#21714)

* add "from event" value to Store

* updated setup guide for M3

* added new badges

* added jest

* storybook file

* additional story

* bugfix

* snap update

* Konstantin/appeals 46175 (#21768)

* draft processor method done

* process_nonrating method moved to DecisionReviewCreated service

* json example added, process_nonrating method updated

* 4 rspec test added

* useless json example removed

* commented lines removed

* condition added

* condition added.

* test updated

* first condition moved out of the method

* process_nonrating method call moved down

* 1 comment removed, 1 added

* process nonrating method rafactored, logic transferred into the parser

* method refactored, rspec tests updated

* rspec test slightly refactored

---------



* Edit Issues screen update (#21907)

* Edit Issues screen update

* relocated row

* updated capybara test

* updated capybara to check for new added text

* cmartine/APPEALS-46905 (#21884)

* Remove cache updating call for veteran when veteran is being created for an event

* Change seeds api_key.rb to consumer_api_key.rb

---------



* Update process_nonrating to process_nonrationg_issue_category

Remove extra logic

* Update rspec. Remove unused example

* Change edited_by_css_id to return users css_id

* Konstantin/appeals 48306 (#21998)

* ama_eventing_enabled feature check added

* toggle renamed

* rspec tests added

* 2 comments added

* toggle renamed, logic trasferred into controller, tests updated

* empty line removed

---------



* 930 code updates

* remove byebug

* Change edited_by_css_id to return users css_id (#22062)



* Nrithner/appeals 49245 (#22107)

* Update process_nonrating to process_nonrationg_issue_category

Remove extra logic

* Update rspec. Remove unused example

---------



* fix extra commas from merge

* APPEALS-51223: Disable ClaimantValidator for DecisionReviewCreatedEvents (#22132)

* APPEALS-51223 refactored the claimant_validator class method claimant_details_required? to consider the conditional statement

* APPEALS-51223 updated Rspec to confirm claimant address_line_1 is nil and error is empty

* APPEALS-51223 made changes to to claimant_validator to have all Unit test passing

* APPEALS-51223 added suggested changes

* Revert "fix merge conflict with AMA"

This reverts commit 6775316, reversing
changes made to 66cf311.

* added comments

* Delete docker-bin/build.sh, I didnt make these changes

* Revert "Delete docker-bin/build.sh, I didnt make these changes"

This reverts commit 03a3830.

---------



* Jonathan/appeals 51926 (#22215)

* Hide UI changes behind featureFlag

* fixed lint spacing warnings

* code climate spec fix (#22211)

* code climate spec fix

* up argument count

* created a parser helper for reusable methods

* reset codeclimate back to original and added issue parser

* modified methods to take in a hash instead of multiple params

* reduced create params down to 3 params

* added space inside

* swapped to safe navigator for intake check

* fixed spec

* fixed linting issue

* fixed failing spec

* fixed merge conflicts with code changes for helper

---------





* Konstantin/appeals 52321 (#22363)

* utc conversion method added in app/serializers/api/v3/issues/ama/request_issue_serializer.rb

* set_contested_rating_issue_profile_date method updated in RequestIssue model, updated contested_rating_issue_profile_date in  DecisionIssue model

* decision issue updated, tests added

* tests added, converters improve app/models/decision_issue.rb app/serializers/api/v3/issues/ama/request_issue_serializer.rb

* set_contested_rating_issue_profile_date restored in request issue model

* uneccessary logic removed

* 3 more tests added

* test added, error handling aaded in format_rating_profile_date method

* Update decision_issue.rb

* Update request_issue.rb

* Appeals 52317 (#22321)

* wip

* added the parser to skeleton

* removed commented code

* added in parser logic

* added dru_error route, error handling and params

* added rspecs and fixed routing for update error to be a post

* added empty spec

* updated dru params to match intake json

* rubocop fixes

* more rubocop fixes

* fixed routing to post now and updated specs

---------



* fixed logic for AMA issues API serializer attributes (#22358)

* fixed logic for added_by fields

* methods for fetching removed_by user

* withdrawn_by methods

* methods for edited_by & instance vars

* more logic for added_by methods

* fixed failing tests

* rspec updates

* rspec for RIU addition

* small changes

* fix test failure

* Initial commit (#22494)

* Konstantin/appeals 52318 (#22528)

* very loose prototype of class created

* hopeless variant removed

* updated parser per new design and updated specs

* request_issues_updated_event updated

* some improvments added

* unused methods removed, some methods updated

* after issues added

* tests added

* edited issues method returned, invalid tests removed

* tests updated

* 9 working tests added, RequestIssuesUpdateEvent variable instanciated

* tests improved, attribute writers added

* more test cases added, error handling in process! method added

* added new version of parser and tests to it from Will's PR

* uneccesary overrided classes removed

* process_job call removed

* process_job! restored, 3 more tests added

* validate before perfom removed

* linter issues addressed

* linter issues addressed2

---------



* Bug Fix for APPEALS-44115 (#22538)

* running ci

* testing category

* ci with conditional

* set back to false

* reverted to original spec

* running ci

* updated intake helpers to account for using none of these match option

* ignored metrics abc size

* removed from helper

* removed comments

* updated spec to check on each category

* removed single quotes

* fixed a flakey test that was failing on a duplicate key

* linting fix

* pushed up feature flag

* lint clean up

* swapped to different featureflag

* fixing spec feature toggle param

* added feature flags back

* checking if label is there

* flipped feature test to correct order

---------



* cmartine/APPEALS-50366 (#22618)

* Create EditDisabledBanner

* Add banner displaying logic and pageroute to IntakeEditFrame

* Add IntakeEditFrame jest tests for removeCompAndPenIntake feature toggle

* Edit displayEditDisabledBanner to use the disableEditingForCompensationAndPension method

* Re-add intakeEditFrame jest tests, re-add and move testProps

* Refactor intakeEditFrame jest tests

* Edit change testProps into static variable

* Add another test for intakeEditFrame

* Change testProps back into function return

* Change comp and pen removal text

* Change Intake Remove string back, add Intake Edit Disabled string, changed banner and tests to use this

* Ksarlett/appeals 50368 - Disable the remove issue, withdraw issue & edit issue options from drop down (#22637)

* ksarlett/APPEALS-50368 - Disable dropdown

* rermove console.log

* spec refactor

* spec fix

* spec refactor

* change test name

---------



* nrithner/APPEALS 50367 (#22640)

* Add disabled logic to add issue and edit claim

label buttons

* Add test buttons are disabled

When benefit is compensation

* Test buttons are disabled in supplemental_claim

Add issue and Edit claim label
are disabled when benefits
pension or compensation are present

* Test buttons are disabled in HLR

Add issue and Edit claim label
are disabled when benefits
pension or compensation are present

* Refactor to remove redundancy

* Test refactoring

---------




* APPEALS-53923 (#22727)

* new service class & error message

* rspec

* Update update_informal_conference_spec.rb

* Konstantin/appeals 52982 (#22715)

* eligibility-related methods added

* methods fixed, date conversion for closed_at added

* decision_review_updated_issue_parser created, json example updated, request_issues_update_event updated

* tests for parser fixed after json example update

* new attribute vbms_id added to request_issues table, decision_review_updated_issue_parser update respectively

* request_issues_update_event attr_writers added, decision_review_created_issue_parser class name update and call of that parser updated

* veteran removed from DecisionReviewUpdatedParser initilizer, methods marked for potential deletion

* decision_review_updated_issue_parser updated and test added for it, comments added to request_issues_update_event

* not necessary methods removed from parser, tests for them commented out for now

* attributes_from_intake_data method overrided

* :id replced by vbms_id, json example, parsers and test for it  updated

* parsers added, test updated

* css_id, station and detail_type commented from the parser

* parser cleaned, test for parser fixed, request_issues_update_event cleaned

* process_issues! overriden in app/models/request_issues_update_event.rb, linter offenses fixed, testtypo fixed

* vbms_id renamed to reference_id

* comment typo fixed

* Create Audit Tables for SC, HLR, Request Issues Appeals 55403 (#22689)

* migration added

* schema updated correctly

* added audit service and call to update evenr records

* logic for update type

* fixed typo in audit file and added spec

* added insert

* moved Insert DRUA to create request issues for created ones

* updated event record to take in update type

* passing in correct info attribute now

* disabled unused params, can enable once we use them

* remove <<<head

* updated migration and added request_issue to info json

* fixed spec where created at and updated timestamps format was different

---------




* fix merge conflic in seeds.rb

* remove cusoner seed files

* Konstantin/appeals 57291 (#22853)

* decision_review_created/decision_review_created_parser.rb updated

* rspec tests for decision_review_created parser added

* issue parser updated, tests added

* decision review updated parsers updated, tests added

* linter issue addressed

* Konstantin/appeals 57283 (#22851)

* reference_id added to parser, json example and create_request_issues.rb

* rspec tests for decision_review_created_issue_parser created

* reference_id null error handling added, tests for create_request_issues.rb added

* linter offenses fixed

* new param permitted added in app/controllers/api/events/v1/decision_review_created_controller.rb

* feature tests fixed

* APPEALS-55402 (#22768)

* service class and error

* adding to DRU class method

* linter line too long fix

* small fix to riue

* added rspec

* fixed typo

* Konstantin/appeals 57279 (#22859)

* DecisionReviewUpdateMissingIssueError handling is created

* initializer added, typos fixed in request_issues_update_event.rb,more error handlings added,  tests updated and added

* little optimizationd added to app/models/request_issues_update_event.rb

* attributes_from_intake_data fixed

* commented code removed

* review defined in decision_review_updated.rb

* formatted a bit

* useless comments removed

* linter offenses cleaned, useless comments removed

* Update request_issues_update_event.rb

Result of auto conflict resolution fixed

* useless comment removed

* Update decision_review_updated.rb

Lines 21,22 uncommented.

* rubocop disable/enable added

* additional positive tests added, RequestIssuesUpdateEvent updated

* 2 tests added

* linter issue fixed

* Jonathan/appeals 58619 (#22875)

* service class and error

* adding to DRU class method

* linter line too long fix

* small fix to riue

* added rspec

* fixed typo

* Added new service class + fixed typo

* typos

* more typo fixes

* additional fields to epe.update

* updated sample payload

* unit test + time conversion

---------



* Process newly added fields passed for DecissionReviewUpdated (#22876)

* added parser changes

* removed empty line

* updated json to match updated design and removed unused methods

* remove ep code category

* removed unused methods

* fixing specs and linting

* linting fix

* updated json example to match

* added edited_description to spec

* added new json payload changes that required spec updates

* removed binding.pry

---------



* Refactor Created Events Logic to Handle Contested Issues (#22852)

* wip

* added check for contested with specs

* removed newline

* fixed contested setting to if not eligible and fixed specs

* removed setter for contested

---------



* issue parser applied (#22904)

* issue parser applied

* refactor request_issues_update_event

* refactor request_issues_update_event- remove temp files

* fix lint issues

* fix linting issues

* fix eligibility fields

* add gaurd for missing participant in request issues serializer

* add description fields to eligibility updates

* bug fixes with controller

---------




* renamed epe to singular method call (#22914)



* Edit DecisionReviewUpdatedController dru_params (#22939)

* API fix + epe feature test (#22956)

* API fix + epe feature test

* add specs

---------



* Feature/appeals 59173 (#22995)

* fix bug reatletd to new issues

* fix DRU bugs

* fix linting issue

* fix event records bug

* fix event records spec

* bug fixes for error logs, audits, claim id (#23015)

* bug fixes for error logs, audits, claim id

* fix redi lock on created event

* add reference id to AMA API (#23022)

* add reference id to AMA API

* add withdrawn audit

* audit spec fix

* Konstantin/appeals 58609 (#22970)

* draft test

* typo fixed, byebug inside find_or_build_request_issue_from_intake_data

* typo fixed, edited_description added to attributes in app/controllers/api/events/v1/decision_review_updated_controller.rb

* test file renamed

* commented lines removed

* Update spec_helper.rb

* Update scenario_edited_issues_spec.rb

typo

* success message updated, any updates check added, edited_description before check added

* audit find_by fix and add create scenario

---------




* Konstantin/withdrawn issues feature test (#23028)

* withdrawn feature test added

* more checks added to test

* temp change

* request_issue.reload removed

* fix ama api and closed rspec

* remove byebug and fix closed statu rspec

* Jonathan/appeals 59166 (#22972)

* feature test, update hlr/sc optin value

* featuretoggle change

* featuretoggle

* fix linting issues

* fix DRU removed and DRUs for eventing feature, added feature tests an… (#23055)

* fix DRU removed and DRUs for eventing feature, added feature tests and RIUs checks

* fix linting errors

* fix mutex error spec

* lint fixes

* disable DRU audit (#23064)

* Nader/audit sync fix (#23079)

* remove sync attemps on RequestIssuesUpdateEvent and add auditing, fix nil discription

* add audit record check on add issue scenario spec

* fix changes? call

* ermove audit mock

* fix HIGHER_LEVEL_REVIEW check

* Revert "fix HIGHER_LEVEL_REVIEW check"

This reverts commit 1499727.

* Konstantin/appeals 59181 (#22992)

* eligible to ineligible test added

* eligible_to_ineligible test added

* one added, 2 updated

* empty line removed

* spec_helper restored

* success message updated

* empty line removed

* succes message expectation update in tests

* wording updated

* typo fixed

* linter addressed

* scenario_create_issues_spec.rb deleted, it was an invalid draft accidently pushed in previous PR

* add last sync to RIU's, update contention updated and remoted at , ac… (#23092)

* add last sync to RIU's, update contention updated and remoted at , account for CF intaked RIs based on original_casflow_request_issue_id

* fix rspec

* fix discription texts

* fix missing descriptions

* fix epe's getting created and error on missing ineligible_due_to (#23103)

* update contention text fix for eligibility changes

* fix the unidentified_text and contention_refference_id (#23119)

* fix the unidentified_text and contention_refference_id

* fix rspec and lint

* Jonathan/dru eventrecord dupe fix (#23162)

* consolidating review update into 1 service class

* removing double find

* including test scenario for claimreview

* updating test

* Nader/cont ref id unid issu txt fix (#23164)

* fix the missing contention reference id and unidentified issue text

* fix spec

* fix before issues query

* fix filed asignments when nil

* fix lint issue

* refactor update logic to not depend on RequestIssuesUpdate (#23187)

* refactor update logic to not depend on RequestIssuesUpdate

* fix rspec

* Konstantin/prevent check for before ama! (#23180)

* issue_from_event? check added into close_if_ineligible!

* alternative approach added

* check if appeal added

* comments removed

* status ok changed to created, close_if_ineligible! updated, useless methods removed

* close_if_ineligible! updated

* cleaned

* adding "contested" to UI text

---------



* fix the remove of issues created from vbms, add before audit, all fie… (#23202)

* fix the remove of issues created from vbms, add before audit, all fields saved for all evenets except edit

* final fixes and changes to veteran_participant_id and legacy_issue processing call

* add legacy processing for eligibility change

* add more logic for eligibility changes with legacy issues

* fix verify_contentions

* Add disabling of edit contention title button on the edit issues page when feature toggle enabled (#23194)

* Pass disableEditingForCompAndPen toggle to EditContentionTitle, enable/disable edit button depending on toggle status

* add feature tests for contention title disable

* remove byebug

---------



* remove _ext_ table from schema

* add saftey operator for missing request_issues_update

* fix optin check to pull from parser not review

* Revert "fix optin check to pull from parser not review"

This reverts commit c9cd5a9.

* Revert "add saftey operator for missing request_issues_update"

This reverts commit 7f2fd96.

* Revert "remove _ext_ table from schema"

This reverts commit 63758f2.

* remove _ext_ table from schema

* add back _ext_ table

---------

Co-authored-by: Will Love <wlove29@gmail.com>
Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Co-authored-by: Enrilo Ugalde <71367882+Jruuuu@users.noreply.github.com>
Co-authored-by: Jonathan Tsang <98970951+jtsangVA@users.noreply.github.com>
Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Co-authored-by: Enrilo Ugalde <ugalde_enrilo@bah.com>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: Calvin <Calvin.Costa@va.gov>
Co-authored-by: Craig Reese <Reese_Craig@bah.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: (Jeffrey) Aaron Willis <98484567+Aaron-Willis@users.noreply.github.com>
Co-authored-by: Konstantin Shevtsov <166068160+KonstantinShevtsov@users.noreply.github.com>
Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MacBook-Pro.local>
Co-authored-by: Chris-Martine <135330019+Chris-Martine@users.noreply.github.com>
Co-authored-by: kshiflett88 <kodishiflett@gmail.com>
Co-authored-by: root <root@DESKTOP-IBDKNPF>
Co-authored-by: nicorithner-bah <148365039+nicorithner-bah@users.noreply.github.com>
Co-authored-by: Chris-Martine <christopher.martine@va.gov>
Co-authored-by: Matt Ray <matthew.ray@va.gov>
Co-authored-by: Nico Rithner <nicolas.rithner@va.gov>
Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
Co-authored-by: Jonathan Tsang <jonathan.tsang@va.gov>
  • Loading branch information
23 people authored and AdamShawBAH committed Oct 20, 2024
1 parent 347c548 commit cb5877a
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit cb5877a

Please sign in to comment.