Skip to content

Commit

Permalink
APPEALS-26734 and APPEALS-25121 HRT Phases 1 and 2 (#23258)
Browse files Browse the repository at this point in the history
* APPEALS-25117: rspec fix + add docket and id as conference id

* APPEALS-25117: final service updates

* APPEALS-25117: adds webex service rspec and comments to create conference job spec, needs further review

* APPEALS-25117 spec update

* APPEALS-25117 update test

* APPEALS-25117 finish spec update

* APPEALS-25117 correct schema

* APPEALS-34501 update arguments

* APPEALS-34501 added port env var

* APPEALS-34501 updated the feature toggle

* APPEALS-34501 update spec

* Add helper methods to ExternalApi::WebexService::CreateRespons

* Add create_webex_conference

* Conference ID to string

* Set conference_id back

* Rename LinkService to PexipLinkService

* Remove conference_id setting since we dont use it

* Add env vars to controller spec

* Fix failing tests in pexip_conference_link_spec

* Remove nil check

* Fix pexip_link_service_spec failures

* Clean up test file a bit

* APPEALS-34517 render correct data guestlinks

* Fix test link

* Add fixes and fiel changes to create_conference_job_spec

* Whittle down create_conference_job

* Remove env vars that can come back out

* Add FTs to conf job

* APPEALS-34517 updated tests and guestLink DailyDocket

* Lint

* Remove unused mocks

* Fix conf link tests

* Maybe fix some tests

* Controller spec fixes

* Add fix to virtual hearing spec and update factory and model

* Remove defunct check for host link

* Update link_generation_initialized trait across app

* Resolve daily docket spec with new trait name

* Adjust StuckVirtualHearingsChecker

* Adjust daily docket

* Fix async pending tests

* APPEALS-34673: added conditional based on hearing conference provider to display links

* Add update for links

* Update to guestLink rendering

* APPEALS-34673: update snapshot tests, add hearing links to test runs

* APPEALS-34673: revert caseworkerindex snapshot and remove comment

* APPEALS-34673: update snapshot - passes locally

* APPEALS-34673: updates to snapshot

* APPEALS-34673: updates to snapshot

* APPEALS-34673: updates to snapshot

* APPEALS-34880: added nbf and exp methods to hearing day and virtual hearing

* APPEALS-34880: added nbf exp rspec to virtual hearing spec

* APPEALS-34880: added hearing day spec test for nbf and exp and removed comments

* APPEALS-34880: removed comments

* APPEALS-34880: removed comments

* APPEALS-34880: removed spacing in rspec

* APPEALS-34908: added one liners

* APPEALS-34908 update resp

* APPEALS-34908 update json parse

* APPEALS-34908 update send_webex method nil

* APPEALS-34908 update webex_conference_link to string

* APPEALS-34908 update create_response.rb sym to string

* DRY up generate_conference_information

* APPEALS-34908: service and fakes updates

* APPEALS-34908: update request body

* Change param passing

* APPEALS-34908 rspec test fix

* APPEALS-34908: updated webex service spec

* APPEALS-34908 converted hash to json in fake

* Change some names

* APPEALS-35033: change casing for Nbf Exp to nbf exp

* Correct spec file name

* Remove .gitignore diff

* Use .to_json

* APPEALS-35195: update sub to use unique hearing day id

* APPEALS-35195: update hearing day spec to have specific id for hearing day

* APPEALS-35195: change date format

* APPEALS-35728: initial updates to daily docket row

* APPEALS-35728: update logic for type vs conferenceProvider

* APPEALS-35728: updates to test, props, store, snapshot

* Test: Change hearing links label (#20082)

* Change hearing links label

* Update snapshot

* Fix tests

* More snapshots

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Merge branch 'feature/APPEALS-26734' into feature/APPEALS-35295
<!-- Change JIRA-12345 to reflect the URL of the Jira item this PR is associated with -->
Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345)

Please explain the changes you made here.

- [ ] Code compiles correctly

<!-- Change JIRA-12345 to reflect the URL of the location of the test plan(s) for this PR -->
1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below

- [ ] For feature branches merging into master: Was this deployed to UAT?

 - [ ] Screenshots of UI changes added to PR & Original Issue

 BEFORE|AFTER
 ---|---

*For Frontend (Presentation) Components*
* [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`)
* [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy
* [ ] Write a separate story (within the same file) for each discrete variation of the component

*Only for Schema Changes*

* [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables
* [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii)
* [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations))
* [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method))
* [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output)
* [ ] For queries using raw sql was an explain plan run by System Team
* [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
* [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys))
* [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated
* [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary)

* [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
  * [ ] Request: Service name, method name, input field names
  * [ ] Response: Check expected data structure
  * [ ] Check that calls are wrapped in MetricService record block
* [ ] Check that all configuration is coming from ENV variables
  * [ ] Listed all new ENV variables in description
  * [ ] Worked with or notified System Team that new ENV variables need to be set
* [ ] Update Fakes
* [ ] For feature branches: Was this tested in Caseflow UAT

- [ ] Add or update code comments at the top of the class, module, and/or component.

Did you include any test coverage for your code? Check below:
- [ ] RSpec
- [ ] Jest
- [ ] Other

Your code does not add any new code climate offenses? If so why?
- [ ] No new code climate issues added

- [ ] Are performance metrics (e.g., response time, throughput) being tracked?
- [ ] Are key application components monitored (e.g., database, cache, queues)?
- [ ] Is there a system in place for setting up alerts based on performance thresholds?

- [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
- [ ] Are logs structured (e.g., using log tags) for easier querying and analysis?
- [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
- [ ] Is log retention and rotation configured correctly?
- [ ] Are logs being forwarded to a centralized logging system if needed?

- [ ] Are user actions being logged for audit purposes?
- [ ] Are changes to critical data being tracked ?
- [ ] Are logs being securely stored and protected from tampering or exposing protected data?

- [ ] Are errors being caught and handled gracefully?
- [ ] Are appropriate error messages being displayed to users?
- [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
- [ ] Are unhandled exceptions being caught at the application level ?

- [ ] Are custom exceptions defined and used where appropriate?
- [ ] Is exception handling consistent throughout the codebase?
- [ ] Are exceptions logged with relevant context and stack trace information?
- [ ] Are exceptions being grouped and categorized for easier analysis and resolution?

* APPEALS-31618 add migration files

* APPEALS-31618 rmove migration

* APPEALS-31618 0fficial add co_host_hearing_link

* APPEALS-31618 Add co_host_link to conference_links

* APPEALS-31618 added code for co-host

* APPEALS-31618 remove attribute conferencelinks

* APPEALS-31618 update tests

* APPEALS-31618 update lint

* APPEALS-31618 update VirtualHearingsFields snapshot

* APPEALS-31618 update details.test.js snapshot

* APPEALS-31618 update create_conference_job_spec

* APPEALS-31618 updated Marcs sugestions rnd 1

* jefftmarks/APPEALS-31619 (#20515)

* APPEALS-31619 Created migration

* APPEALS-31619 Add xls column to migration

* APPEALS-31619 Update index name

* APPEALS-31619 Change null options on migration

* APPEALS-31619 Refactor transcription files table

* APPEALS-31619 Remove old migration

* APPEALS-31618 updated migration inheritance

* Min/APPEALS-31621 (#20523)

* APPEALS-31621 added the table

* APPEALS-31621 moved model under hearings folder

* APPEALS-31621 reverted schema back from testing table

* APPEALS-31621 added transcriptions association

* APPEALS-31621 fixed typo

* APPEALS-31621 removed migration file

* APPEALS-31621 added additional template methods in model and comments

* APPEALS-31621 fixed transcription typo

* APPEALS-31621 added additional template methods

* APPEALS-31621 changed name of model and controller

* APPEALS-31621 removed transcript association

* hotfix/APPEALS-35296-flaky-conference-job-test (#20555)

* akonhilas/APPEALS-31820 (#20510)

* APPEALS-31820: create transcription transactions serializer with outline until model complete

* APPEALS-31820: update aws link attributes

* APPEALS-31820: removed methods and has many relationship, change file name

* APPEALS-31820: updated file tree

* Revert "APPEALS-31820: updated file tree"

This reverts commit 4b58d5a.

* APPEALS-31820: updated serializer to match new db columns and updated AC

* APPEALS-35177 adjust spacing

* APPEALS-35177 fix lint

* APPEALS-35177 made final positioning adjustments

* APPEALS-35176 - Pull radio buttons closer and tidy up the CSS

* jefftmarks/APPEALS-31619 Remove unique contraints on indexes (#20620)

* APPEALS-31619 Created migration

* APPEALS-31619 Add xls column to migration

* APPEALS-31619 Update index name

* APPEALS-31619 Change null options on migration

* APPEALS-31619 Refactor transcription files table

* APPEALS-31619 Remove old migration

* APPEALS-31619 Remove unique contraints on indexes

* APPEALS-31619 Change index order

* APPEALS-31619 Move docket number in index

* Allow NonVirtual Webex hearings to display the HC link on the Hearing Details page

* APPEALS-36652 Backend changes

* Display only Virtual Hearing Links for virtual hearings and only Hearing Links for nonvirtual hearings

* APPEALS-36652

* APPEALS-35176 - Update html and css to better match the figma design

* Refine conference provider search so that correct links show up for pexip conferences

* APPEALS-35176 - Update radio button to align better with label

* Add daily docket conference links to legacy appeals

* Add daily docket conference link to the nonvirtual webex hearing links

* Show non virtual webex HC link

* APPEALS-35176 - Make margins more consistent across browsers

* Update feature tests to remove old conditions

* APPEALS-36652 heearing_spec update

* Updated jest testing in progress

* Add nonvirtual webex test - in Progress

* Add test with default props back into test file

* Remove unnecessary test and resolve testing errors with webex hearinglinks tests

* Show hearing links titles and clickable link

* Update jest snapshots

* Capitalize webex hearing styling

* akonhilas/APPEALS-38906 (#20664)

* APPEALS-38906: updates to service, created new file for job

* APPEALS-38906: response, updates to query, finalizing job, fakes

* APPEALS-38906: add query to call

* APPEALS-38906: add scheduled jobs, cgi formatting, exponential backoff, add get post to service, service spec updates

* APPEALS-38906: added get webex recording job spec, changed timing for to and from params in job

* APPEALS-38906: pushing failing tests for visibility

* APPEALS-38906: pushing tests for visibility

* APPEALS-38906: final test updates

* APPEALS-38906: remove comments, time updates, va ops email comment

* APPEALS-38906: fixed rspec and removed unnecessary error raise from job

* jefftmarks/APPEALS-38907 (#20659)

* APPEALS-31821 created job file and template

* APPEALS-38907 Create download transcription file job

* min/APPEALS-31821 made new helper method templates for use on perform

* APPEALS-38907 Continue prototype

* APPEALS-31821 basic webvtt to rtf conversion and tmp folder initializers

* APPEALS-38907 Complete basic structure for job

* APPEALS-38907 Update error handling

* APPEALS-31821 gathering info for the front page

* APPEALS-38907 Add error handling for invalid file name

* APPEALS-38907 Add error handling for invalid file type

* APPEALS-38907 Fix linting

* APPEALS-38907 Open URI CodeQL fix

* APPEALS-31821 generating a table for the front page info

* APPEALS-31821 generating header info for first page cell

* APPEALS-38907 Update initializer to create subdirectory for each file type

* APPEALS-38907 Update code comments

* APPEALS-31821 most info appearing on first page now

* APPEALS-31821 stashing regexes for future use

* APPEALS-31821 vtt fully converted to rtf

* APPEALS-38907 Implement S3 upload

* APPEALS-38907 Update comments

* APPEALS-31821 page numbers and footers now displaying

* APPEALS-31821 texts from the same speaker is now consolidated

* APPEALS-31821 refactored footer creation on document

* APPEALS-38907 Complete implementation of job minus va ops email

* APPEALS-38907 Update S3 bucket and folder names

* APPEALS-31821 S3 download and upload implemented and tmp file clean up

* APPEALS-31821 S3 download and upload implemented and tmp file clean up

* APPEALS-38907 Polish error handling before moving on to tests

* APPEALS-31821 added error handling and logging

* APPEALS-31821 repurposed class into a workflow

* APPEALS-31821 removed mailer

* APPEALS-38907 Connect job with TranscriptionTransformer workflow

* APPEALS-38907 Small fixes after writing xray tests

* APPEALS-31821 added rspec tests and refactored workflow

* APPEALS-38907 Finish spec files

* APPEALS-31821 removed the new datadog metrics that was made

* APPEALS-31821 removed the new datadog metrics that was made

* APPEALS-31821 added back old datadog metrics

* APPEALS-31821 removed ext_claim schema

* APPEALS-31821 moved transcription_transformer to workflow folder

* APPEALS-38907 Complete spec

* APPEALS-31821 adjusted rspec tests and fixed minor edgecase for empty string identifiers

* APPEALS-31821 fixed minor formatting issues

* APPEALS-31821 edited spacing

* APPEALS-31821 added error class back

* APPEALS-38907 Fix argument being passed to TranscriptionTransformer

* APPEALS-38907 Fix footer on rtf layout

* APPEALS-38907 Fix spec to mock TranscriptionTransformer correctly

* APPEALS-38907 Change URI.open call to be more safe

---------

Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

* Refactor double returns to a single return

* Update snapshots

* Remove unnecessary commented out code

* Update linting issues

* Fix linting error

* Update snapshots for jest testing

* jefftmarks/APPEALS-40657 (#20851)

* APPEALS-40657 Refactor DownloadTranscriptionFileJob

* APPEALS-40657 Refactor TranscriptionFile

* APPEALS-40657 Refactor UploadTranscriptionFileToS3 workflow

* APPEALS-40657 Refactor DownloadTranscriptionFileJob spec

* APPEALS-40657 Update migration and model for TranscriptionFile to associate with hearing instead of appeal

* APPEALS-40657 Update DownloadTranscription job to save records with hearing instead of appeal attributes

* APPEALS-40657 Update subject for conference to include hearing attributes instead of appeal

* APPEALS-40657 Schema

* APPEALS-40657 Fix failing spec in virtual hearing spec

* APPEALS-40657 Update comment in migration

* APPEALS-40657 Update schema

* Min/APPEALS-39905 (#20853)

* APPEALS-39905 audible text will now be displayed as [INAUDIBLE]

* APPEALS-39905 csv getting made and uploaded when inaudibles are found

* APPEALS-39905 turned tmp clean up back on

* APPEALS-39905 adjusted rspec tests

* APPEALS-39905 adjusted transformer rspec tests

* APPEALS-39905 added more rspec tests to transformer workflow

* APPEALS-39905 added guards for nil values in hearing info

* added byebug

* removed byebug

* APPEALS-39905 Resolve merge conflicts in download transcription job spec

* APPEALS-39905 changed inaudible display

* APPEALS-39905 changed test url back

* APPEALS-39905 converts input vtt to readable format if invalud utf is found

* APPEALS-39905 adjusted rspec tests

---------

Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>

* akonhilas/APPEALS-31620 (#20788)

* APPEALS-31620: initial commit

* APPEALS-31620: finished all webex service/response/fakes/spec updates

* APPEALS-31620: adding recording details job

* APPEALS-31620: cannot get past rspecs here

* APPEALS-31620: update rspecs

* APPEALS-31620: add file

* APPEALS-31620: finalized rspecs, removed Hearings prepend - unnecessary after rebuild

* APPEALS-31620: resolve webex service rspec

* APPEALS-31630: code cleanup

* APPEALS-31620: remove hearings prepend, perform_later, scheduled_for, regex

* APPEALS-31620: rspec

* jefftmarks/APPEALS-40909 (#20951)

* APPEALS-40909 Create migration and write spec tests

* APPEALS-40909 Update conference_link model to associate with polymorphic hearing

* APPEALS-40909 Write spec for add index to conference links

* APPEALS-40909 Add spec to test conference link factory after null constraint removed

* APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA

* APPEALS-40909 Implement database cleaner fix and write down test for index migration

* APPEALS-40909 Test conference links can belong to hearings and hearing days

* APPEALS-40909 Remove migration tests

* APPEALS-40909 Refactor delete conference link job spec to avoid static record count

* APPEALS-40909 Fix duplicate examples in download transcription file spec

---------

Co-authored-by: Adam Ducker <adam.ducker@va.gov>

* APPEALS-39907  (#20952)

* APPEALS-39907 Initial commit

* APPEALS-39907 update convention

* APPEALS-39907 update render call

* APPEALS-39907 update to/from within .erb

* APPEALS-39907 added to and from attributes

* APPEALS-39907 to/from update

* APPEALS-39907 direction update

* APPEALS-39907 conditional added

* APPEALS-39907 update conditional

* b_reed/APPEALS-39907 added mailing in error handling for DownloadTranscriptionFileJob and GetWebexRecordingDetailsJob

* APPEALS-39907 added more mailing code for error handling

* APPEALS-39907 adjusted rspec tests

* APPEALS-39907 Unit tests complete

* APPEALS-39907 adjusted lint

* APPEALS-39907 update class ActionMailer

* APPEALS-39907 added comments

* APPEALS-39907 removed redundant unit test

* APPEALS-39907 update demo url

* APPEALS-39907 seperated env instances

* APPEALS-39907 update id fetch method ln: 209

* APPEALS-39907 remove filename parameter ln: 32

* APPEALS-39907 added filename argument back

* APPEALS-39907 added the lint disabler back

* APPEALS-39907 updated demo env test

* b_reed/APPEALS-39907 fixed minor issue with argument names

* APPEALS-39907 updated how appeal ids are found

* APPEALS-39907 more minor fixes

* APPEALS-39907

* APPEALS-39907 email address to send mail and cc now changes depending on rails env

* APPEALS-39907 fixed rspec tests

* APPEALS-39907 Update html doc layout

* APPEALS-39907 adjusted email addresses and some refactors

* APPEALS-39907 adjusted rspec tests

* APPEALS-39907 update case statements

* APPEALS-39907 email preview template

* APPEALS-39907 update values

* APPEALS-39907 added appeal id

* APPEALS-39907 previewer lint

* APPEALS-39907 remove blank space

* APEALS-39907 disable actionMailer lint

* APPEALS-39907 fixed rspecs

* APPEALS-39907 config file update

---------

Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>

* akonhilas/APPEALS-40915 (#20948)

* APPEALS-40915: initial commit

* APPEALS-40909 Create migration and write spec tests

* APPEALS-40909 Update conference_link model to associate with polymorphic hearing

* APPEALS-40909 Write spec for add index to conference links

* APPEALS-40909 Add spec to test conference link factory after null constraint removed

* APPEALS-40909 Uncomment out code in migration to see if tests pass on GHA

* APPEALS-40915: updated comments to job

* APPEALS-40909 Implement database cleaner fix and write down test for index migration

* APPEALS-40915: added error catching, updated hearing model, removed webex hearing day link creation

* APPEALS-40915: updated existing rspec tests to include/exclude  new functionality

* APPEALS-40909 Test conference links can belong to hearings and hearing days

* APPEALS-40915: prepping branch for merge

* APPEALS-40915: job creates a hearing conference link

* APPEALS-40915: updating rspecs

* APPEALS-40915: finished rspecs

* APPEALS-40915: nullifying link values to resolve frontend errors

* APPEALS-40915: added create nv conf call to correct spot, removed old code/rspecs

* APPEALS-40915: final rspec addition

* APPEALS-40915: remove migration specs

* APPEALS-40915: add code review updates

---------

Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Adam Ducker <adam.ducker@va.gov>

* Missed rubocop merge conflict

* akonhilas/APPEALS-40921 (#21116)

* APPEALS-40921: added method to concern and reference to both hearing serializers

* APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors

* APPEALS-40921: change get to fetch, conference link find by hearing, fix rubocop lint errors

* Min/APPEALS-37605 (#21151)

* APPEALS-37605 added route and test json response

* APPEALS-37605 file now gets downloaded onto local computer

* APPEALS-37605 added user verification

* min/APPEALS-37605 added rspec and factory for transcription_file

* APPEALS-37605 finished writing rspec tests

* APPEALS-37605 finished writing rspec tests

* APPEALS-37605 added more error handling

* APPEALS-37605 Move controller back to hearings folder

* APPEALS-37605 Remove unused methods from controller

* APPEALS-37605 Move transcription_file_spec to hearings folder

---------

Co-authored-by: msteele <Marc.Steele@va.gov>

* jefftmarks/APPEALS-37292-37293 (#21140)

* APPEALS-37292 Create transcription files table

* APPEALS-37292 Adjust table styling

* APPEALS-37292 Update legacy conditional to show transcription details

* APPEALS-37292 Conditionally render different sections of transcription details

* APPEALS-37292 Implement useState and useEffect to reduce renders on table

* APPEALS-37293 Populate table with updated transcription file serializer

* APPEALS-37292-37293

* APPEALS-37293 Comment code

* APPEALS-37293 Update snapshot

* APPEALS-37292-37293 Update snapshot

* APPEALS-37293 Revert transcription files controller

* APPEALS-37293 Update Details jest test

* APPEALS-37293 Add date attribute to hearings data for jest test

* APPEALS-37293 Update imports on Details.jsx jest test

* APPEALS-37293 Update hearing concern with transcription file by recording method

* APPEALS-37292 Update LegacyHearing model and serializer

* APPEALS-37293 Update feature test for details page

* APPEALS-37293 Fix typo in table id

* APPEALS-37293 Add aws link to factory

* APPEALS-37293 Fix hearing links snapshot to pass jest test

* APPEALS-37293 Fix hearing factory

* APPEALS-37293-37293

* APPEALS-37293 Fix transcription files controller spec

* APPEALS-37293 Update to group files on table by docket number

* APPEALS-37293 Refactor route/controller without responds_to and move css

* APPEALS-37293 Fix feature test to reflect route update

* APPEALS-37293 Fix linting on css

* APPEALS-37293 scss lint

* BelongsToPolymorphicHearingConcern updates from Rails 6.0

* jefftmarks/APPEALS-40907 (#21249)

* APPEALS-40907 Create polymorphic hearing concerns specific to conference links and transcription files and update models

* APPEALS-40907 Remove unnecessary polymorphic concerns

* APPEALS-40907 Update daily docket for one to one nonvirtual webex conference links

* APPEALS-40907 Update models

* APPEALS-40907 Update models

* APPEALS-40907 Update and remove jest tests

* Min/APPPEALS-42711 (#21285)

* APPEALS-42711 adjusted query for webex recordings list

* APPEALS-42711 added rspec tests for webex_conference_link

* APPEALS-42711 some code climate refactors

* APPEALS-42711 fixed code climate issues and webex service argument refactor

* APPEALS-42711 fixed som broken rspec tests

* APPEALS-42711 fixed a few code climate issues with mailer

* APPEALS-42711 refactored more code climate issues with mailer and webex implementation

* APPEALS-42711 fixed broken rspec tests and finishing up with clearing up viable code climate issues

* APPEALS-42711 fixed some broken rspec tests and more code climate issues

* APPEALS-42711 changed names of classes and methods to fix code climate issue

* APPEALS-42711 changed names of classes and methods to fix code climate issue

* APPEALS-42711 changed names of classes and methods to fix code climate issue

* APPEALS-42711 added max value back in to webex recordings

* APPEALS-42711 added max value back in to webex recordings

* min/APPEALS-42711 adjusted query

* APPEALS-42711 refactored some code

* akonhilas/APPEALS-40906 (#21165)

* APPEALS-40906: remove sub nbf exp from hearing_day

* APPEALS-40906: updates to serializer, coHostHearingLink to coHostLink, proper conditionals for virtual vs non virtual

* APPEALS-40906: Update so many jest tests and test data

* APPEALS-40906: merge latest from feature

* APPEALS-40906: Update snapshots after merge

* APPEALS-40906: updates to feature test

* APPEALS-40906 change serializer debug attempt

* APPEALS-40906 Revert previous debugging commit and add isVirtual back to VirtualHearingLink.jsx

* APPEALS-40906 Return references of conference_links to conference_link

* APPEALS-40906 Duplicate changes from hearing_serializer to legacy_hearing_serializer

* APPEALS-40906 Update failing spec and serializer

* APPEALS-40906 Allow for null links prop in LinkContainer in HearingLinks.jsx

* APPEALS-40906 Ensure correct classname and button text for hearing coordinator link

* Fix hearing_day_spec to user singular conference link

* Update hearing details snap shots

* APPEALS-40906 Update Details.test.js snapshot

* APPEALS-40906 Fix hearing details feature by adding was virtual to HearingLinks.jsx

* APPEALS-40906 Remove hearing links from central and video details page

* Uncomment hearing details feature spec

* APPEALS-40906 Remove hearing links from details if hearing type video and hearing in past

* APPEALS-40906 Add bang operator

* APPEALS-40906 Update Hearing Links jest to not use redux store

* APPEALS-40906 Remove console.log

* APPEALS-40906 Remove console.log

* APPEALS-40906 Ensure hearing day links replace virtuali nks when converted from virtual to video

* APPEALS-40906 Update snapshots

* APPEALS-40906 Update hearing serializers so attributes conform across virtual and nonvirtual conference links

* APPEALS-40908 Update HearingLinks UI to show copy link button at all times

* APPEALS-40906 Update hearing details feature test to reflect hearing links for all hearing types

* APPEALS-40906 Fix jest test props for HearingLinks test

* APPEALS-40906 Uncomment out jest config

* APPEALS-40906: remove unused code from hearing links test

* APPEALS-40906: move non virtual conference link to hearing concern

---------

Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

* Min/APPEALS-43214 (#21344)

* APPEALS-43214 added new error handling for file upload and new param to custom exception

* APPEALS-43214 wrote rspec tests and made some adjustment to error handlers

* rerun checks

* rerun checks

* APPEALS-43214 adjusted failing rspec

* APPEALS-43214 Linting fix

* APPEALS-43214 Indentation fixes

* APPEALS-43214 Update mailer to handle different transcription file jobs

* APPEALS-43214 Added beginning of hour to webex list calls

* APPEALS-43214 Update mailer to show download link and fix failing test

* APPEALS-43214 Refactor transcription file issues mailer

* APPEALS-43214 Remove old spec file

* APPEALS-43214 Refactor content section of mailer

* APPEALS-43214 Add missing comma

* APPEALS-43212 Refactor mailer to render nested lists

* APPEALS-43214 Update prodtest email and demo vs dev distinction

* APPEALS-43214 Linting and fixes to create conference job

* APPEALS-43214 Call job#extra

* APPEALS-43214 job#log_error

* APPEALS-43214 Remove extra method

* APPEALS-43214 Fix log error issue

* APPEALS-43214 Fix typo

* APPEALS-43214 Incorporate action direction into job action hash

* APPEALS-43214 Remove byebug

---------

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>

* b_reed/APPEALS-34071-v2 (#21422)

* Add rcredstash and dynamodb

* Update ports

* Fix m1 docker compose

* Add kms

* Add initializers

* Upgrade aws-sdk

* Lint roll

* Update table name

* Add back VirtualHearings::RefreshWebexAccessTokenJob

* Add refresh_access_token method to ExternalApi::WebexService

* Add back AccessTokenRefreshResponse

* Add back in error handling in Webex Response class

* Add new job to SCHEDULED_JOBS

* Add WebexInvalidTokenError error class

* Add refresh_access_token to fake WebexService

* Add back in specs

* APPEALS-34071 bundle install additions gemfile.lock

* APPEALS-34071 slim out test

* Fix the 'levers exists' message overwritting test output

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Move methods from hearing.rb to hearing concern and add default aws region to resolve error

* Match yarn.lock to master

* Update ref for caseflow-commons

* Update gemfile.lock

* Update scheduled jobs key and move job to different folder

* Update job to set user manually and pass in updated_by

* msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492)

* APPEALS-45182 Reinforce has_many relationships

* APPEALS-45182 Add missing comma

* Resolve lint issue

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Hotfix/APPEALS-45218 (#21503)

* APPEALS-45218 reverted webex config arguments

* APPEALS-45218 reverted webex config arguments

* APPEALS-25218 Update WebexService to remove config in favor of individual arguments

* APPEALS-45218 Format comment

---------

Co-authored-by: msteele <Marc.Steele@va.gov>

* B_reed/hotfix_APPEALS-45285 (#21531)

* APPEALS-45285 Bug Fix

* APPEALS-45285 update pexip_service_spec

* APPEALS-45285 remove white space

* Hotfix/APPEALS-45218-v2 (#21522)

* APPEALS-45218 reverted webex config arguments

* APPEALS-45218 reverted webex config arguments

* APPEALS-45218 added query argument to webex conference link

* APPEALS-45218: webex recordings endpoint correction

* APPEALS-45218 adjusted arguments during inititalizing of refresh tokens

* APPEALS-45218 fixed rspec

* APPEALS-45218: added error catching on webex service response

* APPEALS-45218: remove tested code

* APPEALS-45218 Go back to leveraging HTTPI response inherited methods

---------

Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: msteele <Marc.Steele@va.gov>

* msteele/APPEALS-45349 (#21539)

* APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error

* APPEALS-45349 Flip conditionals

* APPEALS-45349 Fix linting errors

* hotfix/APPEALS-45399-45401-45472 (#21555)

* APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash

* APPEALS-45399-45401 Remove CGI escape from fetch webex list job

* APPEALS-445399-45401 Update spec files for webex list and details job

* APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery

* Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery"

This reverts commit d9ce585.

* hotfix/APPEALS-45472 (#21562)

* APPEALS-45472 Refactor error handling for transcription

* APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer

* Hotfix/APPEALS-45818 (#21632)

* APPEALS-45818: parsing fix, remove topic param, fix response

* APPEALS-45818: revert list and details job back to original state, update tests

---------

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

* msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634)

* APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument

* APPEALS-45285 Update spec to use virtual_hearing

* APPEALS-45285 Linting fixes

* hotfix/APPEALS-45828 (#21625)

* APPEALS-45828 Include call to create webex conference links in base hearing update form

* APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual

* Fix needing to reload to display co host link on details page

* Fix incorrect method name

* Remove temporary rendering of default pexip link for webex hearings after conversion

* APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT

* APPEALS-45828 Remove file name argument from fetch details job spec

* APPEALS-45828 Fail on bad hearing link if link nil or legacy link

* APPEALS-45828 Sanitize url string

* APPEALS-45828 Undo url sanitize

* Remove unused styles after merge

* APPEALS-45285 added conditional to handled nil conference ids (#21766)

Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>

* feature/APPEALS-45998 Webex Rooms API Workaround (#21810)

* Min/APPEALS-46009 (#21690)

* APPEALS-46005: job, job logic, env placeholder, schedule update

* APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service

* APPEALS-46011 Update fakes

* APPEALS-46005: merge 46011 logic updates

* APPEALS-46009 added the new webex room details job

* APPEALS-46011 Update specs

* commenting out code

* commenting code back in

* APPEALS-46009 adjusted rspec tests

* APPEALS-46009 adjusted rspec tests

* APPEALS-46005: add rspec, comment out rooms details call, final filter

* APPEALS-46009 adjusted rspec tests

* APPEALS-46005: rough filter test added to rooms list spec commented out

* APPEALS-46009 adjusted rspec tests

* APPEALS-46009: filter rspec, filter in rooms list job, add fake data

* APPEALS-46009: resolved comments

---------

Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>

* akonhilas/APPEALS-46006 (#21734)

* APPEALS-46006: initial updates to recordings list job, recordings list resp, recordings details job, room meeting details job

* APPEALS-46006: webex service spec update, fake update, recordings list response update

* APPEALS-46006: recordings details job and spec updates, lint fix recordings list job

* APPEALS-46006: recordings list spec and job updates

* APPEALS-46006: room meeting details spec updates

* APPEALS-46006: final updates to fake data

* APPEALS-46006: changing topic to actual webex response

* APPEALS-46006 create and use self.acceses_token method in WebexService classes

* APPEALS-46006 Update failing rspec for Details and List Jobs

* APPEALS-46006: update mailer, preview, specs, lint error

---------

Co-authored-by: msteele <Marc.Steele@va.gov>

---------

Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>

* Hotfix/APPEALS-46083 (#21832)

* Min/APPEALS-46009 (#21690)

* APPEALS-46005: job, job logic, env placeholder, schedule update

* APPEALS-46011 Add fetch rooms list and fetch room details methods to webex service

* APPEALS-46011 Update fakes

* APPEALS-46005: merge 46011 logic updates

* APPEALS-46009 added the new webex room details job

* APPEALS-46011 Update specs

* commenting out code

* commenting code back in

* APPEALS-46009 adjusted rspec tests

* APPEALS-46009 adjusted rspec tests

* APPEALS-46005: add rspec, comment out rooms details call, final filter

* APPEALS-46009 adjusted rspec tests

* APPEALS-46005: rough filter test added to rooms list spec commented out

* APPEALS-46009 adjusted rspec tests

* APPEALS-46009: filter rspec, filter in rooms list job, add fake data

* APPEALS-46009: resolved comments

---------

Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>

* APPEALS-46083 hearing details page now shows NA when hearing is converted from virtual to non or if postponed

* APPEALS-46083 fixed conditional for cancelled hearings and virtual hearings

---------

Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>

* akonhilas/APPEALS-46130 (#21804)

* APPEALS-43160: Fix linting errors in OrgUsers

* APPEALS-43160: fix margins and move divider

* APPEALS-43160: remove margin top on search bar styling

* APPEALS-43160: fix webex lint errors

* APPEALS-43160: move radio button style div inside visibility check

* APPEALS-46130: move css inline style to scss

* APPEALS-46130: fix lint errors, remove gray line

* Hotfix/APPEALS-48161 (#21917)

* APPEALS-48161: remove, refactor, fake update, specs, filename update

* APPEALS-48161: kickoff gha on right branch merge

* APPEALS-48161: filter title call only once

* APPEALS-46385: remove s, add aws-sdk, bundle install, move rcredstash up (#21941)

* Adjust spacing in gemfile

* Hotfix/APPEALS-49560 (#22015)

* APPEALS-49560 moved non-virtual conference link creation to hearing concern

* APPEALS-49560 moved non_virtual conference creation inside of reschedule method

* APPEALS-49560 added a new spec test to test link creation

* APPEALS-49560 refactored rspec

* APPEALS-49560 removed additional method in after_create to prevent risk of duplication

* APPEALS-49560 removed additional method in after_create to prevent risk of duplication

* Hotfix/APPEALS-49624 (#22016)

* APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks

* APPEALS-49624: add rooms and room details to mailer preview, correct api url

* APPEALS-49624: cleaning up rspecs

* APPEALS-49624: update query format, add mailer tests

* APPEALS-49624: update mailer keys

* APPEALS-49624: fix lint errors

* APPEALS-49624 Remove rubocop ignores and fix query format

---------

Co-authored-by: msteele <Marc.Steele@va.gov>

* Remove extra newline for Rubocop

* Hotfix/Appeals-49560-v2 (#22052)

* APPEALS-49560 moved non-virtual conference link creation to hearing concern

* APPEALS-49560 moved non_virtual conference creation inside of reschedule method

* APPEALS-49560 added a new spec test to test link creation

* APPEALS-49560 refactored rspec

* APPEALS-49560 removed additional method in after_create to prevent risk of duplication

* APPEALS-49560 removed additional method in after_create to prevent risk of duplication

* APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask

* Update app/models/concerns/hearing_concern.rb

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

---------

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

* Remove extra newline after merge conflict

* Recover lost code to compress multiple lines by same speaker into one large block

* Reintroduce code after bad merge conflict resolution

* Min/APPEALS-50859 (#22081)

* remediated code climate issues

* remediated code climate issues

* remediated code climate issues

* fixed duplicate code issues

* fixed duplicate code issues

* fixed duplicate code issues

* APPEALS-50859 added new concern to abstract duplicate code

* APPEALS-50859 fixed new concern climate issues

* APPEALS-50859 added new config method for rooms endpoints to concern

* APPEALS-50859 added new config method for rooms endpoints to concern

* APPEALS-50859 added new config method for instant connect to concern

* APPEALS-50859 added new config method for instant connect to concern

* Update bundler version

* Remove duplicate method

* Fix bad merge conflict resolution

* Remove x86_64 platforms, add ruby platform

* Remove bad metrics line

* akonhilas/APPEALS-59152 (#22973)

* APPEALS-59152: removed unnecessary logic, color.primary

* APPEALS-59152: update snapshot tests

* Merge hotfix/APPEALS-59907 into feature/APPEALS-25121

* Reapply hotfix/APPEALS-60945 to feature/APPEALS-25121

* Edit bad down migration to use SQL

---------

Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: breedbah <brandon.reed3@va.gov>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
Co-authored-by: 631862 <lauren.thompson@va.gov>
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeffrey.marks@va.gov>
  • Loading branch information
15 people authored and sbashamoni committed Oct 21, 2024
1 parent e1039b3 commit ee41d21
Show file tree
Hide file tree
Showing 14 changed files with 36,370 additions and 7,175 deletions.
11 changes: 9 additions & 2 deletions client/test/app/hearings/components/Details.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import {
legacyHearing,
amaHearing,
defaultHearing,
virtualHearing
virtualHearing,
amaWebexHearing,
legacyWebexHearing
} from 'test/data';
import Details from 'app/hearings/components/Details';

Expand Down Expand Up @@ -63,7 +65,12 @@ describe('Details', () => {
expect(screen.getAllByRole('heading', {name: convertRegex("Hearing Details")}).length).toBeGreaterThan(0);

// Ensure that the virtualHearing form is not displayed by default
expect(screen.queryByRole('heading', {name: "Virtual Hearing Links"})).toBeNull();
expect(details.find(VirtualHearingFields).prop('virtualHearing')).toEqual(
null
);
// VirtualHearingFields will always show for any virtual or non virtual hearing
// as we move forward with Webex integration
expect(details.find(VirtualHearingFields).children()).toHaveLength(1);

// Ensure the transcription section is displayed by default for ama hearings
expect(screen.getByRole('heading', {name: "Transcription Details"})).toBeInTheDocument();
Expand Down
Loading

0 comments on commit ee41d21

Please sign in to comment.