Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feature/appeals 59217.uat fy25 q1.1.0 (#23185)
* Ricky/appeals-43523 (#21345)
* Added Assignment Queue link to Switch Users test page
* Updated controller to validate role and redirect
* Updated error information
* Updated rspec tests
* Ricky/appeals 43965 (#21431)
* Added Download Ineligible Judge List
* APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369)
* Updated query to include css_id and updated id fetch
* Updates button styling, fixed csv to have all values but judge name
* Updated id to sattyid values, and added name data to column
* fixed linting error
* Updated logic to account for inactive users in both caseflow and vacols
* Updated button component and cleaned up code
* Updated handling of ids in situation where sattyid is unavailable in record
* Updated to have individual columns for caseflow id and satty id
---------
Co-authored-by: 631068 <rickybmanus@gmail.com>
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
* mbeard/APPEALS-43118 (#21416)
* APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369)
* init commit
* fixes linting issues
* capybara test init
* capybara test complete steps
* updates copy file with missing copy
* removes random changed files from push priority
* using different test methods find_field and find_button
* commented out test for now
* added the raven command back
* uncommented the frozen string literal comment to address the linting offense
---------
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
Co-authored-by: 631966 <amy.detwiler@va.gov>
* Changed dockerfile to install node through NVM
* Update env.sh with node 14.20 path
* Removed unused node env
* APPEALS-40574 updating the route to only be in demo, local, and test
* Update Dockerfile Removed unused node env variable
* Removed unused node env
* APPEALS-40574 removed the yarn node line as suggested by the system team
* updates copy, styling, and rebases to new feature branch (#22892)
* APPEALS-53821. Fix the ACD test page (#22906)
Co-authored-by: SHarshain <spoosa@razortalent.com>
* APPEALS-43987. Added button and functionality (#22940)
* APPEALS-43987. Added button and functionality
* Sharsha/appeals 43987.amybids (#22957)
* some working tests
* APPEALS-43987. fix the last jest failure
* APPEALS-43987. cleaup
---------
Co-authored-by: SHarshain <spoosa@razortalent.com>
---------
Co-authored-by: SHarshain <spoosa@razortalent.com>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* APPEALS-53821. Text fixes (#22974)
Co-authored-by: SHarshain <spoosa@razortalent.com>
* address missed merge conflict
* APPEALS-58970 Fix text wrapping issue (#23012)
* APPEALS-58970 FIx text wrapping issue
* REmove test text
* Update snapshot
* FIx 508 issue
* Update snapshot
---------
Co-authored-by: Christopher Detlef <>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* APPEALS-53821. Typo (#23050)
Co-authored-by: SHarshain <spoosa@razortalent.com>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* Chrisbdetlef/appeals 58970 (#23071)
* APPEALS-58970 FIx text wrapping issue
* REmove test text
* Update snapshot
* FIx 508 issue
* Update snapshot
* Ensure label text passes all 508 compliance tools
* Update snapshot
---------
Co-authored-by: Christopher Detlef <>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* mbeard/APPEALS-41138 (#22991)
* creates new button for seeding optional seeds, and initial copy for button and description
* adds timestamp and correct copy to success banner
* fixes merge issues and updates missing copy and case
* re-adds missing prop
* initial spec creation
* updates to test, copy, and function to dynamically grab count from api
* adds updates to the backend for dynamic appeal_count
* fixes front end breaking point and adds dynamic seed count to the backend for optional_seeds
* fixes scroll arrow issue, and updates capybara - still failing
* latest rspec updates and copy
* updates test from capybara to jest to test function only, turns on seeds
* Removed useless html prop
---------
Co-authored-by: 631068 <rickybmanus@gmail.com>
* APPEALS-59247. fix the flicking test (#23066)
Co-authored-by: SHarshain <spoosa@razortalent.com>
* APPEALS-43987. Sync the spacing with other button (#23069)
Co-authored-by: SHarshain <spoosa@razortalent.com>
Co-authored-by: 631966 <amy.detwiler@va.gov>
* APPEALS-53821. revert changes from copy json (#23084)
Co-authored-by: SHarshain <spoosa@razortalent.com>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* mbeard/APPEALS-41138 (#23086)
* creates new button for seeding optional seeds, and initial copy for button and description
* adds timestamp and correct copy to success banner
* fixes merge issues and updates missing copy and case
* re-adds missing prop
* Merge `feature/APPEALS-41559` into `release/FY24Q4.6.1` (#23036)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206)
* Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue.
* Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands.
* Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns.
* Overrode the remand model association to request issues so active record joins will work correctly.
* Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing.
* Code climate fixes and test fixes.
* Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method.
* Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* JHoang/APPEALS-42318 (#22270)
* some preliminary remand & sc model updates
* typo
* some preliminary hlr checks?
* undo seed change
* decision issue and sc updates
* attempt code climate fixes
* another code climate fix
* testing changes
* useless variable..
* fix conditional in decision issue
* fix undefined find_by method
* attempt rspec fix
* rspec fix attempt #2
* supplemental_claim_spec fix?
* remove comma
* code climate fix
* added comment for transparency on remand creation, attempt fix for remands route
* updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type
* fix lint error
* fix lint error #2
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-42458 (#22365)
* disable edit issues link for remands
* add banners explaining that remands are not editable
also makes sure that remands are not editable on the edit issues page
* TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356)
* Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter.
* Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
* SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359)
* initial verison of update script
* remanded migration file
* updated sc spec with type
* schema
* fixed a few issues in the migration
* small fix to migration file
* moved the type column check into a seperate it block
* fixed wrong column in migration file
* created a new migration for creating the view
* updated the backfill migration file
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* J hoang/appeals 44940 (#22428)
* initial
* some factory and spec updates
* change history query update and spec fixes
* code climate/lint fix
* change @claim_type identifier
* fix claim_history_event_spec.rb
* test coverage for change history with Remand claim type
* spec lint fixes
* refactor claim_type filtering to account for remand subtype
* business_line_spec fix
* decision_reviews_controller_spec update for remand claim type
* lint fixes for decision_reviews_controller_spec.rb
* comment updates in business_line.rb
* renamed mock data in change_history_reporter_spec
* trigger GA
* refactor claim type filter for less conditional handling
* business line spec fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Initial commit for the brakeman sql injection warning fixes. (#22598)
* Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825)
* added fix for failing test in decision_reviews_controller_spec (#22829)
---------
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
* APPEALS-50679 | Reassign Cases To Camo Change History (#23038)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206)
* Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue.
* Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands.
* Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns.
* Overrode the remand model association to request issues so active record joins will work correctly.
* Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing.
* Code climate fixes and test fixes.
* Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method.
* Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* JHoang/APPEALS-42318 (#22270)
* some preliminary remand & sc model updates
* typo
* some preliminary hlr checks?
* undo seed change
* decision issue and sc updates
* attempt code climate fixes
* another code climate fix
* testing changes
* useless variable..
* fix conditional in decision issue
* fix undefined find_by method
* attempt rspec fix
* rspec fix attempt #2
* supplemental_claim_spec fix?
* remove comma
* code climate fix
* added comment for transparency on remand creation, attempt fix for remands route
* updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type
* fix lint error
* fix lint error #2
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-42458 (#22365)
* disable edit issues link for remands
* add banners explaining that remands are not editable
also makes sure that remands are not editable on the edit issues page
* TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356)
* Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter.
* Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
* SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359)
* initial verison of update script
* remanded migration file
* updated sc spec with type
* schema
* fixed a few issues in the migration
* small fix to migration file
* moved the type column check into a seperate it block
* fixed wrong column in migration file
* created a new migration for creating the view
* updated the backfill migration file
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* J hoang/appeals 44940 (#22428)
* initial
* some factory and spec updates
* change history query update and spec fixes
* code climate/lint fix
* change @claim_type identifier
* fix claim_history_event_spec.rb
* test coverage for change history with Remand claim type
* spec lint fixes
* refactor claim_type filtering to account for remand subtype
* business_line_spec fix
* decision_reviews_controller_spec update for remand claim type
* lint fixes for decision_reviews_controller_spec.rb
* comment updates in business_line.rb
* renamed mock data in change_history_reporter_spec
* trigger GA
* refactor claim type filter for less conditional handling
* business line spec fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Initial commit for the brakeman sql injection warning fixes. (#22598)
* Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825)
* added fix for failing test in decision_reviews_controller_spec (#22829)
* Al/APPEALS-45335 (#22228)
* added additional option to check box list
* fixed some tests and code clean up
* fixed more tests
* fixed jest tests
* changes per Pr feedback
* added custom error display
* fixed style for error message
---------
Co-authored-by: Sean Craig <sean.craig2@va.gov>
* adding logic to bring in issue-modification request and updating the … (#22238)
* adding logic to bring in issue-modification request and updating the csv logic
* refactor logic to get pending status and null to request addition
* pending status filter work fixing
* adding withdrawal date and adding logic to display request issue components
* getting edit of request rows and fixing cancelled data
* fixing linter and fixing the query to make test happy
* fixing specs failures
* removing byebug
* removing frontend changes, adding test, fixing the query to replace higherlevel review,adding new field in serializer
* making code climate happy by doing some minor refactor
* fixing the serializer spec failure
* After merging APPEALS-45335, filter for Requested issues were broken, so refactored it and removed the unnecessary methood that i created
* fixing code climate and spec was failing because of hard coded date
* refactor the edit of request logic to take from version, refactored business line query to remove coalesce and fix test
* fixing codeclimate, remove unnecessary field
* refactor to make first comment appear first in edit of request
* fixing linter issue, spec and refactor to fix the bug
* fixing pending status filter issue and adding test for business line
* fixing broken spec failure
* adding user facilty
* fixing the lead and lag function to prevent entry of pending status multiple times
* fixing an issue in which in progress event was not being made
* adding decision reason that was missed and fixing the event logic one more time
* fixing the multiple issue modification request after decision has been made
* refactor inprogress logic for approved data
* fixing spec failure
* fixing the first version logic to be more simpler and fixing name and adding spec
* fixing more inprogess event
* removing the disabled complexity and taking out the boolean condition to a separate method
* Al/APPEALS-45334 Individual change history table which includes Reassign Cases to CAMO events (#22483)
* added logic for claim history events table
* fixed linting errors
* fixing test failures
* added change Pr feedback
* PR feedback round 2
* changes from round 2 of PR feedback
* Added logic event data versions and tests to cover more edgecases
* changed RequestedIssueFragment
* Updated the individual claim history spec file for test failures. Updated an attribute in the IndividualClaimHistory page that was using the wrong getter. Fixed a code climate linting error.
* Removing unnecessary clear filter
* Combined some of the individual claim history tests into one test so it will run more quickly.
* fixing the withdrawal date versioning issue for different level changes
* fixing the spec failure and linter
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* TYLERB/APPEALS-57367: change-history-updates (#22479)
* Initial commit with new tests cases for issue modification requests for change history.
* Added two cte queries to the business line change history query to properly work with a lead for the issue modification requests. Added new methods into the claim history event to work with this new lead and modified the existing issue modification in progress and pending event generation methods to better reflect the state of a claim that is going through the issue modficiation process.
* Cleaned up unused code and todos.
* Updated the claim history event create_imr_in_progress_status_event? with even more logic and edge cases.
* Fixed a possible error when with a greater than operator could be used on a null value.
* Fixed a few rspec tests.
* Renamed a method and fixed a few code climate issues.
* Fixed a bug in event status generation if there is a task with versions but no versions that change status.
* Updated tests to work with new logic and remove a todo statement.
* Fixed code complexity warnings.
* Updated serializer spec to work with the bug fix.
* Adjusted the pending method to prevent possible race conditions.
* Fixed a bug where the incorrect decision event user would be shown for an issue modification request creation if the request has been decided when it should be the requestor as the event user.
* Added the correct css ids to a few IMR change history events so that the filtering would work correctly. Also added some additional sql to properly filter based on css id and station id for requestor and decider joins.
* Updated the IMR business line logic so that the decided at fields would always account for cancelled status since it uses updated at instead of decided at to determine when the IMR was closed. Fixed a bit of logic in the claim history event IMR in progress event generation to work another edge case.
* Added in previous IMR edit versions for displaying it to the user.
* Added a test for the change history service class to verify that request edit events have the correct attributes from the previous edits.
* Fixed a typo for one of the table aliases in the business line query.
* Fixed another typo where the facilities filter was using css id instead of station id from a copy/paste error.
* adding changes for previous state array and some test modification
* adding test for previous data
* Fixed some outstanding test failures.
* Fixed a linting error. Removed some duplicated code that happened when merging in the feature branch. Updated a factorybot method that was causing tests to fail.
* Fixed a few code climate warnings.
* Removed some puts statements in the individual claim history feature test.
---------
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* TYLERB/APPEALS-58656: Change History CSV and Version Parsing fix (#22874)
* Fixed a modification request claim history in progress event generation bug that could occur when 3-4 pending requests were all created at the same time and then later cancelled at the same time. Also fixed an issue count bug used when building the issue type filter due to additional duplicate rows being inserted into issue type count query due to the left join to the issue modification requests table.
* Altered the version parsing for change history to work with commas in the version strings since that was causing parsing errors. Altered the business line query to use '|||' as a delimeter instead of comma and also changed the array_agg functions to string agg to avoid the '{}' array type casting that was happening between postgres and rails. Updated tests to work with this new parsing.
* Updated vha seed data to have associations to intake data so those seeded claims can correctly generate change history.
* TYLERB/CHANGE-HISTORY-YAML-QUOTE-FIX (#22910)
* Made an update to the claim history parse versions method to work with double quotations after the array_agg to string_agg change.
* Updated the tests to work with the new string agg and version parsing method.
* Skip flakey tests
These are possibly flakey now due to the rails upgrade. We can come
back and fix these once the work has been confirmed in UAT.
* Add rubocop disables for line length
These should be removed when the skips are removed.
* Updated the report_page feature test to reduce flakyness in github actions. Also updated the DownloadHelpers module.
---------
Co-authored-by: Brandon Dorner <brandonleedorner@gmail.com>
---------
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
Co-authored-by: almorbah <149511814+almorbah@users.noreply.github.com>
Co-authored-by: Sean Craig <sean.craig2@va.gov>
Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* initial spec creation
* APPEALS-54874: Update PG and Ruby-oci8 gems (#23041)
* update minimum version in gemfile and ran bundle install (#22503)
* require ruby-oci8 in config/boot.rb to fix SIGV fault
* APPEALS-59294: Hearings seed file is creating DistributionTasks for legacy appeals (#23042)
* set parent task for legacy appeal hearing tasks to root task
* fix whitespace issue
* updates to test, copy, and function to dynamically grab count from api
* APPEALS-36292: Conditionally render banner alerts based on which environment it is deployed on (#23040)
* Conditionally render alerts based on which environment is deployed
* setting Env alert banner sitewide
* separate colors for different envs using the same alert type
* lighter reds for prodtest alert so the text is more readable
* give demo banner more contrast
* adjust specific language for demo env
* adjust logic to accept proper env var. Add style for preprod (yellow)
* isolate env alert styles
* remove duplicate 'demo' Alert
* remove development env banner to fix tests
* making conditional logic a little more bulletproof against 'production'
* update CaseWorkerIndex snapshot
* fix env var
* update snapshot from hard 'uat' setting
* conditionally render env alert on only the home page
* sticky env header statuses
* getting development alert banners to work
* target correct frontend dependency for NavigationBar changes
* connecting new frontend package with better prod exclusion logic
* make the prodtest env badge a more readable color
* cleaning up testing code
* fix linting issues
* Remove unnecessary space
* new NavigationBar update
* yarn install of new FE dependency
* remove extra package.json
* remove development env logic due to NODE_ENV bug
* fixing broken logo link padding and colors
* hardening logic to exclude other inputs
* correcting operator logic
* remove testing var
* point caseflow-frontend to master
* point at most recent caseflow-frontend master
* linting issues fix
* update Route and CaseWorker snapshot
* update snapshot for process.env.DEPLOY_ENV
---------
Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
* adds updates to the backend for dynamic appeal_count
* Master to Main documentation changes (#23034)
* Update WINDOWS_11.md replacing master with main
* References to master are changed to main where applicable
* Hotfix/appeals 37269 (#23039)
* adds script and tests for the script
* adjust the way scheduled_for is created since the previous method was removed
* refactor some of the script
* rename test file to include _spec
* Empty-Commit
---------
Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
* fixes front end breaking point and adds dynamic seed count to the backend for optional_seeds
* fixes scroll arrow issue, and updates capybara - still failing
* latest rspec updates and copy
* Revert "Release R2.6.0 FY24Q4.6.0"
* updates test from capybara to jest to test function only, turns on seeds
* Removed useless html prop
* adds last two fixes that didn't make the merge
* adds missing proptypes to ResetButton.jsx and updates quotes in affinitydays to fix linting
* adds text to the right of teh case distro dashboard link
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
Co-authored-by: almorbah <149511814+almorbah@users.noreply.github.com>
Co-authored-by: Sean Craig <sean.craig2@va.gov>
Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com>
Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: 631068 <rickybmanus@gmail.com>
* APPEALS-58868 add new optional fields to download template csv file (#22978)
* APPEALS-58868 add new optional fields to download template csv file
* APPEALS-58868 add back end logic for optional fields
* APPEALS-58868 added specs
* update specs
---------
Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com>
* Sharsha/merge main feature appeals 59217 (#23172)
* Merge `feature/APPEALS-41559` into `release/FY24Q4.6.1` (#23036)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206)
* Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue.
* Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands.
* Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns.
* Overrode the remand model association to request issues so active record joins will work correctly.
* Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing.
* Code climate fixes and test fixes.
* Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method.
* Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* JHoang/APPEALS-42318 (#22270)
* some preliminary remand & sc model updates
* typo
* some preliminary hlr checks?
* undo seed change
* decision issue and sc updates
* attempt code climate fixes
* another code climate fix
* testing changes
* useless variable..
* fix conditional in decision issue
* fix undefined find_by method
* attempt rspec fix
* rspec fix attempt #2
* supplemental_claim_spec fix?
* remove comma
* code climate fix
* added comment for transparency on remand creation, attempt fix for remands route
* updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type
* fix lint error
* fix lint error #2
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-42458 (#22365)
* disable edit issues link for remands
* add banners explaining that remands are not editable
also makes sure that remands are not editable on the edit issues page
* TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356)
* Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter.
* Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
* SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359)
* initial verison of update script
* remanded migration file
* updated sc spec with type
* schema
* fixed a few issues in the migration
* small fix to migration file
* moved the type column check into a seperate it block
* fixed wrong column in migration file
* created a new migration for creating the view
* updated the backfill migration file
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* J hoang/appeals 44940 (#22428)
* initial
* some factory and spec updates
* change history query update and spec fixes
* code climate/lint fix
* change @claim_type identifier
* fix claim_history_event_spec.rb
* test coverage for change history with Remand claim type
* spec lint fixes
* refactor claim_type filtering to account for remand subtype
* business_line_spec fix
* decision_reviews_controller_spec update for remand claim type
* lint fixes for decision_reviews_controller_spec.rb
* comment updates in business_line.rb
* renamed mock data in change_history_reporter_spec
* trigger GA
* refactor claim type filter for less conditional handling
* business line spec fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Initial commit for the brakeman sql injection warning fixes. (#22598)
* Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825)
* added fix for failing test in decision_reviews_controller_spec (#22829)
---------
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
* APPEALS-50679 | Reassign Cases To Camo Change History (#23038)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206)
* Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue.
* Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands.
* Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns.
* Overrode the remand model association to request issues so active record joins will work correctly.
* Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing.
* Code climate fixes and test fixes.
* Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method.
* Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* JHoang/APPEALS-42318 (#22270)
* some preliminary remand & sc model updates
* typo
* some preliminary hlr checks?
* undo seed change
* decision issue and sc updates
* attempt code climate fixes
* another code climate fix
* testing changes
* useless variable..
* fix conditional in decision issue
* fix undefined find_by method
* attempt rspec fix
* rspec fix attempt #2
* supplemental_claim_spec fix?
* remove comma
* code climate fix
* added comment for transparency on remand creation, attempt fix for remands route
* updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type
* fix lint error
* fix lint error #2
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-42458 (#22365)
* disable edit issues link for remands
* add banners explaining that remands are not editable
also makes sure that remands are not editable on the edit issues page
* TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356)
* Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter.
* Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
* SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359)
* initial verison of update script
* remanded migration file
* updated sc spec with type
* schema
* fixed a few issues in the migration
* small fix to migration file
* moved the type column check into a seperate it block
* fixed wrong column in migration file
* created a new migration for creating the view
* updated the backfill migration file
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* J hoang/appeals 44940 (#22428)
* initial
* some factory and spec updates
* change history query update and spec fixes
* code climate/lint fix
* change @claim_type identifier
* fix claim_history_event_spec.rb
* test coverage for change history with Remand claim type
* spec lint fixes
* refactor claim_type filtering to account for remand subtype
* business_line_spec fix
* decision_reviews_controller_spec update for remand claim type
* lint fixes for decision_reviews_controller_spec.rb
* comment updates in business_line.rb
* renamed mock data in change_history_reporter_spec
* trigger GA
* refactor claim type filter for less conditional handling
* business line spec fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Initial commit for the brakeman sql injection warning fixes. (#22598)
* Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825)
* added fix for failing test in decision_reviews_controller_spec (#22829)
* Al/APPEALS-45335 (#22228)
* added additional option to check box list
* fixed some tests and code clean up
* fixed more tests
* fixed jest tests
* changes per Pr feedback
* added custom error display
* fixed style for error message
---------
Co-authored-by: Sean Craig <sean.craig2@va.gov>
* adding logic to bring in issue-modification request and updating the … (#22238)
* adding logic to bring in issue-modification request and updating the csv logic
* refactor logic to get pending status and null to request addition
* pending status filter work fixing
* adding withdrawal date and adding logic to display request issue components
* getting edit of request rows and fixing cancelled data
* fixing linter and fixing the query to make test happy
* fixing specs failures
* removing byebug
* removing frontend changes, adding test, fixing the query to replace higherlevel review,adding new field in serializer
* making code climate happy by doing some minor refactor
* fixing the serializer spec failure
* After merging APPEALS-45335, filter for Requested issues were broken, so refactored it and removed the unnecessary methood that i created
* fixing code climate and spec was failing because of hard coded date
* refactor the edit of request logic to take from version, refactored business line query to remove coalesce and fix test
* fixing codeclimate, remove unnecessary field
* refactor to make first comment appear first in edit of request
* fixing linter issue, spec and refactor to fix the bug
* fixing pending status filter issue and adding test for business line
* fixing broken spec failure
* adding user facilty
* fixing the lead and lag function to prevent entry of pending status multiple times
* fixing an issue in which in progress event was not being made
* adding decision reason that was missed and fixing the event logic one more time
* fixing the multiple issue modification request after decision has been made
* refactor inprogress logic for approved data
* fixing spec failure
* fixing the first version logic to be more simpler and fixing name and adding spec
* fixing more inprogess event
* removing the disabled complexity and taking out the boolean condition to a separate method
* Al/APPEALS-45334 Individual change history table which includes Reassign Cases to CAMO events (#22483)
* added logic for claim history events table
* fixed linting errors
* fixing test failures
* added change Pr feedback
* PR feedback round 2
* changes from round 2 of PR feedback
* Added logic event data versions and tests to cover more edgecases
* changed RequestedIssueFragment
* Updated the individual claim history spec file for test failures. Updated an attribute in the IndividualClaimHistory page that was using the wrong getter. Fixed a code climate linting error.
* Removing unnecessary clear filter
* Combined some of the individual claim history tests into one test so it will run more quickly.
* fixing the withdrawal date versioning issue for different level changes
* fixing the spec failure and linter
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* TYLERB/APPEALS-57367: change-history-updates (#22479)
* Initial commit with new tests cases for issue modification requests for change history.
* Added two cte queries to the business line change history query to properly work with a lead for the issue modification requests. Added new methods into the claim history event to work with this new lead and modified the existing issue modification in progress and pending event generation methods to better reflect the state of a claim that is going through the issue modficiation process.
* Cleaned up unused code and todos.
* Updated the claim history event create_imr_in_progress_status_event? with even more logic and edge cases.
* Fixed a possible error when with a greater than operator could be used on a null value.
* Fixed a few rspec tests.
* Renamed a method and fixed a few code climate issues.
* Fixed a bug in event status generation if there is a task with versions but no versions that change status.
* Updated tests to work with new logic and remove a todo statement.
* Fixed code complexity warnings.
* Updated serializer spec to work with the bug fix.
* Adjusted the pending method to prevent possible race conditions.
* Fixed a bug where the incorrect decision event user would be shown for an issue modification request creation if the request has been decided when it should be the requestor as the event user.
* Added the correct css ids to a few IMR change history events so that the filtering would work correctly. Also added some additional sql to properly filter based on css id and station id for requestor and decider joins.
* Updated the IMR business line logic so that the decided at fields would always account for cancelled status since it uses updated at instead of decided at to determine when the IMR was closed. Fixed a bit of logic in the claim history event IMR in progress event generation to work another edge case.
* Added in previous IMR edit versions for displaying it to the user.
* Added a test for the change history service class to verify that request edit events have the correct attributes from the previous edits.
* Fixed a typo for one of the table aliases in the business line query.
* Fixed another typo where the facilities filter was using css id instead of station id from a copy/paste error.
* adding changes for previous state array and some test modification
* adding test for previous data
* Fixed some outstanding test failures.
* Fixed a linting error. Removed some duplicated code that happened when merging in the feature branch. Updated a factorybot method that was causing tests to fail.
* Fixed a few code climate warnings.
* Removed some puts statements in the individual claim history feature test.
---------
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* TYLERB/APPEALS-58656: Change History CSV and Version Parsing fix (#22874)
* Fixed a modification request claim history in progress event generation bug that could occur when 3-4 pending requests were all created at the same time and then later cancelled at the same time. Also fixed an issue count bug used when building the issue type filter due to additional duplicate rows being inserted into issue type count query due to the left join to the issue modification requests table.
* Altered the version parsing for change history to work with commas in the version strings since that was causing parsing errors. Altered the business line query to use '|||' as a delimeter instead of comma and also changed the array_agg functions to string agg to avoid the '{}' array type casting that was happening between postgres and rails. Updated tests to work with this new parsing.
* Updated vha seed data to have associations to intake data so those seeded claims can correctly generate change history.
* TYLERB/CHANGE-HISTORY-YAML-QUOTE-FIX (#22910)
* Made an update to the claim history parse versions method to work with double quotations after the array_agg to string_agg change.
* Updated the tests to work with the new string agg and version parsing method.
* Skip flakey tests
These are possibly flakey now due to the rails upgrade. We can come
back and fix these once the work has been confirmed in UAT.
* Add rubocop disables for line length
These should be removed when the skips are removed.
* Updated the report_page feature test to reduce flakyness in github actions. Also updated the DownloadHelpers module.
---------
Co-authored-by: Brandon Dorner <brandonleedorner@gmail.com>
---------
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
Co-authored-by: almorbah <149511814+almorbah@users.noreply.github.com>
Co-authored-by: Sean Craig <sean.craig2@va.gov>
Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* APPEALS-54874: Update PG and Ruby-oci8 gems (#23041)
* update minimum version in gemfile and ran bundle install (#22503)
* require ruby-oci8 in config/boot.rb to fix SIGV fault
* APPEALS-59294: Hearings seed file is creating DistributionTasks for legacy appeals (#23042)
* set parent task for legacy appeal hearing tasks to root task
* fix whitespace issue
* APPEALS-36292: Conditionally render banner alerts based on which environment it is deployed on (#23040)
* Conditionally render alerts based on which environment is deployed
* setting Env alert banner sitewide
* separate colors for different envs using the same alert type
* lighter reds for prodtest alert so the text is more readable
* give demo banner more contrast
* adjust specific language for demo env
* adjust logic to accept proper env var. Add style for preprod (yellow)
* isolate env alert styles
* remove duplicate 'demo' Alert
* remove development env banner to fix tests
* making conditional logic a little more bulletproof against 'production'
* update CaseWorkerIndex snapshot
* fix env var
* update snapshot from hard 'uat' setting
* conditionally render env alert on only the home page
* sticky env header statuses
* getting development alert banners to work
* target correct frontend dependency for NavigationBar changes
* connecting new frontend package with better prod exclusion logic
* make the prodtest env badge a more readable color
* cleaning up testing code
* fix linting issues
* Remove unnecessary space
* new NavigationBar update
* yarn install of new FE dependency
* remove extra package.json
* remove development env logic due to NODE_ENV bug
* fixing broken logo link padding and colors
* hardening logic to exclude other inputs
* correcting operator logic
* remove testing var
* point caseflow-frontend to master
* point at most recent caseflow-frontend master
* linting issues fix
* update Route and CaseWorker snapshot
* update snapshot for process.env.DEPLOY_ENV
---------
Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
* Master to Main documentation changes (#23034)
* Update WINDOWS_11.md replacing master with main
* References to master are changed to main where applicable
* Hotfix/appeals 37269 (#23039)
* adds script and tests for the script
* adjust the way scheduled_for is created since the previous method was removed
* refactor some of the script
* rename test file to include _spec
* Empty-Commit
---------
Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
* Revert "Release R2.6.0 FY24Q4.6.0"
* Raymond hughes patch 1 (#23124)
* Update WINDOWS_11.md replacing master with main
* References to master are changed to main where applicable
* APPEALS-59294: Hearings seed file is creating DistributionTasks for legacy appeals (#23126)
* set parent task for legacy appeal hearing tasks to root task
* fix whitespace issue
* APPEALS-36292: Conditionally render banner alerts based on which environment it is deployed on (#23127)
* Conditionally render alerts based on which environment is deployed
* setting Env alert banner sitewide
* separate colors for different envs using the same alert type
* lighter reds for prodtest alert so the text is more readable
* give demo banner more contrast
* adjust specific language for demo env
* adjust logic to accept proper env var. Add style for preprod (yellow)
* isolate env alert styles
* remove duplicate 'demo' Alert
* remove development env banner to fix tests
* making conditional logic a little more bulletproof against 'production'
* update CaseWorkerIndex snapshot
* fix env var
* update snapshot from hard 'uat' setting
* conditionally render env alert on only the home page
* sticky env header statuses
* getting development alert banners to work
* target correct frontend dependency for NavigationBar changes
* connecting new frontend package with better prod exclusion logic
* make the prodtest env badge a more readable color
* cleaning up testing code
* fix linting issues
* Remove unnecessary space
* new NavigationBar update
* yarn install of new FE dependency
* remove extra package.json
* remove development env logic due to NODE_ENV bug
* fixing broken logo link padding and colors
* hardening logic to exclude other inputs
* correcting operator logic
* remove testing var
* point caseflow-frontend to master
* point at most recent caseflow-frontend master
* linting issues fix
* update Route and CaseWorker snapshot
* update snapshot for process.env.DEPLOY_ENV
---------
Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
* APPEALS-54874: Update PG and Ruby-oci8 gems (#23125)
* update minimum version in gemfile and ran bundle install (#22503)
* require ruby-oci8 in config/boot.rb to fix SIGV fault
* hotfix/APPEALS-37269: script for stuck AssignHearingDispositionTasks
Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com>
* Merge feature/APPPEALS-41559 into main (#23132)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206)
* Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue.
* Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands.
* Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns.
* Overrode the remand model association to request issues so active record joins will work correctly.
* Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing.
* Code climate fixes and test fixes.
* Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method.
* Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* JHoang/APPEALS-42318 (#22270)
* some preliminary remand & sc model updates
* typo
* some preliminary hlr checks?
* undo seed change
* decision issue and sc updates
* attempt code climate fixes
* another code climate fix
* testing changes
* useless variable..
* fix conditional in decision issue
* fix undefined find_by method
* attempt rspec fix
* rspec fix attempt #2
* supplemental_claim_spec fix?
* remove comma
* code climate fix
* added comment for transparency on remand creation, attempt fix for remands route
* updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type
* fix lint error
* fix lint error #2
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-42458 (#22365)
* disable edit issues link for remands
* add banners explaining that remands are not editable
also makes sure that remands are not editable on the edit issues page
* TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356)
* Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter.
* Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
* SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359)
* initial verison of update script
* remanded migration file
* updated sc spec with type
* schema
* fixed a few issues in the migration
* small fix to migration file
* moved the type column check into a seperate it block
* fixed wrong column in migration file
* created a new migration for creating the view
* updated the backfill migration file
---------
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* J hoang/appeals 44940 (#22428)
* initial
* some factory and spec updates
* change history query update and spec fixes
* code climate/lint fix
* change @claim_type identifier
* fix claim_history_event_spec.rb
* test coverage for change history with Remand claim type
* spec lint fixes
* refactor claim_type filtering to account for remand subtype
* business_line_spec fix
* decision_reviews_controller_spec update for remand claim type
* lint fixes for decision_reviews_controller_spec.rb
* comment updates in business_line.rb
* renamed mock data in change_history_reporter_spec
* trigger GA
* refactor claim type filter for less conditional handling
* business line spec fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Initial commit for the brakeman sql injection warning fixes. (#22598)
* Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796)
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825)
* added fix for failing test in decision_reviews_controller_spec (#22829)
* Remove backfill supplemental claims type migration
---------
Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com>
Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
Co-authored-by: Clay Sheppard <csheepy@gmail.com>
* APPEALS-50679 | Reassign Cases to Camo Change History (#23134)
* Start feature work tracking PR with a TODO comment
* Remove TODO comment for CodeClimate
* SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220)
* added migration file for adding type column to supplemental claims table
* created stub for remand model
* added type to supplemental claim factory and new remand trait
* added remand sc's to vha seeds
* updated migration name and fixed typo
* Changed migration to inherit from Caseflow::Mirgration
* schema changes
* reverting schema
* changed the setting of the type column
* fixed schema and renamed migration file
* fixed migration and schema
* updated the remands factory and seeds
* fixed comment in schema
---------
Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* TYLERB/APPEA…- Loading branch information
32 people
authored
Oct 11, 2024
1 parent
eab3f94
commit f48939c