Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raymond/Appeals-24777 #18872

Closed
wants to merge 44 commits into from
Closed

Raymond/Appeals-24777 #18872

wants to merge 44 commits into from

Conversation

raymond-hughes
Copy link
Contributor

@raymond-hughes raymond-hughes commented Jun 27, 2023

Resolves APPEALS-24777

Description

Remediation steps to resolve POA Access when spouse is not in people table.

Problem: Attorney user has no access to POA or appeal when spouse is not in people table. This causes no POA to pull and disallows user access to appeal.

This PR addresses this issue by allowing Tier 3 to run remediation script by passing in verified claimant_participant_id and vacols_id which allows the script to create the needed person and poa records. This will allow the affected user to gain access to both the appeal and poa records.

Acceptance Criteria

  • Code compiles correctly
  • Tests are passing related to the changes

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

@codeclimate
Copy link

codeclimate bot commented Jun 27, 2023

Code Climate has analyzed commit 102d6ff and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

lib/helpers/poa_access.rb Outdated Show resolved Hide resolved
lib/helpers/poa_access.rb Outdated Show resolved Hide resolved
jcroteau

This comment was marked as outdated.

raymond-hughes and others added 8 commits June 29, 2023 14:54
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
@jcroteau

This comment was marked as outdated.

@raymond-hughes
Copy link
Contributor Author

👍 Much simpler than before 😄

You had a couple of silly CodeClimate issues failing the build, so I took the liberty of fixing them (it was just as easy to fix as it is to point them out 🤷). Hope you don't mind!

Were you going to wrap this in a Rake task as well?

Not sure if a test plan is required on this (I didn't see a subtask for that on the story). If it is, it would be good to add that under the Test Plan section here in the PR, and then I guess we'd also need to have a Jira Xray test (to comply with our contract), which could just be a copy/paste into the Jira Xray issue for that.

We can disregard test plan for now since this will be a manual remediation and doesn't require one. Same with the rake task. When we automate this we can add the rake task.

lib/helpers/poa_access.rb Outdated Show resolved Hide resolved
@jcroteau jcroteau self-requested a review July 5, 2023 18:33
jcroteau

This comment was marked as outdated.

@raymond-hughes
Copy link
Contributor Author

@jcroteau can you check the changes on how we return the new poa

lib/helpers/poa_access.rb Show resolved Hide resolved
lib/helpers/poa_access.rb Outdated Show resolved Hide resolved
@jcroteau jcroteau self-requested a review July 17, 2023 21:07
lib/helpers/poa_access.rb Outdated Show resolved Hide resolved
@andrecolinone andrecolinone deleted the Raymond/APPEALS-23501 branch November 27, 2023 14:53
@raymond-hughes raymond-hughes restored the Raymond/APPEALS-23501 branch December 29, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants