-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev support/skipped test updates #18959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process of maintaining a better testing suite we are attempting to remove all rspec tests that are skipped. This specific instance there was a skip that is no longer needed as the test does not fail. We can also remove supplemental claims being created as they aren't relevant to the test.
Code Climate has analyzed commit 8b5a3f3 and detected 0 issues on this pull request. View more on Code Climate. |
In the process of maintaining a better testing suite we are attempting to remove all rspec tests that are skipped. This specific instance there was a skip that is no longer needed as the test does not fail when ran. Upon further research it looks like the pagination has been fixed and now allows the test to work correctly.
* APPEALS-24085: removing skip * APPEALS-24150: flaky has seems to fix by itself
* refactor test to use factories instead of Model.create, fix associations * remove hardcoded CSS IDs * fix lint * tweaks to tests with failures in GHA
* removing flake test * removing commented code * removing typo and nocov * removing commented code
* modify test data and setup * fix hearings controller spec assertion * replace array sorting with match_array in dispatch task spec where applicable * added comment for why time is 11:30pm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Various changes to test files to remove
:skip
and fix flakesAcceptance Criteria