Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev support/skipped test updates #18959

Merged
merged 14 commits into from
Jul 13, 2023
Merged

Dev support/skipped test updates #18959

merged 14 commits into from
Jul 13, 2023

Conversation

craigrva
Copy link
Contributor

@craigrva craigrva commented Jul 7, 2023 •
edited
Loading

Resolves:

Description

Various changes to test files to remove :skip and fix flakes

Acceptance Criteria

  • Code compiles correctly

pamatyatake2 and others added 4 commits July 6, 2023 07:31
@pamatyatake2
removing skip and making test work (#18943)
4e1ee8f
@pamatyatake2
Fixing the flaky test (#18944)
247dc97
@brandondorner
Remove rspec skip: "flake" (#18928)
454d558 
In the process of maintaining a better testing suite we are attempting
to remove all rspec tests that are skipped.

This specific instance there was a skip that is no longer needed as
the test does not fail. We can also remove supplemental claims being
created as they aren't relevant to the test.
@TylerBroyles
TYLERB/APPEALS-24082: Remove task_filter_spec.rb flakey test tag (#18935
832f0b7 
)

* Removed flakey tag from a test in task_filter_spec and a test in hearings_controller_spec.

* Updated the appeal_series_issue_spec.

* Changed expect to properly match the subject for one test.

* Removed an expect statement that was no longer valid.
@codeclimate
Copy link

codeclimate bot commented Jul 7, 2023 •
edited
Loading

Code Climate has analyzed commit 8b5a3f3 and detected 0 issues on this pull request.

View more on Code Climate.

brandondorner and others added 10 commits July 7, 2023 10:36
@brandondorner
Remove flake test skip for case_details_spec.rb
04b61b9 
In the process of maintaining a better testing suite we are attempting
 to remove all rspec tests that are skipped.

This specific instance there was a skip that is no longer needed as
the test does not fail when ran. Upon further research it looks like
the pagination has been fixed and now allows the test to work
correctly.
@craigrva
Merge branch 'master' into dev-support/skipped-test-updates
162b74e
@pamatyatake2
Pamatya/appeals 24085 (#18966)
c99cc68 
* APPEALS-24085: removing skip

* APPEALS-24150: flaky has seems to fix by itself
@csheepy
fix certification model flaky test (#18977)
87ad812
@craigrva
Craig/appeals 24754 (#18976)
121eab9 
* refactor test to use factories instead of Model.create, fix associations

* remove hardcoded CSS IDs

* fix lint

* tweaks to tests with failures in GHA
@pamatyatake2
removing flake test (#18982)
42cabe2 
* removing flake test

* removing commented code

* removing typo and nocov

* removing commented code
@craigrva
Merge branch 'master' into dev-support/skipped-test-updates
e6bd5d0
@TylerBroyles
Removed the skip tag from docket_spec.rb spec test (#18984)
93d1fed
@craigrva
Craig/appeals 24719 (#18987)
9e6af29 
* modify test data and setup

* fix hearings controller spec assertion

* replace array sorting with match_array in dispatch task spec where applicable

* added comment for why time is 11:30pm
@brandondorner
Fix flake spec "access the appeal's case details" (#18981)
8b5a3f3
@craigrva craigrva merged commit 5a16da8 into master Jul 13, 2023
11 of 14 checks passed
@craigrva craigrva deleted the dev-support/skipped-test-updates branch July 13, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@craigrva @pamatyatake2 @brandondorner @TylerBroyles @csheepy