Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aaron/APPEALS-24678 #19001

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Aaron/APPEALS-24678 #19001

merged 8 commits into from
Jul 14, 2023

Conversation

Aaron-Willis
Copy link
Contributor

@Aaron-Willis Aaron-Willis commented Jul 14, 2023

Resolves #{APPEALS-24678}

Description

As a developer, I need to create a new Active Job that will search for unfinished Batch Processes and reprocess them.

Acceptance Criteria

  • Job needs to search for & reprocess batch processes that
  • Have a state that is NOT "COMPLETED"
  • Have a created_at time greater than BatchProcess ERROR_DELAY.
  • Inherits from CaseflowJob
  • Add created_at and updated_at columns to Batch Processes table.
  • Add updated_at column to Priority End Product Sync Queue table.
  • Add indexing to Priority End Product Sync Queue table for last_batched_at & status.
  • Add job to scheduled_jobs white list.

Testing Plan

  1. Testing Steps: https://jira.devops.va.gov/browse/APPEALS-25499.
  2. Test Execution: https://jira.devops.va.gov/browse/APPEALS-25550.
  3. XRAY: https://jira.devops.va.gov/secure/XrayExecuteTest!default.jspa?testExecIssueKey=APPEALS-25550&testIssueKey=APPEALS-25499

Backend

Database Changes

  • Added created_at and updated_at columns to Batch Processes table.
  • Added updated_at column to Priority End Product Sync Queue table.
  • Added indexing on last_batched_at & status columns within the Priority End Product Sync Queue table.

Tests

Test Coverage

  • RSpec

@Aaron-Willis Aaron-Willis marked this pull request as draft July 14, 2023 02:18
@Aaron-Willis Aaron-Willis marked this pull request as ready for review July 14, 2023 16:22
Copy link
Contributor

@jtsangVA jtsangVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtsangVA jtsangVA merged commit 2df364c into feature/APPEALS-21351 Jul 14, 2023
10 of 14 checks passed
@jtsangVA jtsangVA deleted the aaron/APPEALS-24678 branch July 14, 2023 17:10
Aaron-Willis added a commit that referenced this pull request Aug 28, 2023
* APPEALS-24678 Added created_at & updated_at columns to Batch Processes table.

* APPEALS-24678 Added updated_at column to Priority End Product Sync Queue table.

* APPEALS-24678 Added indexing on last_batched_at & status columns in Priority End Product Sync Queue table.

* APPEALS-24678 Added new scope 'needs_processing' to the Batch Process model.

* APPEALS-24678 Created BatchProcessRescueJob.

* APPEALS-24678 Created RSPEC for BatchProcessRescueJob.

* APPEALS-24678 Added indexing to Priority End Product Sync Queue table.  Updated Schema.

* APPEALS-24678 Added job to whitelist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants