-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jonathan/appeals 24987 #19003
Merged
Merged
Jonathan/appeals 24987 #19003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elilogbro
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Aaron-Willis
pushed a commit
that referenced
this pull request
Aug 28, 2023
* APPEALS-24987 Added redis-mutex to gemfile * APPEALS-24987 added RedisMutex init and lock * removed "on" lock in EPE * added comments, retrying lock using "id" * removing lock on "id" * deleting extra line * saving progress * removing debugging lines * changed mutex logic to use "with_lock" * updated mutex lock key --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.devops.va.gov/browse/APPEALS-24987
Description
Acceptance Criteria
sync!
on that EPE has to wait until the first sync is finished and the lock released before the next sync method will execute.Testing Plan