Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonathan/appeals 24987 #19003

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Jonathan/appeals 24987 #19003

merged 12 commits into from
Jul 14, 2023

Conversation

jtsangVA
Copy link
Contributor

@jtsangVA jtsangVA commented Jul 14, 2023

Resolves https://jira.devops.va.gov/browse/APPEALS-24987

Description

Acceptance Criteria

  • Code compiles correctly
  • When a EPE is being synced, all other jobs/processed that try to call sync! on that EPE has to wait until the first sync is finished and the lock released before the next sync method will execute.

Testing Plan

  1. (https://jira.devops.va.gov/browse/APPEALS-25425)

@jtsangVA jtsangVA requested a review from elilogbro July 14, 2023 19:52
Copy link
Contributor

@elilogbro elilogbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtsangVA jtsangVA merged commit 704d89f into feature/APPEALS-21351 Jul 14, 2023
11 of 14 checks passed
@jtsangVA jtsangVA deleted the Jonathan/APPEALS-24987 branch July 14, 2023 19:56
Aaron-Willis pushed a commit that referenced this pull request Aug 28, 2023
* APPEALS-24987 Added redis-mutex to gemfile

* APPEALS-24987 added RedisMutex init and lock

* removed "on" lock in EPE

* added comments, retrying lock using "id"

* removing lock on "id"

* deleting extra line

* saving progress

* removing debugging lines

* changed mutex logic to use "with_lock"

* updated mutex lock key

---------

Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants