Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto tagging feature flag #19028

Closed

Conversation

youfoundmanesh
Copy link
Contributor

@youfoundmanesh youfoundmanesh commented Jul 19, 2023

Resolves Create Auto-Tagging Feature Flag

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  • For feature branches merging into master: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

jonathanh-va and others added 30 commits April 13, 2023 17:13
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator
* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator
* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
* Created Issues Update task model and methods for formatting instructions

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* added issueUpdateTask bool check

* refactored format_instructions method to store in nested array

* refactored instruction logic and updated rendering/styling of task instructions

* updated css styling to match wireframes

* refactored special issue format and created tests

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
* Redoing branch because of previous errors.

* Added updated featureToggles.js that includes mstPactIdentification

---------

Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
…odal (#18478)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* APPEALS-17507 - Connection Pieces Working

* APPEALS-17507 - Index work for Modal

* APPEALS-17507 - Fully working Modal component

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update ApiUtil.js

* Update ApiUtil.js

* ACD: Disable Legacy Docket and Non Priority distribution (#18463)

* Update by_docket_date_distribution.rb

* Update docket_coordinator.rb

* disable Legacy

* add feature toggle indicators to stats

* Update by_docket_date_distribution.rb

* Update push_priority_appeals_to_judges_job.rb

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* removed MST (#18455)

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* jHoang/APPEALS-17523 (#18466)

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>

* revert timeouts

* HunJerBAH/APPEALS-17522: Create IssuesUpdate Task Model (#18465)

* Created Issues Update task model and methods for formatting instructions

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* added issueUpdateTask bool check

* refactored format_instructions method to store in nested array

* refactored instruction logic and updated rendering/styling of task instructions

* updated css styling to match wireframes

* refactored special issue format and created tests

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

* removed console log and copy.json value

* removed commented code

* fixed minor syntax complaints and added proptypes

* APPEALS-17507 - Updated storybook

---------

Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: Matt Roth <roth_matthew@bah.com>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* added methods that return mst/pact status

* added safety operator to contention

* refactored changes onto request issue model

* refactored hash check with has_value?

* added rspec tests

* added generator for mst + pact status contention

* added brackets

* refactored spec tests

* updated contention generation methods for special issues

* updated status return methods to conform to test cases

* updated serialize attr from snake case to camel case

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* adding feature toggle to intakes controller

* Adding checkbox to conditionally render

* attempting to add checkbox to state management

* pact box and code cleanup

* Redux state management

* Adding spec test for checkboxes

* Matching wireframe

* testing with 2 args, as 3 fails

* testing spec test idea

* re-writing spec method

* default state to false and merge fixes

* parity for redux variables for mstpact checkboxes

* feature toggle fix

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
* initial commit, checkboxes displayed

* checkbox change logic

* refactoring

* state management for burn pit and blue water

* rspec + initial blue water & burn pit state management

* finished burn pit and blue water tracking

* remove last comma

* remove unused comment

* last comma

* failing test

* removed sleep comment

* fixed burn pit and blue water states

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* adding feature toggle to intakes controller

* Adding checkbox to conditionally render

* attempting to add checkbox to state management

* pact box and code cleanup

* Redux state management

* Adding spec test for checkboxes

* Matching wireframe

* testing with 2 args, as 3 fails

* testing spec test idea

* re-writing spec method

* default state to false and merge fixes

* parity for redux variables for mstpact checkboxes

* feature toggle fix

* added mst and pact to intake payload, issues format, and serializer

* added spec tests to payload information

* created intake controller specs for mst and pact payload

---------

Co-authored-by: Ki Mau <ki.mau@va.gov>
Co-authored-by: sulak-j <justin.sulak@va.gov>
jcroteau and others added 28 commits July 10, 2023 18:28
* added nil error handling to contentions unpacking

* added next for nil payload
* update the spec with decision review from response

* fixed typo

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* AMA queue workflow feature test draft

* Newest Changes

* All tests are ready to run on a working ENV

* Final edits all tests passing

* added sleep for page load

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* appeal_spec & supplemental_claim_spec fixes

* comments

* removed binding.pry

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
…u/APPEALS-23894-close-vrr-tasks-for-vre-business-line

jcroteau/APPEALS-23894 - Close VeteranRecordRequest tasks for Veterans Readiness and Employment (VRE) business line
* ✨ Introduce method object CancelTasksAndDescendants

* ✨ Introduce rake task remediations:cancel_vrr_tasks_open_for_vre

* 🚚 Move VeteranRecordRequestsOpenForVREQuery into its own namespace

* 💡 Add to comment

* ♻️ Reference Constants::BENEFIT_TYPES instead of local constant

* ♻️ Extract factory for VRE business line

* ✏️ Fix typo

* 🔊 Log time elapsed

* ♻️ Extract constant

* ♻️ Refactor tests

* 🔊 Log total tasks for cancellation

* 🔊 Log cancelled task ids

* 🔊 Log errored cancellations

* ♻️ Extract method

* 🐛 Task #descendants already includes self

* 🐛 Only include open tasks in total

* 🐛 Only log cancellable (open) task ids

* ♻️ Extract method

* ♻️ Replace query with temp

* 🔊 Log total cancelled

* ♻️ Slide statements into block

* ♻️ Combine logging of cancellable tasks before/after into single method

* ♻️ Rearrange method definitions

* ♻️ Rename method

* 💡 Add comments

* 🔊 Append logs to stdout

* 👔 Ensure PaperTrail versions reflect appropriate whodunnit and request_id for cancelled tasks

* 🚨 Lint

* ✅ Fix broken spec

* fix potentially flaky finds

---------

Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
…port/test-updates

dev-support/test-updates
* modify formatting, add notes and foreword

* add missing parenthesis
…/APPEALS-17497

Feature/APPEALS-17497 MST/PACT Act Special Identification
@ThorntonMatthew ThorntonMatthew deleted the manesh/auto-tagging-feature-flag branch November 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.