fix audit remove script and modify GHA workflow #19092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-26130
Modifies our Github Actions config as described below
Excludes 'db/scripts' in
.codeclimate.yml
Description
Add a rescue block to script
remove_caseflow_audit_schema.rb
to prevent it from erroring and causing failures when attempting to runmake reset
after initially creating docker containers/volumesModify .github/workflow.yml caseflow_rspec_job to:
These changes will properly cache the frontend dependencies in a similar way to how we cache the backend dependencies for CI runs. It will save a significant amount of time each run and help minimize the chance that problems with external dependency repositories can cause our builds to fail.
Acceptance Criteria
make reset
(or similar commands) can be run without the databasecaseflow_certification_development
in the postgres serverTesting Plan
WARNING: This test plan will drop your database and then re-seed it
bundle exec rake db:drop
make audit-remove
and verify that you see the console output "Database caseflow_certification_development does not exist; skipping make audit-remove"make reset
make reset
runs without erroring due toActiveRecord::NoDatabaseError
Additional post-merge instructions
Manually trigger the Rspec Jest Lint workflow in Github Actions for the master branch. This should generate the master branch yarn cache
Best practices
Code Documentation Updates
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Error Handling