Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add waits to dropdown selectors #19122

Closed
wants to merge 1 commit into from
Closed

Add waits to dropdown selectors #19122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/feature/hearings/assign_hearings_table_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,10 +446,10 @@
end

context "Filter by Hearing Type column" do
it "filters are correct, and filter as expected" do

Check failure on line 449 in spec/feature/hearings/assign_hearings_table_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 9) 

Assign Hearings Table Hearing Request Type column Legacy Veterans waiting queue Filter by Hearing Type column filters are correct, and filter as expected

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
step "navigate to St. Petersburg legacy veterans tab" do
visit "hearings/schedule/assign"
click_dropdown(text: "St. Petersburg")
click_dropdown(text: "St. Petersburg", wait: 3)
click_button("Legacy Veterans Waiting", exact: true)
end

Expand Down
4 changes: 2 additions & 2 deletions spec/feature/hearings/convert_hearing_request_type/edit_hearsched_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,11 @@
change_request_type(video_appeal, "Video", "Denver regional office")
end

scenario "user can change a hearing request from Video to Central" do

Check failure on line 241 in spec/feature/hearings/convert_hearing_request_type/edit_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 4) 

Convert hearing request type for 'Edit HearSched' (Hearing Coordinator) When converting appeal with Video hearing request type user can change a hearing request from Video to Central

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
visit "queue/appeals/#{video_appeal.uuid}"

# Select the Convert hearing to Central action
click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_CENTRAL.label)
click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_CENTRAL.label, wait: 3)

# CHeck the Modal content and confirm the conversion
expect(page).to have_content("Central Office")
Expand Down Expand Up @@ -287,12 +287,12 @@
change_request_type(central_office_appeal, "Central", "Central Office")
end

scenario "user can change a hearing request from Central Office to Video" do

Check failure on line 290 in spec/feature/hearings/convert_hearing_request_type/edit_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 4) 

Convert hearing request type for 'Edit HearSched' (Hearing Coordinator) When converting appeal with Central Office hearing request type user can change a hearing request from Central Office to Video

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
# Set the converion text
convert_label = COPY::CONVERT_HEARING_TYPE_DEFAULT_REGIONAL_OFFICE_TEXT
visit "queue/appeals/#{central_office_appeal.uuid}"

click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_VIDEO.label)
click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_VIDEO.label, wait: 3)

# CHeck the Modal content and confirm the conversion
expect(page).to have_content(convert_label)
Expand Down
6 changes: 3 additions & 3 deletions spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@
scenario "can schedule a veteran without an error" do
visit "hearings/schedule/assign"

click_dropdown(text: "Denver")
click_dropdown(text: "Denver", wait: 3)
click_button("AMA Veterans Waiting", exact: true)
click_on "Bob"

Expand All @@ -689,10 +689,10 @@
expect(page).to have_content(COPY::SCHEDULE_VETERAN_SUCCESS_MESSAGE_DETAIL)
end

scenario "should not see room displayed under Available Hearing Days and Assign Hearing Tabs" do

Check failure on line 692 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 2) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature disabled with schedule direct to video/virtual feature enabled behaves like scheduling an AMA hearing and room is null should not see room displayed under Available Hearing Days and Assign Hearing Tabs

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling an AMA hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1063

Check failure on line 692 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 1) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature enabled behaves like scheduling an AMA hearing and room is null should not see room displayed under Available Hearing Days and Assign Hearing Tabs

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling an AMA hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1098
visit "hearings/schedule/assign"

click_dropdown(text: "Denver")
click_dropdown(text: "Denver", wait: 3)
click_button("AMA Veterans Waiting", exact: true)
click_on "Bob"

Expand Down Expand Up @@ -734,10 +734,10 @@
)
end

scenario "can schedule a veteran without an error" do

Check failure on line 737 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 10) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature enabled behaves like scheduling a Legacy hearing and room is null can schedule a veteran without an error

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling a Legacy hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1100

Check failure on line 737 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 9) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature disabled with schedule direct to video/virtual feature enabled behaves like scheduling a Legacy hearing and room is null can schedule a veteran without an error

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling a Legacy hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1065
visit "hearings/schedule/assign"

click_dropdown(text: "Denver")
click_dropdown(text: "Denver", wait: 3)
click_button("Legacy Veterans Waiting", exact: true)
click_on "Bob Smith"

Expand Down
Loading