-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jefftmarks/APPEALS-24999 #19154
Closed
Closed
jefftmarks/APPEALS-24999 #19154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of CreateMailTask
* Updated comment list of tasks in MailTask * APPEALS-24994 created HearingRequestMailTask * APPEALS-24992 Added verification to prevent creation of HearingRequestMailTask * APPEALS 24994 Added comments to HearingRequestMailTask * Updated comments on HearingRequestMailTask * APPEALS-24994 Completed HearingPostponementRequestMailTask * APPEALS-24995 added factory and traits for HearingPostponementRequestMailTask * APPEALS-24994 Added HPR to TASK_CLASSES_LOOKUP hash and changed 'subclasses' to 'descendants' in MailTask * APPEALS-24994 fixed typo * APPEALS-24995 replaced placeholder class with HearingPostponementRequestMailTask * APPEALS-24994 Created alias for descendant/subclass * APPEALS-24995 changed assigned_to to hearing admin * APPEALS-24994 swapped out alias and changed subclass to descendant in task action repository * APPEALS-24994 set blocking to true on HPR to force distribution task as parent * APPEALS-24994 Created unit test for HearingRequestMailTask * APPEALS-24995 refactored and fixed factory methods * APPEALS-24994 Completed unit tests for HPR mail task * APPEALS-24994 removed byebug from tasks spec and added new context to HPR mail task spec * Refactored before_validation check on HearingRequestMailTask * Rephrased unit test example names * APPEALS-24995 parent task is now root task * APPEALS-24994 Changed comment * APPEALS-24995 adjusted task tree to have child hearing postponement task * APPEALS-24994 Refactored open assign hearing task to account for tasks without hearings * APPEALS-24994 updated comments * APPEALS-24994 reverted task_spec back to original * APPEALS-24994 updated mail_task_spec subclass_routing_options to descendant_routing_options * APPEALS-24994 removed comment for validation on HearingRequestMailTask * APPEALS-24994 add question mark to method name * APPEALS-24944 swapped in Hearing#scheduled_in_past? method * APPEALS-24994 refactored spec to add context for AMA appeal * APPEALS-24995 added distribution task to task tree in factory * APPEALS-24994 condensed comments * APPEALS-24994 fixed linting * APPEALS-24995 fixed ordering of tree * APPEALS-24995 workaround found without updating task IDs --------- Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
…rks/APPEALS-24997 jefftmarks/APPEALS-24997
Code Climate has analyzed commit 63b3ba4 and detected 7 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. View more on Code Climate. |
…/APPEALS-25277 msteele/APPEALS-25277
…-of-veterans-affairs/caseflow into jefftmarks/APPEALS-24999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling