Hotfix/appeals 27980 #19173

craigrva · 2023-08-11T17:43:10Z

Resolves APPEALS-27980

Description

Add error handling to the sync_vacols_cases method so that if a case is marked for deletion but cannot be due to FK constraints, it logs the ID and moves to the next case
Add error handling to each step in the job so that an unexpected error in one step does not cause the entire job to fail
Add slack notifications to send a message with error details if an error occurs in any step or if a legacy appeal cannot be deleted as described above
Updated and added unit tests

Acceptance Criteria

Code compiles correctly
Job runs correctly

Testing Plan

Log in to rails console or allow the job to run at its scheduled time
Verify that if an error occurs in UAT, a slack notification is sent

Links to scheduled job runs in UAT:

Metabase bgs_attorneys table after the scheduled job run on 8/14:

For feature branches merging into master: Was this deployed to UAT?

Best practices

Code Documentation Updates

Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

RSpec
Jest
Other

Code Climate

Your code does not add any new code climate offenses? If so why?

No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

Are performance metrics (e.g., response time, throughput) being tracked?
Are key application components monitored (e.g., database, cache, queues)?
Is there a system in place for setting up alerts based on performance thresholds?

Logging

Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
Are logs structured (e.g., using log tags) for easier querying and analysis?
Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
Is log retention and rotation configured correctly?
Are logs being forwarded to a centralized logging system if needed?

Auditing

Are user actions being logged for audit purposes?
Are changes to critical data being tracked ?
Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

Are errors being caught and handled gracefully?
Are appropriate error messages being displayed to users?
Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
Are unhandled exceptions being caught at the application level ?

Exception Handling

Are custom exceptions defined and used where appropriate?
Is exception handling consistent throughout the codebase?
Are exceptions logged with relevant context and stack trace information?
Are exceptions being grouped and categorized for easier analysis and resolution?

codeclimate · 2023-08-11T17:49:51Z

Code Climate has analyzed commit 650e954 and detected 0 issues on this pull request.

View more on Code Climate.

…of-veterans-affairs/caseflow into combined-APPEALS-24998-24999 * 'combined-APPEALS-24998-24999' of github.com:department-of-veterans-affairs/caseflow: (34 commits) Hotfix/appeals 27980 NightlySyncsJob (#19173) add efolder url env variable to demo environmentt use env variable for efolder express url Revert "Update deprecation_warning_subscriber.rb" Update deprecation_warning_subscriber.rb put in explicit nil return statement for contention BGS call testing. 🧪 Fix test so that it will pass in non-'test' environments as well ✏️ Fix typo in test description 🥅 Add blanket rescue to DeprecationWarningSubscriber 🚨 Lint: Remove trailing whites space updated contentions response to handle blank? responses in addition to nil? added data dog logging for fetch rating profile and ratings in range Fixed spacing commented out bgs call and adding logging for production Updated for AC as of August 8 🔊 Log additional metadata to Sentry on deprecation warnings 🐛 Pre-emptive bugfix - TypeError Exception: allocator undefined for Thread::Backtrace::Location Fix typo Update deprecation_warning_subscriber_spec.rb Apply suggestions from code review ...

…19239-revert-19112-lthompson/APPEALS-26633 * laurenoelle/APPEALS-19871 initial files * Fixing error with .pick * Fixing .pick * Adding a rails initializer for monitoring deprecation warnings * Modifying jest tests * Updated language following feedback from UX team * APPEALS-17497 MST & PACT Special issues identification changes * Adding Subscriber to monitor deprecation warnings * Add spec file for deprecation warnings * APPEALS-27327: MST and PACT BGS Fix (#19116) * added grouping for feature toggles * moved special issue deserialization for ratings into contestable issue model and added datadog incrementing for reporting * added wildcard to datadog counters and removed redundant logging in bgs_service * updated data dog service logging * Delete deprecation_alerts.rb * APPEALS-26633 Added method to update meeting_type in Users Controller, and updated Organizations User model with new method to change meeting_type * APPEALS-26633 Progress on linking backend and frontend radio option changes and added modifyConferenceTypes * Apply suggestions from code review Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> * Update deprecation_warning_subscriber_spec.rb * Fix typo * APPEALS-26633 Framing for logic to link onChange function * 🐛 Pre-emptive bugfix - TypeError Exception: allocator undefined for Thread::Backtrace::Location * 🔊 Log additional metadata to Sentry on deprecation warnings * Updated for AC as of August 8 * commented out bgs call and adding logging for production * Fixed spacing * added data dog logging for fetch rating profile and ratings in range * Adding modifyConferenceType to patch to backend * updated contentions response to handle blank? responses in addition to nil? * 🚨 Lint: Remove trailing whites space c * 🥅 Add blanket rescue to DeprecationWarningSubscriber (Puts on tin foil hat) Prevent potential exceptions from SlackService from impacting user experience * ✏️ Fix typo in test description * 🧪 Fix test so that it will pass in non-'test' environments as well * put in explicit nil return statement for contention BGS call testing. * Update deprecation_warning_subscriber.rb * Revert "Update deprecation_warning_subscriber.rb" This reverts commit 50bf09f. * use env variable for efolder express url * add efolder url env variable to demo environmentt * Add meeting_type to user to capture new meeting type from frontend, debugging in byebug * Hotfix/appeals 27980 NightlySyncsJob (#19173) * add error handling to sync_vacols_cases * add test for sync_bgs_attorneys method * add slack notification on job error, add tests * codeclimate * codeclimate * Fixed bug so frontend hearings change is persisted to backend and updates user meeting type * Revert "APPEALS-17497 MST & PACT Special issues identification" * Fixed linting issues and added rspec test to check the new meeting type * Add information about patch response test * Fix code climates issues * Jest testing fixed to check for changing values by radio button selection * Pamatya/APPEALS-24131: Fix flaky/skipped tests in models/idt/token_spec.rb (#19208) * removing the xit and adding new test * Added a test for an expired key for the Idt::Token active method * APPEALS-24131: removed unused let statement * Removed the sleep statement from the test. * Included a docket_spec test fix as well. --------- Co-authored-by: = <tyler.broyles@va.gov> * Remove skipped and unneeded feature test (#19214) This will be explained more in the accompanying PR but this test has been skipped for a couple years and does not need to be in the code base anymore as it does not add any value. * APPEALS-24145 Fix test scenario "Assigning it to complete the claims establishment" (#19209) * deleted a flakey hang and added an expect for the url * Added a few more expects * small formating changes * removed no longer needed comment * removed unneccesarcy expect * Revert "laurenoelle/APPEALS-19871 initial files" * Hearing Admin selection changed to Hearings Management * Revert "lthompson/APPEALS-26633" * Revert "Revert "lthompson/APPEALS-26633"" --------- Co-authored-by: Lauren Berry <berry_lauren@bah.com> Co-authored-by: AnandEdara <131183324+AnandEdara@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov> Co-authored-by: Lauren Berry <95879805+laurenberrybah@users.noreply.github.com> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: sbashamoni <138054633+sbashamoni@users.noreply.github.com> Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Brandon Lee Dorner <brandonleedorner@gmail.com> Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>

* hid pact and mst check behind toggles * added caching to BGS contention call * updated feature toggles to include current user * adding logging for BGS contention calls * Added toggle to index.html.erb * Progress on conference types radio field * added 24 hr caching and commented out toggle for bgs call * adding conference type selection logic * APPEALS-25141: created migrations to add pexip bool column to users virtual hearings and conference links * APPEALS-25141: set default value to true on users * Work on radio field selection * Fixed errors with conference selection radio field * laurenoelle/APPEALS-19871 initial files * APPEALS-17497: MST & PACT Special issues identification * Clean up code after new import file * optimized participant contentions method to return contentions to cut down on BGS calls * added feature toggle guard clause for bgs calls for ratings * hid pact and mst check behind toggles * added caching to BGS contention call * updated feature toggles to include current user * adding logging for BGS contention calls * added 24 hr caching and commented out toggle for bgs call * Update copy file and state * hid blue water and burn pit behind mst/pact toggle * APPEALS-25112 Added styling for radio field component * Fixing error with .pick * Fixing .pick * APPEALS-25130 updated user.rb * APPEALS-25141: rolling back changes, creating new migrations, deleting the old, to meeting type varchar default on users only * added toggle for mst on special issues list * APPEALS-25141: removed version 5.2 from migrations * routed judge/attorney decisions to special issues pending on mst pact toggle * updated back button routing and special issues showing on decisions for ama appeals * hid mst pact special issues banner behind feature toggles * Account for failures in ready for resync * HunJerBAH APPEALS-26881: Reject Unknown Attributes in RatingDecisions Hash (#19072) * added handling for unknown attributes being added into rating decision hash * updated paren grouping * Update open_hearing_tasks_without_active_descendants_checker_spec.rb * Adding a rails initializer for monitoring deprecation warnings * Create jest test * allow slack notifications in uat * Test passing * Fixed syntax errors from merged code * Radio buttons fixed to only display on Hearings Admin page * Wrap li elements in ul elements * Test that radio button values change when selected * Update to testing logic with radio buttons * Add ro-colocated examples * Modifying jest tests * APPEALS-25141: refactoring migrations to include up/down methods, adding default for virt hearings and conf links * Fix ro-colocated request body * aaron/APPEALS-25478 (#19070) * APPEALS-25478 Added unit tests to BatchProcessRescueJobSpec to increase code coverage to 100%. * APPEALS-25478 Added unit tests to BatchProcessRescueJobSpec to increase code coverage to 100%. * APPEALS-25478 Added Senty Alert when a record is declared stuck. * APPEALS-25478 Refactered and Updated PriorityEndProductSyncQueueSpec file to have 100% complete code coverage. * APPEALS-25478 Refactor and Linting of batch_process_priority_ep_sync_spec.rb. * APPEALS-25478 Added to batch_process_priority_ep_sync_job_spec.rb to achieve 100% code coverage. * APPEALS-25478 Removed unintentional SImple Cov line in RSPEC. * APPEALS-25478 Updated batch_process_spec.rb to bring code coverage up to 100%. * APPEALS-25478 Updated ENV variable names to ensure uniqueness. * APPEALS-25478 Updated Error messages to include unique identifiers in batch_process_priority_ep_sync.rb. * APPEALS-25478 Added RSPEC for the CaseflowStuckRecord model. * APPEALS-25478 Updated RSPEC for PopulateEndProductSyncQueueJob so that it has 100% code coverage. * APPEALS-25478 Removed table lock from find_records method. * APPEALS-25478 Removed accidental changes to issue_spec.rb * APPEALS-25478 Updated method naming conventions to be more explicit and readable. * APPEALS-25478 Fixed failing RSPEC priority_end_product_sync_queue_spec.rb. * APPEALS-25478 Added additional tests to batch_process_priority_ep_sync_spec.rb. * APPEALS-25478 Updated Code Comments. * APPEALS-25478 Fixed Typo on code comment. * add exception handling to audit remove script * Change address_line_1 to nullable: true * Add migration * Allow audit table entry for address_line_1 to have null val * test update to yarn dependency cache keys * Take setup-node for a spin * Revert "Take setup-node for a spin" This reverts commit 337ea0a. * Add a spec * Fix whitespace * Remove flipper tables * Styling comments updated after review * unskip test (#19076) Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> * Revert 'Merge pull request #19038 from department-of-veterans-affairs/b_reed/APPEALS-25130-v3' This reverts commit ab8ce3c, reversing changes made to 6fc2c0f. * hotfix/APPEALS-27124 Updated MailRequestValidator and VbmsDistributionDestination spec for derived destinations * updated deserialize method to check on rating decision model for attributes in hash * Fixed linting issues and updated jest snapshot * Add class checks for ro-colocated? * Craig/test yarn cache (#19096) modify .github/workflows/workflow.yml * exclude db/scripts in codeclimate (#19103) * Revert "APPEALS-17497: MST & PACT Special issues identification" * Use case * Updated language following feedback from UX team * remove z-index * add z-index * Update webdrivers * Revert "Update webdrivers" This reverts commit 7cd71cd. * APPEALS-17497 MST & PACT Special issues identification changes * Adding Subscriber to monitor deprecation warnings * Add spec file for deprecation warnings * Test wait * Reverse test update * APPEALS-27327: MST and PACT BGS Fix (#19116) * added grouping for feature toggles * moved special issue deserialization for ratings into contestable issue model and added datadog incrementing for reporting * added wildcard to datadog counters and removed redundant logging in bgs_service * APPEALS-25141: updated user_spec.rb * updated data dog service logging * Delete deprecation_alerts.rb * test adding assertion (#19127) * test adding assertion * added assertion to more tests * APPEALS-26633 Added method to update meeting_type in Users Controller, and updated Organizations User model with new method to change meeting_type * Add in FT * APPEALS-26633 Progress on linking backend and frontend radio option changes and added modifyConferenceTypes * Apply suggestions from code review Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> * Update deprecation_warning_subscriber_spec.rb * add concurrency to workflow.yml (#19136) * add concurrency to workflow.yml * Fix typo * APPEALS-26633 Framing for logic to link onChange function * eli/APPEALS-27096 (#19140) * add external-db-create check to avoid error when running command * priority_ep_sync_batch_process_job * populate_end_product_sync_queue_job * priority_ep_sync_batch_process * config/environments/development ENVs * config/environment/test ENVs * scheduled_jobs => BatchProcessPriorityEpSync name change * factories/vbms_ext_claim => duplicate claim_id fix * batch_process_priority_ep_sync_job_spec * priority_end_product_sync_queue_spec * priority_ep_sync_batch_process_spec * batch_process_spec * rename batch process job spec and batch process model spec * caseflow_stuck_records_spec * populate_end_product_sync_queue_job_spec * priority_ep_sync_batch_process_job_spec * batch_process_rescue_job_spec * APPEALS-27096 Updated Schema file. * APPEALS-27096 Added Batch Process & PEPSQ ENV variables to demo. * APPEALS-27096 Added migration to add columns to caseflow_stuck_records and updated schema file. --------- Co-authored-by: Jeffrey Aaron Willis <Willis_Jeffrey@bah.com> * 🐛 Pre-emptive bugfix - TypeError Exception: allocator undefined for Thread::Backtrace::Location * 🔊 Log additional metadata to Sentry on deprecation warnings * aaron/APPEALS-27497 (#19139) * APPEALS-27947 Added Audit Removal scripts for table, function, and trigger. * APPEALS-27497 Moved Audit files to appropriate locations. Updated Makefile to reflect changes to audit file locations. * APPEALS-27497 Fixed Indentation in Makefile. * Updated for AC as of August 8 * commented out bgs call and adding logging for production * Fixed spacing * added data dog logging for fetch rating profile and ratings in range * Adding modifyConferenceType to patch to backend * updated contentions response to handle blank? responses in addition to nil? * 🚨 Lint: Remove trailing whites space c * 🥅 Add blanket rescue to DeprecationWarningSubscriber (Puts on tin foil hat) Prevent potential exceptions from SlackService from impacting user experience * ✏️ Fix typo in test description * 🧪 Fix test so that it will pass in non-'test' environments as well * put in explicit nil return statement for contention BGS call testing. * aaron/APPEALS-27780 (#19160) * APPEALS-27780 Added Priority End Product Sync Queue ID to Priority End Product Sync Queue Audit table. Updated trigger function to account for this. * APPEALS-27780 Fixed drop_priority_end_product_sync_queue_audit_trigger.rb * APPEALS-27780 Changed Job Duration Constants for Priority Ep Sync Batch Process Job and Populate End Product Sync Queue Job to minutes from hours. * 🩹 Address deprecation on affected usages of 'order' method DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s) * Eli/APPEALS-27996 (#19170) * APPEALS-27996 => updated command 'make audit' to build tables together, then functions together, then triggers together * APPEALS-27996 => removed whitespace at the top of create_caseflow_stuck_records migration file * APPEALS-27996 => deleted folder 'external_modals', added folder 'external_models' and added vbms_ext_claim.rb to it * APPEALS-27996 => added index creation to create_vbms_ext_claim_table.sql * Update deprecation_warning_subscriber.rb * Revert "Update deprecation_warning_subscriber.rb" This reverts commit 50bf09f. * use env variable for efolder express url * add efolder url env variable to demo environmentt * Add meeting_type to user to capture new meeting type from frontend, debugging in byebug * Hotfix/appeals 27980 NightlySyncsJob (#19173) * add error handling to sync_vacols_cases * add test for sync_bgs_attorneys method * add slack notification on job error, add tests * codeclimate * codeclimate * Fixed bug so frontend hearings change is persisted to backend and updates user meeting type * Revert "APPEALS-17497 MST & PACT Special issues identification" * ✨ Raise error on disallowed deprecations in dev/test envs * Fixed linting issues and added rspec test to check the new meeting type * Add information about patch response test * Fix code climates issues * ✨ Replace 'DeprecationWarningSubscriber' with 'DeprecationWarnings' handlers This will allow us to better tailor handling of deprecation warnings to each environment * 💡 Update comment * 🚨 Lint * 🔥 Remove copy-pasta from pecs * 🚨 Lint II * 🚨 Lint III * Jest testing fixed to check for changing values by radio button selection * Pamatya/APPEALS-24131: Fix flaky/skipped tests in models/idt/token_spec.rb (#19208) * removing the xit and adding new test * Added a test for an expired key for the Idt::Token active method * APPEALS-24131: removed unused let statement * Removed the sleep statement from the test. * Included a docket_spec test fix as well. --------- Co-authored-by: = <tyler.broyles@va.gov> * Remove skipped and unneeded feature test (#19214) This will be explained more in the accompanying PR but this test has been skipped for a couple years and does not need to be in the code base anymore as it does not add any value. * APPEALS-24145 Fix test scenario "Assigning it to complete the claims establishment" (#19209) * deleted a flakey hang and added an expect for the url * Added a few more expects * small formating changes * removed no longer needed comment * removed unneccesarcy expect * Revert "laurenoelle/APPEALS-19871 initial files" * Hearing Admin selection changed to Hearings Management * aaron/APPEALS-28367 (#19210) * APPEALS-28367 Added Slack Notification upon job failure on priority_ep_sync_batch_process_job.rb. Updated RSPEC. * APPEALS-28367 Added slack alerts for job failures in populate end product sync queue job. Refactored error logging and sentry alerts in populate end product sync queue job & priority ep sync batch process job. Updated RSPEC. * APPEALS-28367 Added Slack Alert to BatchProcessRescueJob upon failure to reprocess. Updated RSPEC. * APPEALS-28367 Added more negative testing for slack alerts in populate_end_product_sync_queue_job.rb. * APPEALS-28367 Refactored batch_process.rb by adding private attr_accessors for counter instance variables. * APPEALS-28367 Removed extranneous blank line from end_product_establishment factory. * APPEALS-28367 Added Slack Alert negative testing to RSPEC for batch_process_rescue_job & priority_ep_sync_batch_process_job_spec. * APPEALS-28367 Fixed linting issue for ready_to_batch scope in priority_end_product_sync_queue.rb. * APPEALS-28367 Refactored RSPEC. * APPEALS-28367 Removed Instance variables from RSPECs. Updated ENV variables in test.rb * APPEALS-28367 Updated parameter name in no-op method in batch_process.rb to resolve code climate issue. Updated RSPEC to reflect this change. * APPEALS-28367 Added Reek statements to address various code climate alerts. * APPEALS-28367 Removed SLEEP DURATION Stubbing in caseflow_stuck_records to address code climate alert. * fixing flaky test (#19231) * fixing flaky test * removing commented code * fix flakey tests in login spec (#19233) * Revert "lthompson/APPEALS-26633" * APPEALS-28989 Added Ensure block that will always update last_synced_at date/time regardless of error to ensure that SyncReviewsJob does not immediately re-queue failing end product establishment and allows for other end product estaablishments to attempt sync with BGS first. Updated RSPEC to reflect this change. * Add jest tests for `CancelIntakeModal` (#19238) * added the code needed for the test to pass (#19243) * TYLERB/APPEALS-29085: Fix flakyness in the pre_docket_spec.rb file (#19247) * Added a few more expect statements to the predocket spec to attempt to reduce flakyness. * Changed the visit case details to the reload_case_details method. * Changed all of the visit appeal uuid/external id links to the case details page to use the reload_case_detail_page to reduce flakyness. * nkirby/APPEALS-28544-v2 (#19225) * condense process_batch examples * condense create_batch examples * condense find_records_to_batch examples * tag 21351 tests * remove pr tags * Appeals 28984 - fix code climate issues for feature/APPEALS-21351-merged (#19228) * init commit - testing code climate fix * removed method from initialize and add attt_reader * revert changes of initalizer but added attr_reader :file_number * removed @file_number and changed request_issue_1 * removed veteran_file_number and just added veteran * added veteran_file_number back and kept the vet * removed veteran,left file_number, n removed id * changes to error string and removed sleep comment * fixed too many lines, double quotes, and space * long lines * remove line to long pepsq line13 had to add lambda * replacedw/ doublequotes & moved for alphabet order * removed extra line * removed sleep comment * removed sleep comment from caseflowstuckrecordspec * removed sleep comment populate_end_prod_sync_qu * removed line to long and ( ) around methods * ignore line length warn * re-enable line length * removed un used code * disabled FeatureEnvy Smell * removed comment * Disabled InstanceVariableAssumption * Update batch_process_rescue_job.rb * APPEALS-28984 - uncommented claimant_participant_id & disabled FeatureEnvy for line 185 * moved comments * add missing comma * Add three phases to sync jobs * Switch to standard error * Remove old FTs * fixed linting on sync and added test for RedisMutex lock error (#19237) * fixed linting on sync and added test for RedisMutex lock error * added epe id to display in error message * fixed linting * rubocop long line fixes * fixed new line causing test failure * fixed new lines * fixed rubocop long lines * APPEALS-28960 Updated formatting of log message and content to include "#sync!". --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: Jeffrey Aaron Willis <Willis_Jeffrey@bah.com> * Update MAC_M1.md * APPEALS-29860 Fixed Indentation linting issue on sync! method. (#19268) * Update log statement * Fix test * Better uniq * clear user session after each test (#19254) * added comment to makefile (#19305) * added comment to makefile * additional comment --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com> * Remove coverage step from workflow for now * Add back in returns --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Lauren Berry <berry_lauren@bah.com> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: jshields13 <jeremy.shields@va.gov> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: AnandEdara <131183324+AnandEdara@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> Co-authored-by: (Jeffrey) Aaron Willis <98484567+Aaron-Willis@users.noreply.github.com> Co-authored-by: Craig Reese <Reese_Craig@bah.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Clay Sheppard <csheepy@gmail.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeffrey Aaron Willis <Willis_Jeffrey@bah.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Eli Brown <elilogbro@gmail.com> Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov> Co-authored-by: Lauren Berry <95879805+laurenberrybah@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: sbashamoni <138054633+sbashamoni@users.noreply.github.com> Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Brandon Lee Dorner <brandonleedorner@gmail.com> Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com> Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: nkirby-va <131910900+nkirby-va@users.noreply.github.com> Co-authored-by: Enrilo Ugalde <71367882+Jruuuu@users.noreply.github.com> Co-authored-by: Will Love <wlove29@gmail.com> Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>

* hid pact and mst check behind toggles * added caching to BGS contention call * updated feature toggles to include current user * adding logging for BGS contention calls * Added toggle to index.html.erb * Progress on conference types radio field * added 24 hr caching and commented out toggle for bgs call * adding conference type selection logic * APPEALS-25141: created migrations to add pexip bool column to users virtual hearings and conference links * APPEALS-25141: set default value to true on users * Work on radio field selection * Fixed errors with conference selection radio field * laurenoelle/APPEALS-19871 initial files * APPEALS-17497: MST & PACT Special issues identification * Clean up code after new import file * optimized participant contentions method to return contentions to cut down on BGS calls * added feature toggle guard clause for bgs calls for ratings * hid pact and mst check behind toggles * added caching to BGS contention call * updated feature toggles to include current user * adding logging for BGS contention calls * added 24 hr caching and commented out toggle for bgs call * Update copy file and state * hid blue water and burn pit behind mst/pact toggle * APPEALS-25112 Added styling for radio field component * Fixing error with .pick * Fixing .pick * APPEALS-25130 updated user.rb * APPEALS-25141: rolling back changes, creating new migrations, deleting the old, to meeting type varchar default on users only * added toggle for mst on special issues list * APPEALS-25141: removed version 5.2 from migrations * routed judge/attorney decisions to special issues pending on mst pact toggle * updated back button routing and special issues showing on decisions for ama appeals * hid mst pact special issues banner behind feature toggles * Account for failures in ready for resync * HunJerBAH APPEALS-26881: Reject Unknown Attributes in RatingDecisions Hash (#19072) * added handling for unknown attributes being added into rating decision hash * updated paren grouping * Update open_hearing_tasks_without_active_descendants_checker_spec.rb * Adding a rails initializer for monitoring deprecation warnings * Create jest test * allow slack notifications in uat * Test passing * Fixed syntax errors from merged code * Radio buttons fixed to only display on Hearings Admin page * Wrap li elements in ul elements * Test that radio button values change when selected * Update to testing logic with radio buttons * Add ro-colocated examples * Modifying jest tests * APPEALS-25141: refactoring migrations to include up/down methods, adding default for virt hearings and conf links * Fix ro-colocated request body * aaron/APPEALS-25478 (#19070) * APPEALS-25478 Added unit tests to BatchProcessRescueJobSpec to increase code coverage to 100%. * APPEALS-25478 Added unit tests to BatchProcessRescueJobSpec to increase code coverage to 100%. * APPEALS-25478 Added Senty Alert when a record is declared stuck. * APPEALS-25478 Refactered and Updated PriorityEndProductSyncQueueSpec file to have 100% complete code coverage. * APPEALS-25478 Refactor and Linting of batch_process_priority_ep_sync_spec.rb. * APPEALS-25478 Added to batch_process_priority_ep_sync_job_spec.rb to achieve 100% code coverage. * APPEALS-25478 Removed unintentional SImple Cov line in RSPEC. * APPEALS-25478 Updated batch_process_spec.rb to bring code coverage up to 100%. * APPEALS-25478 Updated ENV variable names to ensure uniqueness. * APPEALS-25478 Updated Error messages to include unique identifiers in batch_process_priority_ep_sync.rb. * APPEALS-25478 Added RSPEC for the CaseflowStuckRecord model. * APPEALS-25478 Updated RSPEC for PopulateEndProductSyncQueueJob so that it has 100% code coverage. * APPEALS-25478 Removed table lock from find_records method. * APPEALS-25478 Removed accidental changes to issue_spec.rb * APPEALS-25478 Updated method naming conventions to be more explicit and readable. * APPEALS-25478 Fixed failing RSPEC priority_end_product_sync_queue_spec.rb. * APPEALS-25478 Added additional tests to batch_process_priority_ep_sync_spec.rb. * APPEALS-25478 Updated Code Comments. * APPEALS-25478 Fixed Typo on code comment. * add exception handling to audit remove script * Change address_line_1 to nullable: true * Add migration * Allow audit table entry for address_line_1 to have null val * test update to yarn dependency cache keys * Take setup-node for a spin * Revert "Take setup-node for a spin" This reverts commit 337ea0a. * Add a spec * Fix whitespace * Remove flipper tables * Styling comments updated after review * unskip test (#19076) Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> * Revert 'Merge pull request #19038 from department-of-veterans-affairs/b_reed/APPEALS-25130-v3' This reverts commit ab8ce3c, reversing changes made to 6fc2c0f. * hotfix/APPEALS-27124 Updated MailRequestValidator and VbmsDistributionDestination spec for derived destinations * updated deserialize method to check on rating decision model for attributes in hash * Fixed linting issues and updated jest snapshot * Add class checks for ro-colocated? * Craig/test yarn cache (#19096) modify .github/workflows/workflow.yml * exclude db/scripts in codeclimate (#19103) * Revert "APPEALS-17497: MST & PACT Special issues identification" * Use case * Updated language following feedback from UX team * remove z-index * add z-index * Update webdrivers * Revert "Update webdrivers" This reverts commit 7cd71cd. * APPEALS-17497 MST & PACT Special issues identification changes * Adding Subscriber to monitor deprecation warnings * Add spec file for deprecation warnings * Test wait * Reverse test update * APPEALS-27327: MST and PACT BGS Fix (#19116) * added grouping for feature toggles * moved special issue deserialization for ratings into contestable issue model and added datadog incrementing for reporting * added wildcard to datadog counters and removed redundant logging in bgs_service * APPEALS-25141: updated user_spec.rb * updated data dog service logging * Delete deprecation_alerts.rb * test adding assertion (#19127) * test adding assertion * added assertion to more tests * APPEALS-26633 Added method to update meeting_type in Users Controller, and updated Organizations User model with new method to change meeting_type * Add in FT * APPEALS-26633 Progress on linking backend and frontend radio option changes and added modifyConferenceTypes * Apply suggestions from code review Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> * Update deprecation_warning_subscriber_spec.rb * add concurrency to workflow.yml (#19136) * add concurrency to workflow.yml * Fix typo * APPEALS-26633 Framing for logic to link onChange function * eli/APPEALS-27096 (#19140) * add external-db-create check to avoid error when running command * priority_ep_sync_batch_process_job * populate_end_product_sync_queue_job * priority_ep_sync_batch_process * config/environments/development ENVs * config/environment/test ENVs * scheduled_jobs => BatchProcessPriorityEpSync name change * factories/vbms_ext_claim => duplicate claim_id fix * batch_process_priority_ep_sync_job_spec * priority_end_product_sync_queue_spec * priority_ep_sync_batch_process_spec * batch_process_spec * rename batch process job spec and batch process model spec * caseflow_stuck_records_spec * populate_end_product_sync_queue_job_spec * priority_ep_sync_batch_process_job_spec * batch_process_rescue_job_spec * APPEALS-27096 Updated Schema file. * APPEALS-27096 Added Batch Process & PEPSQ ENV variables to demo. * APPEALS-27096 Added migration to add columns to caseflow_stuck_records and updated schema file. --------- Co-authored-by: Jeffrey Aaron Willis <Willis_Jeffrey@bah.com> * 🐛 Pre-emptive bugfix - TypeError Exception: allocator undefined for Thread::Backtrace::Location * 🔊 Log additional metadata to Sentry on deprecation warnings * aaron/APPEALS-27497 (#19139) * APPEALS-27947 Added Audit Removal scripts for table, function, and trigger. * APPEALS-27497 Moved Audit files to appropriate locations. Updated Makefile to reflect changes to audit file locations. * APPEALS-27497 Fixed Indentation in Makefile. * Updated for AC as of August 8 * commented out bgs call and adding logging for production * Fixed spacing * added data dog logging for fetch rating profile and ratings in range * Adding modifyConferenceType to patch to backend * updated contentions response to handle blank? responses in addition to nil? * 🚨 Lint: Remove trailing whites space c * 🥅 Add blanket rescue to DeprecationWarningSubscriber (Puts on tin foil hat) Prevent potential exceptions from SlackService from impacting user experience * ✏️ Fix typo in test description * 🧪 Fix test so that it will pass in non-'test' environments as well * put in explicit nil return statement for contention BGS call testing. * aaron/APPEALS-27780 (#19160) * APPEALS-27780 Added Priority End Product Sync Queue ID to Priority End Product Sync Queue Audit table. Updated trigger function to account for this. * APPEALS-27780 Fixed drop_priority_end_product_sync_queue_audit_trigger.rb * APPEALS-27780 Changed Job Duration Constants for Priority Ep Sync Batch Process Job and Populate End Product Sync Queue Job to minutes from hours. * 🩹 Address deprecation on affected usages of 'order' method DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s) * Eli/APPEALS-27996 (#19170) * APPEALS-27996 => updated command 'make audit' to build tables together, then functions together, then triggers together * APPEALS-27996 => removed whitespace at the top of create_caseflow_stuck_records migration file * APPEALS-27996 => deleted folder 'external_modals', added folder 'external_models' and added vbms_ext_claim.rb to it * APPEALS-27996 => added index creation to create_vbms_ext_claim_table.sql * Update deprecation_warning_subscriber.rb * Revert "Update deprecation_warning_subscriber.rb" This reverts commit 50bf09f. * use env variable for efolder express url * add efolder url env variable to demo environmentt * Add meeting_type to user to capture new meeting type from frontend, debugging in byebug * Hotfix/appeals 27980 NightlySyncsJob (#19173) * add error handling to sync_vacols_cases * add test for sync_bgs_attorneys method * add slack notification on job error, add tests * codeclimate * codeclimate * Fixed bug so frontend hearings change is persisted to backend and updates user meeting type * Revert "APPEALS-17497 MST & PACT Special issues identification" * ✨ Raise error on disallowed deprecations in dev/test envs * Fixed linting issues and added rspec test to check the new meeting type * Add information about patch response test * Fix code climates issues * ✨ Replace 'DeprecationWarningSubscriber' with 'DeprecationWarnings' handlers This will allow us to better tailor handling of deprecation warnings to each environment * 💡 Update comment * 🚨 Lint * 🔥 Remove copy-pasta from pecs * 🚨 Lint II * 🚨 Lint III * Jest testing fixed to check for changing values by radio button selection * Pamatya/APPEALS-24131: Fix flaky/skipped tests in models/idt/token_spec.rb (#19208) * removing the xit and adding new test * Added a test for an expired key for the Idt::Token active method * APPEALS-24131: removed unused let statement * Removed the sleep statement from the test. * Included a docket_spec test fix as well. --------- Co-authored-by: = <tyler.broyles@va.gov> * Remove skipped and unneeded feature test (#19214) This will be explained more in the accompanying PR but this test has been skipped for a couple years and does not need to be in the code base anymore as it does not add any value. * APPEALS-24145 Fix test scenario "Assigning it to complete the claims establishment" (#19209) * deleted a flakey hang and added an expect for the url * Added a few more expects * small formating changes * removed no longer needed comment * removed unneccesarcy expect * Revert "laurenoelle/APPEALS-19871 initial files" * Hearing Admin selection changed to Hearings Management * aaron/APPEALS-28367 (#19210) * APPEALS-28367 Added Slack Notification upon job failure on priority_ep_sync_batch_process_job.rb. Updated RSPEC. * APPEALS-28367 Added slack alerts for job failures in populate end product sync queue job. Refactored error logging and sentry alerts in populate end product sync queue job & priority ep sync batch process job. Updated RSPEC. * APPEALS-28367 Added Slack Alert to BatchProcessRescueJob upon failure to reprocess. Updated RSPEC. * APPEALS-28367 Added more negative testing for slack alerts in populate_end_product_sync_queue_job.rb. * APPEALS-28367 Refactored batch_process.rb by adding private attr_accessors for counter instance variables. * APPEALS-28367 Removed extranneous blank line from end_product_establishment factory. * APPEALS-28367 Added Slack Alert negative testing to RSPEC for batch_process_rescue_job & priority_ep_sync_batch_process_job_spec. * APPEALS-28367 Fixed linting issue for ready_to_batch scope in priority_end_product_sync_queue.rb. * APPEALS-28367 Refactored RSPEC. * APPEALS-28367 Removed Instance variables from RSPECs. Updated ENV variables in test.rb * APPEALS-28367 Updated parameter name in no-op method in batch_process.rb to resolve code climate issue. Updated RSPEC to reflect this change. * APPEALS-28367 Added Reek statements to address various code climate alerts. * APPEALS-28367 Removed SLEEP DURATION Stubbing in caseflow_stuck_records to address code climate alert. * fixing flaky test (#19231) * fixing flaky test * removing commented code * fix flakey tests in login spec (#19233) * Revert "lthompson/APPEALS-26633" * APPEALS-28989 Added Ensure block that will always update last_synced_at date/time regardless of error to ensure that SyncReviewsJob does not immediately re-queue failing end product establishment and allows for other end product estaablishments to attempt sync with BGS first. Updated RSPEC to reflect this change. * Add jest tests for `CancelIntakeModal` (#19238) * added the code needed for the test to pass (#19243) * TYLERB/APPEALS-29085: Fix flakyness in the pre_docket_spec.rb file (#19247) * Added a few more expect statements to the predocket spec to attempt to reduce flakyness. * Changed the visit case details to the reload_case_details method. * Changed all of the visit appeal uuid/external id links to the case details page to use the reload_case_detail_page to reduce flakyness. * nkirby/APPEALS-28544-v2 (#19225) * condense process_batch examples * condense create_batch examples * condense find_records_to_batch examples * tag 21351 tests * remove pr tags * Appeals 28984 - fix code climate issues for feature/APPEALS-21351-merged (#19228) * init commit - testing code climate fix * removed method from initialize and add attt_reader * revert changes of initalizer but added attr_reader :file_number * removed @file_number and changed request_issue_1 * removed veteran_file_number and just added veteran * added veteran_file_number back and kept the vet * removed veteran,left file_number, n removed id * changes to error string and removed sleep comment * fixed too many lines, double quotes, and space * long lines * remove line to long pepsq line13 had to add lambda * replacedw/ doublequotes & moved for alphabet order * removed extra line * removed sleep comment * removed sleep comment from caseflowstuckrecordspec * removed sleep comment populate_end_prod_sync_qu * removed line to long and ( ) around methods * ignore line length warn * re-enable line length * removed un used code * disabled FeatureEnvy Smell * removed comment * Disabled InstanceVariableAssumption * Update batch_process_rescue_job.rb * APPEALS-28984 - uncommented claimant_participant_id & disabled FeatureEnvy for line 185 * moved comments * add missing comma * Add three phases to sync jobs * Switch to standard error * Remove old FTs * fixed linting on sync and added test for RedisMutex lock error (#19237) * fixed linting on sync and added test for RedisMutex lock error * added epe id to display in error message * fixed linting * rubocop long line fixes * fixed new line causing test failure * fixed new lines * fixed rubocop long lines * APPEALS-28960 Updated formatting of log message and content to include "#sync!". --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: Jeffrey Aaron Willis <Willis_Jeffrey@bah.com> * Update MAC_M1.md * APPEALS-29860 Fixed Indentation linting issue on sync! method. (#19268) * Update log statement * Fix test * Better uniq * clear user session after each test (#19254) * added comment to makefile (#19305) * added comment to makefile * additional comment --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com> * Remove coverage step from workflow for now * Add back in returns --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: breedbah <brandon.reed3@va.gov> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com> Co-authored-by: Lauren Berry <berry_lauren@bah.com> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: jshields13 <jeremy.shields@va.gov> Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com> Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: AnandEdara <131183324+AnandEdara@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> Co-authored-by: (Jeffrey) Aaron Willis <98484567+Aaron-Willis@users.noreply.github.com> Co-authored-by: Craig Reese <Reese_Craig@bah.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Clay Sheppard <csheepy@gmail.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jeffrey Aaron Willis <Willis_Jeffrey@bah.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Eli Brown <elilogbro@gmail.com> Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov> Co-authored-by: Lauren Berry <95879805+laurenberrybah@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: sbashamoni <138054633+sbashamoni@users.noreply.github.com> Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Brandon Lee Dorner <brandonleedorner@gmail.com> Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com> Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: nkirby-va <131910900+nkirby-va@users.noreply.github.com> Co-authored-by: Enrilo Ugalde <71367882+Jruuuu@users.noreply.github.com> Co-authored-by: Will Love <wlove29@gmail.com> Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: Jonathan Tsang <98970951+jtsangVA@users.noreply.github.com> Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>

craigrva added 3 commits August 10, 2023 15:49

add error handling to sync_vacols_cases

ce6ef76

add test for sync_bgs_attorneys method

9eb8b67

add slack notification on job error, add tests

c02dbdf

craigrva added 2 commits August 11, 2023 12:56

codeclimate

1decb15

codeclimate

650e954

craigrva requested a review from a team August 11, 2023 18:27

craigrva marked this pull request as ready for review August 11, 2023 18:28

zurbergram approved these changes Aug 14, 2023

View reviewed changes

craigrva merged commit 1bb6f8d into master Aug 15, 2023
12 of 14 checks passed

craigrva deleted the hotfix/APPEALS-27980 branch August 15, 2023 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hotfix/appeals 27980 #19173

Hotfix/appeals 27980 #19173

craigrva commented Aug 11, 2023 •

edited

Loading

codeclimate bot commented Aug 11, 2023 •

edited

Loading

Hotfix/appeals 27980 #19173

Hotfix/appeals 27980 #19173

Conversation

craigrva commented Aug 11, 2023 • edited Loading

Description

Acceptance Criteria

Testing Plan

Best practices

Code Documentation Updates

Tests

Test Coverage

Code Climate

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

Logging

Auditing

Error Handling

Exception Handling

codeclimate bot commented Aug 11, 2023 • edited Loading

craigrva commented Aug 11, 2023 •

edited

Loading

codeclimate bot commented Aug 11, 2023 •

edited

Loading