Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPEALS-28105 WEBEX Mockservice #19183

Closed
wants to merge 41 commits into from
Closed

APPEALS-28105 WEBEX Mockservice #19183

wants to merge 41 commits into from

Conversation

breedbah
Copy link
Contributor

@breedbah breedbah commented Aug 14, 2023 •
edited
Loading

Resolves Webex Mockservice APPEALS-28105

Description

  • Created a custom json-server to mock external api calls
  • Added the webex-mock.json file to the .gitignore
  • Created scripts to be ran to start server and generate test data
  • Added a file to handle generating test data
  • Upon making a request to the endpoint, it validates the request and then returns the appropriate response
  • Used the Faker library to generate random data within each object
  • Added error routes to return all error responses generated by Webex
  • Added a heartbeat request that is generated by Webex

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to https://jira.devops.va.gov/browse/APPEALS-28961 or list them below

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are unhandled exceptions being caught at the application level ?

@breedbah breedbah added Project: Virtual-Hearings Team: Oumuamua ☄️ Development Team for the Hearings ART labels Aug 14, 2023
@breedbah breedbah self-assigned this Aug 14, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023 •
edited
Loading

Code Climate has analyzed commit d8ab350 and detected 0 issues on this pull request.

View more on Code Climate.

breedbah and others added 18 commits August 16, 2023 11:19
@breedbah
APPEALS-28105 start of webex custom server
6f2e8e0
@breedbah
APPEALS-28105 Adding error messages
717b69c
@breedbah
APPEALS-28105 Completed adding errors to server
2f671d1
@breedbah
APPEALS-28105 changes to webex server
1b8b8fb
@breedbah
APPEALS-28105 Started autogenerate data functionality
05c620b
@breedbah
APPEALS-28105 Updated error handling
8cf7856
@breedbah
APPEALS-28105 Updated routes
1a55e14
@breedbah
Merge branch 'master' into b_reed/APPEALS-28105
9eb4e8c
@breedbah
APPEALS-28105 Got the api webex-generation working
e2858be
@breedbah
APPEALS-25108 removed dummy data
38ddb28
@breedbah
APPEALS-28105 return the conference link object
28b27ed
@breedbah
APPEALS-28105 Removed webex-mock.json file
fe87289
@breedbah
APPEALS-28105 added the webex-mock.json to .gitignore
38d7010
@breedbah
APPEALS-28105 update linting errors
88a7435
@breedbah
APPEALS-28105 Completed addressing linting errors
a45deef
@breedbah
APPEALS-28105 Updated the Readme.md
6802591
@breedbah
APPEALS-28105 Addressed Code Climate errors
94719fe
@breedbah
APPEALS-28105 Addressed linting errors
45e6eed
@breedbah breedbah marked this pull request as ready for review August 22, 2023 12:17
@pamatyatake2
fixing flaky test (#19231)
09bf07c 
* fixing flaky test

* removing commented code
csheepy and others added 5 commits August 23, 2023 10:29
@csheepy
fix flakey tests in login spec (#19233)
68b51af
@Aaron-Willis
APPEALS-28989 Added Ensure block that will always update last_synced_…
1a4a11a 
…at date/time regardless of error to ensure that SyncReviewsJob does not immediately re-queue failing end product establishment and allows for other end product estaablishments to attempt sync with BGS first. Updated RSPEC to reflect this change.
@brandondorner
Add jest tests for CancelIntakeModal (#19238)
1a3def3
@craigrva
Merge branch 'master' into dev-support/skipped-test-updates
340d8d5
@Aaron-Willis
Merge branch 'master' into hotfix/APPEALS-28989
9b5777a
@breedbah breedbah changed the base branch from master to feature/APPEALS-26734 August 23, 2023 16:34
breedbah and others added 14 commits August 23, 2023 13:09
@breedbah
APPEALS-28105 Updated readme.md with installation resolution
e4bb5f3
@breedbah
Merge branch 'feature/APPEALS-26734' into b_reed/APPEALS-28105
eb9b151
@seancva
added the code needed for the test to pass (#19243)
e2aa205
@TylerBroyles
TYLERB/APPEALS-29085: Fix flakyness in the pre_docket_spec.rb file (#…
5924165 
…19247)

* Added a few more expect statements to the predocket spec to attempt to reduce flakyness.

* Changed the visit case details to the reload_case_details method.

* Changed all of the visit appeal uuid/external id links to the case details page to use the reload_case_detail_page to reduce flakyness.
@craigrva
Merge pull request #19244 from department-of-veterans-affairs/dev-sup…
a2bec4a 
…port/skipped-test-updates

Dev support/skipped test updates
@Aaron-Willis
Merge branch 'master' into hotfix/APPEALS-28989
1a1e63a
@Aaron-Willis
Merge pull request #19240 from department-of-veterans-affairs/hotfix/…
db8c17f 
…APPEALS-28989

hotfix/APPEALS-28989 Frequent End Product Establishment Sync Failures
@breedbah
APPEALS-28105 Revert back to Addressed lint errors
75f563d
@breedbah
Merge branch 'b_reed/APPEALS-28105' of https://github.com/department-…
c625480 
…of-veterans-affairs/caseflow into b_reed/APPEALS-28105
@breedbah
APPEALS-28105 cleaned up and completed mock server update
99c1ee9
@breedbah
APPEALS-28105 Updated and modified meeting data
ffef0db
@breedbah
Merge branch 'master' into b_reed/APPEALS-28105
afdca04
@craigrva
Update MAC_M1.md
8125b6c
@breedbah
Merge branch 'master' into b_reed/APPEALS-28105
6828546
@ThorntonMatthew
Copy link
Contributor

Closing to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchbidwell mchbidwell Awaiting requested review from mchbidwell

@ThorntonMatthew ThorntonMatthew Awaiting requested review from ThorntonMatthew

@jimfoley25 jimfoley25 Awaiting requested review from jimfoley25

Assignees

@breedbah breedbah

Labels
Project: Virtual-Hearings Team: Oumuamua ☄️ Development Team for the Hearings ART
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@breedbah @ThorntonMatthew @pamatyatake2 @csheepy @Aaron-Willis @brandondorner @craigrva @seancva @TylerBroyles