-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msteele/APPEALS-24727 #19187
Merged
ThorntonMatthew
merged 26 commits into
feature/APPEALS-21339
from
msteele/APPEALS-24727
Aug 31, 2023
Merged
msteele/APPEALS-24727 #19187
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
821d572
APPEALS-24727 Add helper methods and pseudocode
msteele96 c17c473
APPEALS-24727 Fixed import statement
msteele96 8366a26
APPEALS-24727 Pass external id into efolderurl field for api call
msteele96 b1764f8
APPEALS-24727 Refactor debounce
msteele96 9e1b0a5
APPEALS-24727 Debounce working after useEffect
msteele96 e7fe1f0
APPEALS-24727 Removed useCallback
msteele96 081ac75
APPEALS-24727 Added loading styling and prop
msteele96 6cd7d5f
APPEALS-24727 Valid prop is passed between field and modal properly
msteele96 db73a28
APPEALS-24727 Moved loading to state value
msteele96 b039f78
APPEALS-24727 Added error messages and retry button
msteele96 0efb78d
APPEALS-24727 Removed code used for testing
msteele96 1d881f0
APPEALS-24727 Update style to fix CC issue
msteele96 e96754a
APPEALS-24727 Update Jest test
msteele96 c061300
APPEALS-24727 Linting fix
msteele96 cceef2a
Merge branch 'master' into msteele/APPEALS-24727
msteele96 0fb676d
Merge branch 'master' into msteele/APPEALS-24727
msteele96 a130646
APPEALS-24727 Update validateForm to make sure efolderurl is valid no…
msteele96 610241e
APPEALS-24727 Update wording of label and corresponding tests
msteele96 f5aaee5
APPEALS-24727 linting fix
msteele96 7878988
Merge branch 'feature/APPEALS-21339' into msteele/APPEALS-24727
msteele96 005a886
APPEALS-24727 refactor to fix bug, last jest test failing
msteele96 e4c65ec
APPEALS-24727 Fix jest test and remove console log
msteele96 529d557
APPEALS-24727 Fixed flickering
msteele96 4411683
APPEALS-24727 Added ignore line for linter
msteele96 1e03765
Merge branch 'feature/APPEALS-21339' into msteele/APPEALS-24727
msteele96 4595025
APPEALS-24727 Removed unnecessary props and comments. Refactored retr…
msteele96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever the "Retry" button is pressed, will this function's invocation allow for the parent component's state to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just updated the onclick of the retry button with the rest of the functionality from the debounce