Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding EIN to the Organization #19189

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Conversation

pamatyatake2
Copy link
Contributor

@pamatyatake2 pamatyatake2 commented Aug 14, 2023

Resolves APPEALS-17424

Description

  1. Added a new textbox 'Employee Identification number' in ClaimantForm.jsx.
  2. Added Regex to validate the format of EIN to be 9 digit i,e XX-XXXXXXX
  3. Made this text box visible only in HLR and SC form.
  4. This textbox is visible only when relationship to claimant is selected to Attorney, HealthCare provide and Other claimant and organization field is selected.

Acceptance Criteria

  • Code compiles correctly
  • Employer Identification Number is added as an optional field in the unrecognized claimant workflow for HLR/SC for the following claimants:
  • When adding an unrecognized Attorney claimant and selecting “Name not Listed” in the Claimant’s name field, and selecting the Organization radio button
  • When adding an unrecognized Healthcare Provider claimant and selecting the Organization radio button
  • When adding an unrecognized Other claimant and selecting the Organization radio button
  • Form field should have the following order:
    Organization Name
    Employer Identification Number
    Street Address 1
    Street Address 2
    Street Address 3
    City
    State
    Zip
    Country (default to 'USA')
    Claimant email
    Phone number
  • Confirm SSN/EIN validation to ensure consistent formatting

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  2. Login as 'ACBAUERVVHAH' or any user that can do intake.
  3. Click on the intake button at /decision_reviews/vha or go directly to /intake
  4. in Which form are you processing select - HLR
  5. Enter Veteran's SSN (dummy) to search for veteran by ID
  6. Fill up the request review form, but on option "Is the claimant someone other than the veteran?" select option 'yes' and select = Claimant not listed
  7. Click 'Continue to Next Step'
  8. in dropdown Relationship to the veteran -> Select 'Attorney (Previously or Currently)'
    9 . Under Claimant's Name -> Type and select 'Name not Listed' option
  9. In Is the Claimant an organization or Individual-> click on radio -> Organization
  10. Validate Presences of Employer Identification number
  11. Change -> dropdown Relationship to the veteran to select -> Health Care Provider
  12. Repeat 10 and 11.
    14 Change -> dropdown Relationship to the veteran to select -> other
  13. Repeat 10 and 11.
  14. Save the decision review.
  15. go back to /intake and repeat the process for Supplemental claim. i.e. step(5 to 16)
  • For feature branches merging into master: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER
image image
image image
image image

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • [X ] RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit be90f6a and detected 0 issues on this pull request.

View more on Code Climate.

@pamatyatake2 pamatyatake2 added Stakeholder: VHA Functionality associated with Veterans Health Administration workflows/feature requests Team: Titan A development team for the VHA business line labels Aug 15, 2023
@craigrva craigrva changed the base branch from master to feature/APPEALS-15378 August 22, 2023 16:40
client/COPY.json Outdated Show resolved Hide resolved
@craigrva craigrva marked this pull request as ready for review August 23, 2023 14:16
@craigrva craigrva merged commit 1f2f58c into feature/APPEALS-15378 Aug 25, 2023
10 of 14 checks passed
@craigrva craigrva deleted the pamatya/APPEALS-17424 branch August 25, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stakeholder: VHA Functionality associated with Veterans Health Administration workflows/feature requests Team: Titan A development team for the VHA business line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants