-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 17497 v6 ratings rework #19224
Closed
HunJerBAH
wants to merge
1,400
commits into
feature/APPEALS-17497-v6
from
feature/APPEALS-17497-v6-ratings-rework
Closed
Feature/appeals 17497 v6 ratings rework #19224
HunJerBAH
wants to merge
1,400
commits into
feature/APPEALS-17497-v6
from
feature/APPEALS-17497-v6-ratings-rework
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 0c54d50 and detected 304 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. View more on Code Climate. |
…ley-APPEALS/28736 changed address for ro vba_452
…/APPEALS-15378 Feature/appeals 15378 add EIN field to unrecognized claimant
* Update specs for queue repository * Remove created_in_vacols_date from reassign case to attorney in spec * Update queue repository subject judge_vacols_user_id * Add safe navigation * Resolved vacols id and date valid failures * Added comment on pending subject raise that is now invalid because created_in_vacols_date does not exist
* spec fix for cavc_task_queue_spec * updating to assign * added back split assignee --------- Co-authored-by: Calvin <Calvin.Costa@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* APPEALS-31791 Updated task controller and rspecs * Fix the array type error for condition --------- Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
updating how we evaluate max ticknum in folder table as somone thought it was smart to store numerical IDs in a varchar2
…19872-pull-request-template-update Revert "require null choice on database fields when making a pull request"
…APPEALS-33769 hotfix/APPEALS-33925
…/APPEALS-33575
…9956) * 🔀 APPEALS-31536 - Update 'paper_trail' gem * 🔀 APPEALS-32061 - Replace 'database_cleaner' with 'database_cleaner-active_record' * 🔀 APPEALS-29634 - Fix Deprecation Warning: update_attributes is deprecated and will be removed from Rails 6.1
Unregister `sprockets-rails` source mapping postprocessor to avoid conflicts with source map generation provided by `react_on_rails`+`webpack`. The addition of this postprocessor in `sprockets-rails` `3.4.0` was causing corruption of the `webpack-bundle.js` file, thus breaking feature specs in local development environments.
…PPEALS-32419 MattT/APPEALS-32419: Consolidate VA Notify Webhook Queries
…ping postprocessor (#20018) * Revert "Revert "🔧 Unregister `sprockets-rails` source mapping postprocessor (#19827)" (#19974)" This reverts commit a3ca452. * ⚗️ Experiment: Add newline to trigger fresh CI build * Revert "⚗️ Experiment: Add newline to trigger fresh CI build" This reverts commit 3f73142.
…31536-32061-29634-prereqs-for-rails-6-1-upgrade
…19973-revert-19956-feature/APPEALS-31536-32061-29634-prereqs-for-rails-6-1-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling