-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 17497 v6 ratings rework #19253
Merged
HunJerBAH
merged 66 commits into
release/FY24Q2.2.1
from
feature/APPEALS-17497-v6-ratings-rework
Feb 6, 2024
Merged
Feature/appeals 17497 v6 ratings rework #19253
HunJerBAH
merged 66 commits into
release/FY24Q2.2.1
from
feature/APPEALS-17497-v6-ratings-rework
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit c9c2da6 and detected 1 issue on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. View more on Code Climate. |
Aaron-Willis
approved these changes
Sep 7, 2023
Handled UI interactions for special issue page in helper methods Co-authored-by: William Medders <medders_william@bah.com>
* uncommented MST/PACT FTs in contentions call. * updated naming convention of BGS seeds service * decoupled mst and pact checkboxes on nonrating modal in intake * added guard clause to not get special issue status from BGS if flag disabled * cleaned up leftover code and linting issues. * decoupled MST/PACT checkboxes for AMA judge/attorney workflow * decoupled mst/pact checkboxes. * decoupled MST and pact in special issues list for legacy appeals * added MST/PACT status filtering on issues depending on feature toggles. * updated frontend toggles to be in camel case instead of snake case * hide MST/PACT status if feature toggle is disabled. * fixed guard clause for pact contentions and ratings * removed unecessary join clause * moved guard logic to edit mst/pact issues into user model * fixed flaky test in add_issues_spec.rb * consolidated feature toggles in attorney checkout flow spec * updated dates in tests and reverted intake helper changes * fixed bug in user model feature toggle check * fixed liniting issue
…es (#20576) * uncommented MST/PACT FTs in contentions call. * updated naming convention of BGS seeds service * decoupled mst and pact checkboxes on nonrating modal in intake * added guard clause to not get special issue status from BGS if flag disabled * cleaned up leftover code and linting issues. * decoupled MST/PACT checkboxes for AMA judge/attorney workflow * decoupled mst/pact checkboxes. * decoupled MST and pact in special issues list for legacy appeals * added MST/PACT status filtering on issues depending on feature toggles. * updated frontend toggles to be in camel case instead of snake case * hide MST/PACT status if feature toggle is disabled. * fixed guard clause for pact contentions and ratings * removed unecessary join clause * moved guard logic to edit mst/pact issues into user model * fixed flaky test in add_issues_spec.rb * consolidated feature toggles in attorney checkout flow spec * updated dates in tests and reverted intake helper changes * fixed bug in user model feature toggle check * fixed liniting issue * called legacy appeal rake task in seed file * set seed file for random veterans. * updated true value for mst/pact in auto script and raised ceiling on veterans found * moved MST/PACT seeds higher on seeds list * created unique ids for each issue on a legacy case generator
* fixed linting issue * resolved codeclimate issue in badge check on case list table * fixed code climate issue in intake checkbox permission check * fixed code climate issues on branch * fixed code climate issue on clean db method * resolve code climate issues on branch * disable check for "complex logical expression" * attempt to fix code climate issue * removed unecessary ES lint
raymond-hughes
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling