Dev support/appeals 29184 4958 #19286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a tech-debt task and should not change any functionality. https://jira.devops.va.gov/browse/APPEALS-4958 The timeline components were missing a key prop which was throwing a React error `Warning: Each child in a list should have a unique "key" prop.` In an effort to reduce errors and increase performance we have added in these component keys. Further reading on why React keys are important: https://dev.to/francodalessio/understanding-the-importance-of-the-key-prop-in-react-3ag7
This is a tech-debt task and should not change any functionality. https://jira.devops.va.gov/browse/APPEALS-29184 `AmaIssueList` was missing a key prop which was throwing a React error `Warning: Each child in a list should have a unique "key" prop.` In an effort to reduce errors and increase performance we have added in these component keys. Further reading on why React keys are important: https://dev.to/francodalessio/understanding-the-importance-of-the-key-prop-in-react-3ag7
…APPEALS-29184 APPEAL/29184 - Add key to `AmaIssueList`
…APPEALS-4958 APPEALS-4958 - Add key prop to `TaskRows` timeline components
|
Code Climate has analyzed commit 59756c0 and detected 0 issues on this pull request. View more on Code Climate. |
HunJerBAH
approved these changes
Aug 28, 2023
minhazur9
added a commit
that referenced
this pull request
Sep 26, 2023
…rans-affairs/caseflow into min/APPEALS-24730 * 'feature/APPEALS-18742' of github.com:department-of-veterans-affairs/caseflow: APPEALS-24728 Add HWR to LEGACY_MAIL_TASKS (#19433) Dev support/appeals 29184 4958 (#19286) Remove deprecated CertficationStats and DispatchStats code - APPEALS/25341 (#18999) APPEALS-15373 Appellant POA (#19128) disable checks to allow lint job to pass (#19436)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-29184; Original PR
Resolves APPEALS-4958; Original PR
Description
Add keys to
<React.Fragment>s in AmaIssueList and TaskRow componentsAcceptance Criteria
Testing Plan
Frontend
User Facing Changes
BEFORE:
AFTER:
