[DO NOT MERGE] APPEALS-28923 - Rails 6.0.Z - Raise on deprecation warnings in test env #19287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts/development.rb'
This will ensure cleaner diffs when generating config file changes during Rails upgrades.
CVE-2019-5420 was fixed in Rails 5.2.2.1, negating the need for this workaround. For further details, see https://nvd.nist.gov/vuln/detail/CVE-2019-5420.
This will ensure cleaner diffs when generating config file changes during Rails upgrades.
…nts/production.rb'
This will ensure cleaner diffs when generating config file changes during Rails upgrades.
Deprecated in Rails 5.1 (rails/rails@c6640fb)
We were already effectively assuming the default value (true) for this setting, so we can omit it.
…essage_encryption' We can migrate this setting to the default (true) after the 5.2.8.1 upgrade is verified and stable in production.
…from_forgery' Migrating to the default value (true) will require a non-trivial refactoring of several controllers
…olean_as_integer' Migrating to the default value (true) will first require a migration of old values in any sqlite3 boolean columns to the new values. Currently, 'demo_vacols' is the only sqlite3 database affected.
We can safely assume the default (true) for this setting. We may notice an initial spike in requests since all cached assets will be invalided.
…s_ids' We're not currently using 'form_with' helper anywhere, so we can safely assume the default.
…ticated_cookie_encryption' We can migrate to the default value (true) after the upgrade is verified and stable in production.
'config.serve_static_files' was replaced by 'config.public_file_server.enabled' in Rails 5.0
We're not currently using ActionCable, so changes to this file are inconsequential.
Also override Zeitwerk autoloading default to preserve classic behavior. We must eventually transition to Zeitwerk when upgrading to Rails 7.0.
`on:` is not a valid option for `before/after/around_save` callbacks and will be ignored on Rails versions before 6.0. Rails 6.0 adds strict argument checking on callbacks, which will cause an exception to be raised here when loading the application when we upgrade. See related rails PR which introduces this change: rails/rails#30919 Simply removing the invalid `on:` option will not change the existing behavior and will allow us to avoid this error upon upgrading to Rails 6.0.
…ve-record-callback-argument
…d-oracle_enhanced-adapter' oracle-enhanced v6.00 changes the default sequence start value from 10,000 to 1: Release Notes: https://github.com/rsim/oracle-enhanced/blob/v6.0.6/History.md#600--2019-08-17 Related PR: rsim/oracle-enhanced#1636 Preserve the original default value of 10,000
…ure/APPEALS-26093-APPEALS-29103-APPEALS-26725-update-to-rails-6-0
…lback-argument' into feature/APPEALS-26093-APPEALS-29103-APPEALS-26725-update-to-rails-6-0
…OT-MERGE/APPEALS-26093-APPEALS-29103-APPEALS-26725-provoke-deprecation-warnings-in-test
|
Code Climate has analyzed commit 51e9c76 and detected 9 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jcroteau
changed the title
jcroteau
deleted the
DO-NOT-MERGE/APPEALS-26093-APPEALS-29103-APPEALS-26725-provoke-rails-6-0-deprecation-warnings-in-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This is just an exploratory branch to see what deprecation warnings will emerge from the test suite on Rails 6.0.