APPEALS/29343 - Fix tabPaginationOptions PropType for QueueTable
#19319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira: https://jira.devops.va.gov/browse/APPEALS-29343 This resolves a proptype issue for QueueTable by ensuring `savedPaginationOptions` is an object and not a boolean.
brandondorner
added
Type: Tech-Improvement
Team: Saturn 🪐
|
Code Climate has analyzed commit 0aa7db8 and detected 0 issues on this pull request. View more on Code Climate. |
craigrva
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.devops.va.gov/browse/APPEALS-29343
Description
This is a tech-debt subtask for the tech debt epic https://jira.devops.va.gov/browse/APPEALS-29280.
This resolves a proptype issue for QueueTable by ensuring
savedPaginationOptionsis an object and not a boolean.More details can be found in Jira ticket.
Acceptance Criteria
To test the pagination stuff still works we can make sure the url params
(
?tab=assigned_person&page=1&sort_by=typeColumn&order=ascare as expected and refreshing the page displays the table/tabs as presented in the url params.If there is a user with more than one page of cases or if someone can provide a rails command to add cases easily we can test the pagination aspect too.