Fix for Document type filter restricting itself #19458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunJerBAH
reviewed
Sep 14, 2023
HunJerBAH
reviewed
Sep 14, 2023
HunJerBAH
reviewed
Sep 14, 2023
HunJerBAH
approved these changes
Sep 14, 2023
HunJerBAH
added a commit
that referenced
this pull request
Oct 3, 2023
* Hard coded tags that will populate the filter box. (#19178) * Hard coded tags to that will populate the filter box. Added filter functionality to issues column that works with previously mentioned hard coded data. * Restructured data and methods controlling filtering. * Reworked clear button on SearchBar * Undid hardwired data for tags. * Removed FilterDropdown dummy component. * Ryan/appeals 25271 Add filtering to document type (#19216) * Fixed issues and documents modal sharing popup. Redux store changes partly done to support document searching. * Unbroke files and put them back in working order. * Implemented working dropdown for doc filtering. * Updated and fixed clear document filter. * Added document table source. * refactored the method to populate doc filter items. * wired up doc filter to reader table display * Fixed table to properly filter data. Introduced frozenDocs to capture the props.documents for filtering dropdown. * Improved styling on documents dropdown. * slightly changed comment * adjusted CSS styling for Reader filters --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * "Results for" tab for search bar (#19192) * "Results for" tab for search bar * added search button and styling (barnett code from other branch --------- Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Ryan/appeals 15566 merge conflict (#19352) * Added Receipt Date dropdown barebones. * added dropdown with keys * Added other dateselectors. * changed dropdown props so it now displays correct. * Added logic for conditional rendering based on state. * Basic error validation. No UI update with errors. Javascript automagic conversion bug in validateDayIsToday. * Made progress on setting up redux * Added reciptDate's filter type and it now updates in redux. * Added doc filtering dates to redux store. Undid silly validation for onDate * Added state tracking to docpicker fields. * Changed RecieptDateFilter to place values in the correct place. * Removed bad validation logic. Renamed onDate handler. * Implemented reciept date filtering. * Redid validation logic. Updated to match wireframe in the dropdown for reciept filter. * Cleaned up code. * Added validation and errors for it. * Fixed display bug caused by array.push. Renamed vars to be consistent. * Updated redux variable names. * Added CSS to position the reciept dropdown. * Added css to make dropdown resemble the wireframes more closely. * backup before fixing vars * fixed logic bug in validating dates * Fixed validation and redux bugs. * Updated spelling of reciept to be consistent. * Removed useless proptype. * Fixed filtering bug. * Fixed logic bugs. * Refactored recieptFilter to compare to an enum type const. * Added comment for clarification about convertStringToDate * Fixed conditional rendering. --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> * Add Doc Type and Receipt Date to Reader "Filtering By" Message (#19362) * Clean Up Code and Prep for Changes - Create failing spec for new changes. - Mark code areas that will be changed as part of ticket work with TODO. - Clean up the indentation of the "Filtering by" message code. * Add Doc Type to Filtering * Fix Failing Doc Type Filtering Test * Add Receipt Date to Filtering By Message * Remove Unneeded Test Directives * commented out outdated feature toggle that was causing failing tests --------- Co-authored-by: Alexander Smith <alexsmith@jakeeagle.local> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Asmith/appeals 29185 Improve Reader Tests (#19379) * WIP Commit * Clean Up Code and Prep for Changes - Create failing spec for new changes. - Mark code areas that will be changed as part of ticket work with TODO. - Clean up the indentation of the "Filtering by" message code. * Add Doc Type to Filtering * Fix Failing Doc Type Filtering Test * Add Receipt Date to Filtering By Message * Remove Unneeded Test Directives * Refactor and Improve Reader Filter Message Specs - Improve organization of specs and group by feature tested. - Add new tests for searching filters. --------- Co-authored-by: Alexander Smith <alexsmith@jakeeagle.local> * added closing of reciept filter modal after a successful filter. (#19396) * Remove Old "Filtering By" Messages (#19399) Remove unneeded old in-table "Filtering by" messages as these are now handled by a global "Filtering by" message. Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Isaiah bar/appeals 30052 (#19457) * test push * test push * delete test * fix spelling error * Fix for Document type filter restricting itself (#19458) * Added redux store for testing the frozen items in redux * Bug fixed. Refactor badly needed. * Refactored and removed frozenDocs. * added analytics and removed console.log * Changed default state of docTypes to '' * Removed unused component. --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Refactored to fix invalid year bug. (#19444) * Refactored to fix invalid year bug. * Removed line of logic causing another bug. * Fix for state race condition. * Fixed improper conditional rendering of validation message on the from field. Fixed onDate validation. * Fixed onDate bug * Fixed before and to filter bug. * Unsaved file double check. --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * remove search bar from Document Type dropdown (#19459) * remove search bar from Document Type dropdown * remove search button from searchbar * remove the little x * added styling to top search bar --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Removed labels in recieptfilter from to, from, on. (#19467) Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Added padding to reciept filter (#19468) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * revert code changes for search bar button (#19482) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Move ReceiptDate Filter Error Messages (#19474) * Move ReceiptDate Filter Error Messages Move error messages below the label that has an error. * Refactor ReceiptDate Error Messages - Use built-in errorMessage prop for DateFilter components. - Fix some styling issues in the ReceiptDate dropdown, esp. when error messages are displayed. --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Ryan/appeals 29955 && Ryan/appeals 29962 (#19484) * Added default search text values for document and tag search. * manually resolved merge conflict --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Ryan/appeals 29957 (#19503) * Half done dropdown from react-select * translate discovery * Added functionality to react-select component * fixed text alignment for react-dropdown. * Added a ReactSelectDropdown component and added it to the DocumentsTable.jsx file. --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * APPEALS-30837: Reader Table Improvements Feature Toggle (#19500) * added feature toggle to props * added conditinoal rendering to new filters * added feature toggles to search bars * added feature toggle to new documents table filter * added props validation to doc tag picker * added feature toggle to reader tests * Ryan appeals/29958 (#19511) * Move ReceiptDate Filter Error Messages Move error messages below the label that has an error. * Refactor ReceiptDate Error Messages - Use built-in errorMessage prop for DateFilter components. - Fix some styling issues in the ReceiptDate dropdown, esp. when error messages are displayed. * Added error bar to On date in recieptfilter. --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Fix Table Header Styling (#19489) - Move filter icon next to header name. - Fix alignment of th labels. Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Search Reader Tags Starting at 2 Characters (#19502) In the reader doc table, begin searching doc tags once the user enters 2 or more characters in the tag search. Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Clear ReceiptDate Filters when Clear All Filters is Clicked (#19521) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * remove params from receipt date filter (#19526) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Hun jer bah/appeals 15566 lint (#19543) * resolved linting issues * resolved linting issues * fixed linting issues * resolved linting issues in pdf list view * updated to switch statement for logic from if blocks * Hun jer bah/appeals 15566 rspecs (#19560) * Make Misc. Fixes for Linting/Spec Issues - Update reader specs to handle recent UI changes. - Fix a few misc. React bugs that were causing console warnings re. setting state during render. * updated tests on reader spec * Fix Failing Reader Tests * moved reader search improvements spec into own file. * Fix Reader Specs * reverted to previous changes in reader_spec.rb * resized window to prevent flaky test * updated naming convention for test * commented out outdated tests * resolved flaky test * fixed flaky test * commented out failing tests * resolved date math with flaky test --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * removed duplicate tests for reader search improvements * fixed spelling errors for reciept vs receipt (#19580) * fixed spelling errors for reciept vs receipt * removed space to run specs * removed space to re-run test suite * added space back in to run test suite * resolved flaky test date math * added space to run test suite * removed space to run test suite --------- Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: Alex Smith <alexmcraysmith@gmail.com> Co-authored-by: Alexander Smith <alexsmith@jakeeagle.local> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Document type filter restricting itself
Description
Previously the Document type filter would break for users in the reader portion of Caseflow. These changes move the list of documents from the frozenDocTypes state to the redux store so that it may persist across pages.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
BEFORE|AFTER
|