-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MattT/APPEALS-30222 #19475
Merged
Merged
MattT/APPEALS-30222 #19475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThorntonMatthew
changed the base branch from
feature/APPEALS-26734
to
master
September 23, 2023 01:50
Code Climate has analyzed commit 499a808 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
ThorntonMatthew
changed the base branch from
master
to
feature/APPEALS-26734
September 23, 2023 21:35
mchbidwell
approved these changes
Sep 26, 2023
mchbidwell
approved these changes
Sep 26, 2023
ThorntonMatthew
merged commit Sep 26, 2023
9fffffe
into
feature/APPEALS-26734
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-30222
Description
Creates a static Webex Meetings API service integration class for approximating the live API we will interact with in higher environments.
Acceptance Criteria
ApplicationController.dependencies_faked?
istrue
WebexClient
toFakes::WebexService
ApplicationController.dependencies_faked?
isfalse
WebexClient
toExternalApi::WebexService
Fakes::WebexService
class is created inlib/fakes
create_conference
instance methoddelete_conference
instance methoddelete_conference(conference_id: )
Testing Plan
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling