-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck Jobs Reporter and Fixes and S3 Buckets updates #19535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit c8539de and detected 0 issues on this pull request. View more on Code Climate. |
Co-authored-by: Griffin Dooley <gcd253@users.noreply.github.com>
Co-authored-by: Griffin Dooley <gcd253@users.noreply.github.com>
AdamShawBAH
changed the title
UAT Stuck Jobs Reporter and Fixes and S3 Buckets updates
Stuck Jobs Reporter and Fixes and S3 Buckets updates
Sep 22, 2023
raymond-hughes
approved these changes
Sep 27, 2023
Co-authored-by: Griffin Dooley <gcd253@users.noreply.github.com>
Co-authored-by: Griffin Dooley <gcd253@users.noreply.github.com>
ThorntonMatthew
deleted the
Shaw/s3-stuck-jobs-fixes-report-service-prod
branch
September 26, 2024 16:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Deploy and Validate in production for Claimdatedt
Resolves Deploy and Validate in production - DTA SC Creation Failed
Resolves Validate in production for claim not established
Resolves Deploy and Validate in production for BGS::ShareError
Resolves Validate in production - Can't create a SC DTA for Appeal
Resolves Migrate S3 updates to Prod and smoke test
Description
Introduces five stuck job remediations and a service to log the changes they make. Descriptions of the stuck jobs listed below
Introduces a job to handle the ClaimDateDt error:
uploaded_to_vbms_at
andprocessed_at
are populated. The error will be cleared only if both columns have values presentIntroduces a job to handle the DTA SC creation failed error:
decision_review_remanded_id
field that matches the ID of the HigherLevelReviewdecision_review_remanded_type
equal to"HigherLevelReview"
clear_error!
on the HigherLevelReviewIntroduces a job to handle the Claim not established error:
established_at
field and the presence of any of theEPECODES
show in the arrayIntroduces a job to handle the BGS::ShareError error:
The BGS::ShareError occurs on three different classes:
There is a failure in pulling information from VBMS which creates the initial error. When Caseflow reruns the fetch and eventually succeeds an EndProductEstablishment with an established_at column with the date/time of establishment recorded will prove the success of this record. The errors on these three records however will remain.
Completing a data clean-up for this error is quite simple
Introduces a job to handle the Can't create a SC DTA for appeal error:
This Job clears the
Can't create a SC DTA for appeal
error that is on the Decision Document.The process follow is as follows.
The logic checks that the payee_code on the claimant. related to the decision document is nil. If it is, it then checks the claimant Type. if the type is "veteran" we set the payee_code to 00. If the claimant type is DependentClaimant, we set the payee_code to 10.
We then clear error on the decision document object.
Logs are also written to S3.
Introduces a service to handle logging for the remediations above:
Augments the naming convention for all S3 Buckets in Caseflow
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling