Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev support/appeals 29347 30972 #19568

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Conversation

craigrva
Copy link
Contributor

Resolves APPEALS-29347; original PR
Resolves APPEALS-30972; original PR

Description

  • Removed the .isRequired for the propTypes for rowObjects in QueueTable. It was causing a warning to appear in the console, because some of the keys were undefined
  • Modify POA components PropTypes to accept number or string

Acceptance Criteria

  • Code compiles correctly

seancva and others added 5 commits September 8, 2023 15:05
For https://jira.devops.va.gov/browse/APPEALS-30972

The POA refresh button components are expecting the appealId to come
through as type string but it only comes through as type number.
…APPEALS-30972

APPEALS-30972 | Change appealId PropType to number for POA button
…PPEALS-29347

APPEALS-29347 The prop `rowObjects` is marked as required in `Row`
@codeclimate
Copy link

codeclimate bot commented Sep 25, 2023

Code Climate has analyzed commit 573b3bb and detected 0 issues on this pull request.

View more on Code Climate.

@craigrva craigrva merged commit 2979b7a into master Sep 28, 2023
15 checks passed
@craigrva craigrva deleted the dev-support/APPEALS-29347-30972 branch September 28, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants