-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uat/fy24 q1.1.1 #19694
Closed
Closed
Uat/fy24 q1.1.1 #19694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts/development.rb'
This will ensure cleaner diffs when generating config file changes during Rails upgrades.
CVE-2019-5420 was fixed in Rails 5.2.2.1, negating the need for this workaround. For further details, see https://nvd.nist.gov/vuln/detail/CVE-2019-5420.
This will ensure cleaner diffs when generating config file changes during Rails upgrades.
…nts/production.rb'
This will ensure cleaner diffs when generating config file changes during Rails upgrades.
Deprecated in Rails 5.1 (rails/rails@c6640fb)
We were already effectively assuming the default value (true) for this setting, so we can omit it.
…essage_encryption' We can migrate this setting to the default (true) after the 5.2.8.1 upgrade is verified and stable in production.
…from_forgery' Migrating to the default value (true) will require a non-trivial refactoring of several controllers
…olean_as_integer' Migrating to the default value (true) will first require a migration of old values in any sqlite3 boolean columns to the new values. Currently, 'demo_vacols' is the only sqlite3 database affected.
We can safely assume the default (true) for this setting. We may notice an initial spike in requests since all cached assets will be invalided.
…s_ids' We're not currently using 'form_with' helper anywhere, so we can safely assume the default.
…ticated_cookie_encryption' We can migrate to the default value (true) after the upgrade is verified and stable in production.
'config.serve_static_files' was replaced by 'config.public_file_server.enabled' in Rails 5.0
This setting was accidentally removed while reconciling 'bin/rais app:update' changes.
Merging recent changes from master branch in to APPEALS-27848 branch
Adding fixed deprecation to the array RAILS_5_2_FIXED_DEPRECATION_WARNING_REGEXES
…ger-based-primary-keys
…u/APPEALS-26093-update-to-rails-5-2-Z Jcroteau/appeals 26093 update to rails 5 2 z
…APPEALS-27848 Aedara/appeals 27848
…u/APPEALS-29460-workaround-for-trigger-based-primary-keys Jcroteau/appeals 29460 workaround for trigger based primary keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling