Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/APPEALS-45186 #21494

Merged
6 commits merged into from
May 16, 2024
Merged

Hotfix/APPEALS-45186 #21494

6 commits merged into from
May 16, 2024

Conversation

drew-hadley
Copy link
Contributor

@drew-hadley drew-hadley commented Apr 29, 2024

Resolves APPEALS-45186
ClaimLabelChange Update script for Tier 3 SOP-Claim Label Code Change

Description

Currently the SOP-Claim Label Code Change is failing due to a method being defined outside of the class used in the claim-label-update script. This code change moves said method into the ClaimLabelChange helper class and fixes the script used within the above SOP.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below

UAT Test Plan

Enter UAT terminal and run the below scripts. I've already found a valid EPE to run the claim label change on so the output shoud return successful.

sudo su - 
source /opt/caseflow-certification/caseflow-certification_env.sh 
cd /opt/caseflow-certification/src/lib/helpers/scripts 

sh claim-label-update.sh 1044273 030HLRNR 030HLRR

Prodtest Test Plan

Similar to UAT, I have a valid epe selected to run the script against. This would specifically resolve prodtest portion of APPEALS-45163

sudo su - 
source /opt/caseflow-certification/caseflow-certification_env.sh 
cd /opt/caseflow-certification/src/lib/helpers/scripts 

sh claim-label-update.sh 106816945 030BGRNR 030BGR
  • For feature branches merging into master: Was this deployed to UAT?

---|---

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Copy link

codeclimate bot commented Apr 29, 2024

Code Climate has analyzed commit 080bb01 and detected 0 issues on this pull request.

View more on Code Climate.

@drew-hadley drew-hadley changed the title moved method definition validate_claim_code into ClaimLabelChange class Hotfix/APEALS-45186 Apr 29, 2024
@drew-hadley drew-hadley changed the title Hotfix/APEALS-45186 Hotfix/APPEALS-45186 Apr 29, 2024
@mikefinneran mikefinneran closed this pull request by merging all changes into master in ee2d6d2 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants