-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mbeard/appeals 43118.4 #21529
Closed
Closed
Mbeard/appeals 43118.4 #21529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests
* Added Download Ineligible Judge List * APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369) * Updated query to include css_id and updated id fetch * Updates button styling, fixed csv to have all values but judge name * Updated id to sattyid values, and added name data to column * fixed linting error * Updated logic to account for inactive users in both caseflow and vacols * Updated button component and cleaned up code * Updated handling of ids in situation where sattyid is unavailable in record * Updated to have individual columns for caseflow id and satty id --------- Co-authored-by: 631068 <rickybmanus@gmail.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
* APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369) * init commit * fixes linting issues * capybara test init * capybara test complete steps * updates copy file with missing copy * removes random changed files from push priority * using different test methods find_field and find_button * commented out test for now * added the raven command back * uncommented the frozen string literal comment to address the linting offense --------- Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: 631966 <amy.detwiler@va.gov>
…-of-veterans-affairs/caseflow into mbeard/APPEALS-43118.4
…t-of-veterans-affairs/caseflow into mbeard/APPEALS-43118.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling