department-of-veterans-affairs · mikefinneran · May 16, 2024 · Mar 1, 2024 · Mar 6, 2024 · Mar 18, 2024
diff --git a/Gemfile b/Gemfile
@@ -75,8 +75,6 @@ gem "statsd-instrument"
 gem "stringex", require: false
 # catch problematic migrations at development/test time
 gem "strong_migrations"
-# execjs runtime
-gem "therubyracer", platforms: :ruby
 # print trees
 gem "tty-tree"
 gem "tzinfo", "1.2.10"
@@ -106,7 +104,6 @@ group :test, :development, :demo do
   gem "guard-rspec"
   gem "immigrant"
   # Linters
-  gem "jshint", platforms: :ruby
   gem "pluck_to_hash"
   gem "pry", "~> 0.13.0"
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -367,10 +367,6 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    jshint (1.5.0)
-      execjs (>= 1.4.0)
-      multi_json (~> 1.0)
-      therubyracer (~> 0.12.1)
     json (2.3.0)
     json_schemer (0.2.16)
       ecma-re-validator (~> 0.2)
@@ -397,7 +393,6 @@ GEM
       kramdown (~> 2.0)
     launchy (2.4.3)
       addressable (~> 2.3)
-    libv8 (3.16.14.19)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
@@ -431,7 +426,6 @@ GEM
     momentjs-rails (2.29.4.1)
       railties (>= 3.1)
     msgpack (1.4.2)
-    multi_json (1.12.2)
     multipart-post (2.1.1)
     multiverse (0.2.2)
       activerecord (>= 4.2)
@@ -564,7 +558,6 @@ GEM
       redis-store (>= 1.2, < 2)
     redis-store (1.4.1)
       redis (>= 2.2, < 5)
-    ref (2.0.0)
     regexp_parser (1.6.0)
     request_store (1.4.1)
       rack (>= 1.4)
@@ -696,9 +689,6 @@ GEM
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
     test-prof (0.10.1)
-    therubyracer (0.12.3)
-      libv8 (~> 3.16.14.15)
-      ref
     thor (0.20.3)
     thread_safe (0.3.6)
     tilt (2.0.8)
@@ -792,7 +782,6 @@ DEPENDENCIES
   holidays (~> 6.4)
   icalendar
   immigrant
-  jshint
   json_schemer (~> 0.2.16)
   kaminari
   knapsack_pro (~> 3.8)
@@ -849,7 +838,6 @@ DEPENDENCIES
   stringex
   strong_migrations
   test-prof
-  therubyracer
   timecop
   tty-tree
   tzinfo (= 1.2.10)

diff --git a/app/jobs/caseflow_job.rb b/app/jobs/caseflow_job.rb
@@ -34,12 +34,8 @@ def metrics_service_report_time_segment(segment:, start_time:)
     )
   end
 
-  def slack_url
-    ENV["SLACK_DISPATCH_ALERT_URL"]
-  end
-
   def slack_service
-    @slack_service ||= SlackService.new(url: slack_url)
+    @slack_service ||= SlackService.new
   end
 
   def log_error(error, extra: {})

diff --git a/app/jobs/out_of_service_reminder_job.rb b/app/jobs/out_of_service_reminder_job.rb
@@ -13,7 +13,7 @@ def perform
       out_of_service_apps.push(app.humanize) if Rails.cache.read(app + "_out_of_service")
     end
 
-    SlackService.new(url: url).send_notification(message(out_of_service_apps)) unless out_of_service_apps.empty?
+    SlackService.new.send_notification(message(out_of_service_apps)) unless out_of_service_apps.empty?
   end
 
   def message(apps)
@@ -23,8 +23,4 @@ def message(apps)
       "Reminder: #{apps.to_sentence} are out of service."
     end
   end
-
-  def url
-    ENV["SLACK_DISPATCH_ALERT_URL"]
-  end
 end
diff --git a/app/jobs/prepare_establish_claim_tasks_job.rb b/app/jobs/prepare_establish_claim_tasks_job.rb
@@ -28,10 +28,6 @@ def log_info(count)
     msg = "PrepareEstablishClaimTasksJob successfully ran: #{count[:success]} tasks " \
           "prepared and #{count[:fail]} tasks failed"
     Rails.logger.info msg
-    SlackService.new(url: url).send_notification(msg)
-  end
-
-  def url
-    ENV["SLACK_DISPATCH_ALERT_URL"]
+    SlackService.new.send_notification(msg)
   end
 end
diff --git a/app/jobs/quarterly_notifications_job.rb b/app/jobs/quarterly_notifications_job.rb
@@ -16,9 +16,8 @@ class QuarterlyNotificationsJob < CaseflowJob
   def perform # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/PerceivedComplexity
     ensure_current_user_is_set
 
-    AppealState.where.not(
-      decision_mailed: true, appeal_cancelled: true
-    ).find_in_batches(batch_size: QUERY_LIMIT.to_i) do |batched_appeal_states|
+    AppealState.where.not(decision_mailed: true).where.not(appeal_cancelled: true)
+      .find_in_batches(batch_size: QUERY_LIMIT.to_i) do |batched_appeal_states|
       batched_appeal_states.each do |appeal_state|
         # add_record_to_appeal_states_table(appeal_state.appeal)
         if appeal_state.appeal_type == "Appeal"

diff --git a/app/models/appeal.rb b/app/models/appeal.rb
@@ -263,9 +263,7 @@ def mst?
     return decision_issues.any?(&:mst_status) unless decision_issues.empty?
 
     request_issues.active.any?(&:mst_status) ||
-      (special_issue_list &&
-        special_issue_list.created_at < "2023-06-01".to_date &&
-        special_issue_list.military_sexual_trauma)
+      special_issue_list&.military_sexual_trauma
   end
 
   # :reek:RepeatedConditionals

diff --git a/app/models/bgs_power_of_attorney.rb b/app/models/bgs_power_of_attorney.rb
@@ -49,7 +49,7 @@ def find_or_create_by_file_number(file_number)
     end
 
     def find_or_create_by_claimant_participant_id(claimant_participant_id)
-      poa = find_or_create_by!(claimant_participant_id: claimant_participant_id)
+      poa = default_scoped.find_or_create_by!(claimant_participant_id: claimant_participant_id)
       if FeatureToggle.enabled?(:poa_auto_refresh, user: RequestStore.store[:current_user])
         poa.save_with_updated_bgs_record! if poa&.expired?
       end

diff --git a/app/models/concerns/distribution_concern.rb b/app/models/concerns/distribution_concern.rb
@@ -5,27 +5,47 @@ module DistributionConcern
 
   private
 
+  # A list of tasks which are expected or allowed to be open at time of distribution
+  ALLOWABLE_TASKS = [
+    RootTask.name,
+    DistributionTask.name,
+    JudgeAssignTask.name,
+    TrackVeteranTask.name,
+    VeteranRecordRequest.name,
+    *MailTask.subclasses.reject(&:blocking?).map(&:name)
+  ].freeze
+
   def assign_judge_tasks_for_appeals(appeals, judge)
     appeals.map do |appeal|
+      check_for_unexpected_tasks(appeal)
+
       # If an appeal does not have an open DistributionTask, then it has already been distributed by automatic
       # case distribution and a new JudgeAssignTask should not be created. This should only occur if two users
       # request a distribution simultaneously.
-      if appeal.tasks.open.of_type(:DistributionTask).any?
-        distribution_task_assignee_id = appeal.tasks.of_type(:DistributionTask).first.assigned_to_id
-        Rails.logger.info("Calling JudgeAssignTaskCreator for appeal #{appeal.id} with judge #{judge.css_id}")
-        JudgeAssignTaskCreator.new(appeal: appeal,
-                                   judge: judge,
-                                   assigned_by_id: distribution_task_assignee_id).call
-      else
-        msg = "Appeal ID #{appeal.id} cannot be distributed. Check its task tree and manually remediate if necessary"
-        title = "Appeal unable to be distributed"
-        SlackService.new(url: slack_url).send_notification(msg, title)
-
-        nil
-      end
+      next nil unless appeal.tasks.open.of_type(:DistributionTask).any?
+
+      distribution_task_assignee_id = appeal.tasks.of_type(:DistributionTask).first.assigned_to_id
+      Rails.logger.info("Calling JudgeAssignTaskCreator for appeal #{appeal.id} with judge #{judge.css_id}")
+      JudgeAssignTaskCreator.new(appeal: appeal,
+                                 judge: judge,
+                                 assigned_by_id: distribution_task_assignee_id).call
     end
   end
 
+  # Check for tasks which are open that we would not expect to see at the time of distribution. Send a slack
+  # message for notification of a potential bug in part of the application, but do not stop the distribution
+  def check_for_unexpected_tasks(appeal)
+    unless appeal.tasks.open.reject { |task| ALLOWABLE_TASKS.include?(task.class.name) }.empty?
+      send_slack_notification(appeal)
+    end
+  end
+
+  def send_slack_notification(appeal)
+    msg = "Appeal #{appeal.id}. Check its task tree for a potential bug or tasks which need to be manually remediated"
+    title = "Appeal with unexpected open tasks during distribution"
+    SlackService.new.send_notification(msg, title)
+  end
+
   def assign_sct_tasks_for_appeals(appeals)
     appeals.map do |appeal|
       next nil unless appeal.tasks.open.of_type(:DistributionTask).any?
@@ -41,10 +61,6 @@ def cancel_previous_judge_assign_task(appeal, judge_id)
     appeal.tasks.of_type(:JudgeAssignTask).where.not(assigned_to_id: judge_id).update(status: :cancelled)
   end
 
-  def slack_url
-    ENV["SLACK_DISPATCH_ALERT_URL"]
-  end
-
   # rubocop:disable Metrics/MethodLength
   # :reek:FeatureEnvy
   def create_sct_appeals(appeals_args, limit)

diff --git a/app/models/dispatch/task.rb b/app/models/dispatch/task.rb
@@ -273,7 +273,7 @@ def should_invalidate?
   end
 
   def no_open_tasks_for_appeal
-    if self.class.to_complete_task_for_appeal(appeal).any?
+    if self.class.default_scoped.to_complete_task_for_appeal(appeal).any?
       errors.add(:appeal, "Uncompleted task already exists for this appeal")
     end
   end

diff --git a/app/models/distribution.rb b/app/models/distribution.rb
@@ -52,6 +52,9 @@ def distribute!(limit = nil)
     end
   rescue StandardError => error
     process_error(error)
+    title = "Distribution Failed"
+    msg = "Distribution #{id} failed: #{error.message}}"
+    SlackService.new.send_notification(msg, title)
 
     raise error
   end

diff --git a/app/models/judge_case_review.rb b/app/models/judge_case_review.rb
@@ -30,7 +30,7 @@ class JudgeCaseReview < CaseflowRecord
   # As of Dec 2019, we want AMA and Legacy to use the same cap. The percentages may differ. The
   # goal is to get to the cap as steadily across the month as possible
   MONTHLY_LIMIT_OF_QUALITY_REVIEWS = 137
-  QUALITY_REVIEW_SELECTION_PROBABILITY = 0.032
+  QUALITY_REVIEW_SELECTION_PROBABILITY = 0.100
 
   def update_in_vacols!
     MetricsService.record("VACOLS: judge_case_review #{task_id}",

diff --git a/app/models/legacy_appeal.rb b/app/models/legacy_appeal.rb
@@ -636,10 +636,7 @@ def mst?
     return false unless FeatureToggle.enabled?(:mst_identification, user: RequestStore[:current_user]) &&
                         FeatureToggle.enabled?(:legacy_mst_pact_identification, user: RequestStore[:current_user])
 
-    issues.any?(&:mst_status) ||
-      (special_issue_list &&
-        special_issue_list.created_at < "2023-06-01".to_date &&
-        special_issue_list.military_sexual_trauma)
+    issues.any?(&:mst_status) || special_issue_list&.military_sexual_trauma
   end
 
   def pact?

diff --git a/app/models/quality_review_case_selector.rb b/app/models/quality_review_case_selector.rb
@@ -4,7 +4,7 @@ class QualityReviewCaseSelector
   # AMA Limit and Probability. See Legacy numbers at app/models/judge_case_review.rb:28
   # This probability was selected by Derek Brown, QR Director at BVA
   MONTHLY_LIMIT_OF_QUALITY_REVIEWS = 164
-  QUALITY_REVIEW_SELECTION_PROBABILITY = 0.188
+  QUALITY_REVIEW_SELECTION_PROBABILITY = 0.057
 
   class << self
     def select_case_for_quality_review?

diff --git a/app/models/tasks/judge_decision_review_task.rb b/app/models/tasks/judge_decision_review_task.rb
@@ -35,9 +35,9 @@ def self.label
   private
 
   def ama_judge_actions
-    # bypass special issues page if mst/pact enabled
+    # bypass special issues page if mst issue tracking is enabled
     return Constants.TASK_ACTIONS.JUDGE_AMA_CHECKOUT.to_h if
-      FeatureToggle.enabled?(:mst_identification) || FeatureToggle.enabled?(:pact_identification)
+      FeatureToggle.enabled?(:mst_identification)
 
     Constants.TASK_ACTIONS.JUDGE_AMA_CHECKOUT_SPECIAL_ISSUES.to_h
   end

diff --git a/app/models/tasks/judge_dispatch_return_task.rb b/app/models/tasks/judge_dispatch_return_task.rb
@@ -18,9 +18,9 @@ def self.label
 
   # :reek:UtilityFunction
   def ama_issue_checkout
-    # bypass special issues page if mst/pact enabled
+    # bypass special issues page if mst issue tracking is enabled
     return Constants.TASK_ACTIONS.JUDGE_AMA_CHECKOUT.to_h if
-      FeatureToggle.enabled?(:mst_identification) || FeatureToggle.enabled?(:pact_identification)
+      FeatureToggle.enabled?(:mst_identification)
 
     Constants.TASK_ACTIONS.JUDGE_AMA_CHECKOUT_SPECIAL_ISSUES.to_h
   end

diff --git a/app/models/team_quota.rb b/app/models/team_quota.rb
@@ -94,6 +94,6 @@ def most_recent_user_count
 
   # Cap the search to the last month to avoid an infinite loop
   def most_recent_user_counts
-    self.class.where(task_type: task_type).order(:date).limit(31).lazy.map(&:user_count)
+    self.class.default_scoped.where(task_type: task_type).order(:date).limit(31).lazy.map(&:user_count)
   end
 end
diff --git a/app/models/vbms_uploaded_document.rb b/app/models/vbms_uploaded_document.rb
@@ -10,7 +10,10 @@ class VbmsUploadedDocument < CaseflowRecord
   attribute :file, :string
 
   scope :successfully_uploaded, lambda {
-    where(error: nil).where.not(uploaded_to_vbms_at: nil, attempted_at: nil, processed_at: nil)
+    where(error: nil)
+      .where.not(uploaded_to_vbms_at: nil)
+      .where.not(attempted_at: nil)
+      .where.not(processed_at: nil)
   }
 
   def cache_file

diff --git a/app/queries/etl/unknown_status_with_completed_root_task_query.rb b/app/queries/etl/unknown_status_with_completed_root_task_query.rb
@@ -21,6 +21,7 @@ def appeal_ids_for_completed_root_tasks
   def appeal_ids_for_open_child_tasks
     ETL::Task.select(:appeal_id).distinct
       .where(appeal_type: "Appeal")
-      .where.not(task_type: "RootTask", task_status: Task.closed_statuses)
+      .where.not(task_type: "RootTask")
+      .where.not(task_status: Task.closed_statuses)
   end
 end
diff --git a/app/queries/etl/unknown_status_with_open_root_task_query.rb b/app/queries/etl/unknown_status_with_open_root_task_query.rb
@@ -21,6 +21,7 @@ def appeal_ids_for_open_root_tasks
   def appeal_ids_for_open_child_tasks
     ETL::Task.select(:appeal_id).distinct
       .where(appeal_type: "Appeal")
-      .where.not(task_type: "RootTask", task_status: Task.closed_statuses)
+      .where.not(task_type: "RootTask")
+      .where.not(task_status: Task.closed_statuses)
   end
 end
diff --git a/app/repositories/task_action_repository.rb b/app/repositories/task_action_repository.rb
@@ -902,9 +902,9 @@ def cancel_task_and_return_to_sct_action(task, _)
     def select_ama_review_decision_action(task)
       return Constants.TASK_ACTIONS.REVIEW_VACATE_DECISION.to_h if task.appeal.vacate?
 
-      # route to decision if mst/pact toggles are enabled.
+      # bypass special issues page if MST is enabled
       return Constants.TASK_ACTIONS.REVIEW_AMA_DECISION.to_h if
-        FeatureToggle.enabled?(:mst_identification) || FeatureToggle.enabled?(:pact_identification)
+        FeatureToggle.enabled?(:mst_identification)
 
       Constants.TASK_ACTIONS.REVIEW_AMA_DECISION_SP_ISSUES.to_h
     end

diff --git a/app/services/deprecation_warnings/disallowed_deprecations.rb b/app/services/deprecation_warnings/disallowed_deprecations.rb
@@ -18,7 +18,8 @@ class ::DisallowedDeprecationError < StandardError; end
     /ActionView::Base instances should be constructed with a lookup context, assignments, and a controller./,
     /ActionView::Base instances must implement `compiled_method_container`/,
     /render file: should be given the absolute path to a file/,
-    /`ActiveRecord::Result#to_hash` has been renamed to `to_a`/
+    /`ActiveRecord::Result#to_hash` has been renamed to `to_a`/,
+    /Class level methods will no longer inherit scoping/
   ].freeze
 
   # Regular expressions for deprecation warnings that should raise an exception on detection

diff --git a/app/services/deprecation_warnings/production_handler.rb b/app/services/deprecation_warnings/production_handler.rb
@@ -46,9 +46,7 @@ def emit_warning_to_sentry(message, callstack, deprecation_horizon, gem_name)
       def emit_warning_to_slack_alerts_channel(message)
         slack_alert_title = "Deprecation Warning - #{APP_NAME} (#{ENV['DEPLOY_ENV']})"
 
-        SlackService
-          .new(url: ENV["SLACK_DISPATCH_ALERT_URL"])
-          .send_notification(message, slack_alert_title, SLACK_ALERT_CHANNEL)
+        SlackService.new.send_notification(message, slack_alert_title, SLACK_ALERT_CHANNEL)
       end
     end
   end

diff --git a/app/services/etl/syncer.rb b/app/services/etl/syncer.rb
@@ -24,13 +24,8 @@ def initialize(since: nil, etl_build:, id_offset: 0)
     @id_offset = id_offset
   end
 
-  # :reek:UtilityFunction
-  def slack_url
-    ENV["SLACK_DISPATCH_ALERT_URL"]
-  end
-
   def slack_service
-    @slack_service ||= SlackService.new(url: slack_url)
+    @slack_service ||= SlackService.new
   end
 
   # :reek:FeatureEnvy

diff --git a/app/services/slack_service.rb b/app/services/slack_service.rb
@@ -16,7 +16,7 @@ class SlackService
     warn: "#ffff00"
   }.freeze
 
-  def initialize(url:)
+  def initialize(url: ENV["SLACK_DISPATCH_ALERT_URL"])
     @url = url
   end