Chrisbdetlef/appeals 49398

app/controllers/application_controller.rb

@@ -161,6 +161,14 @@ def case_distribution_url
     }
   end
 
+  def test_seeds_url
+    {
+      title: "Test Seeds",
+      link: "/test/seeds",
+      sort_order: 7
+    }
+  end
+
   def hearing_application_url
     {
       title: "Hearings",
@@ -210,14 +218,31 @@ def manage_users_menu_item
 
   def admin_menu_items
     admin_urls = []
-    admin_urls.concat(manage_teams_menu_items) if current_user&.administered_teams&.any?
-    admin_urls.push(manage_users_menu_item) if current_user&.can_view_user_management?
-    admin_urls.push(case_distribution_url) if current_user&.organizations&.any?(&:users_can_view_levers?)
+    add_team_management_items(admin_urls)
+    add_user_management_items(admin_urls)
+    add_case_distribution_item(admin_urls)
+    add_test_seeds_item(admin_urls)
+
+    admin_urls.flatten
+  end
 
+  def add_team_management_items(admin_urls)
     if current_user&.can_view_team_management? || current_user&.can_view_judge_team_management?
       admin_urls.unshift(manage_all_teams_menu_item)
     end
-    admin_urls.flatten
+  end
+
+  def add_user_management_items(admin_urls)
+    admin_urls.concat(manage_teams_menu_items) if current_user&.administered_teams&.any?
+    admin_urls.push(manage_users_menu_item) if current_user&.can_view_user_management?
+  end
+
+  def add_case_distribution_item(admin_urls)
+    admin_urls.push(case_distribution_url) if current_user&.organizations&.any?(&:users_can_view_levers?)
+  end
+
+  def add_test_seeds_item(admin_urls)
+    admin_urls.push(test_seeds_url) if current_user&.organizations&.any?(&:users_can_view_levers?)
   end
 
   def dropdown_urls

app/controllers/case_distribution_levers_tests_controller.rb

@@ -39,6 +39,19 @@ def appeals_ready_to_distribute
     send_data csv_data, filename: filename
   end
 
+  def appeals_non_priority_ready_to_distribute
+    csv_data = AppealsNonPriorityReadyForDistribution.process
+
+    # Get the current date and time for dynamic filename
+    current_datetime = Time.zone.now.strftime("%Y%m%d-%H%M")
+
+    # Set dynamic filename with current date and time
+    filename = "AMA_Non_priority_distributable_#{current_datetime}.csv"
+
+    # Send CSV as a response with dynamic filename
+    send_data csv_data, filename: filename
+  end
+
   def appeals_distributed
     # change this to the correct class
     csv_data = AppealsDistributed.process

app/controllers/concerns/errors.rb

@@ -3,11 +3,12 @@
 module Errors
   extend ActiveSupport::Concern
   def invalid_role_error
-    render json: {
+    {
       "errors": [
         "title": "Role is Invalid",
         "detail": "User is not allowed to perform this action"
-      ]
-    }, status: :bad_request
+      ],
+      "status": "bad_request"
+    }
   end
 end

app/controllers/legacy_tasks_controller.rb

@@ -136,7 +136,13 @@ def validate_user_id
   end
 
   def validate_user_role
-    return invalid_role_error unless ROLES.include?(user_role)
+    return true if ROLES.include?(user_role)
+
+    Rails.logger.info("User with roles #{current_user.roles.join(', ')} "\
+      "couldn't access #{request.original_url}: Error: #{invalid_role_error}")
+
+    session["return_to"] = request.original_url
+    redirect_to "/unauthorized"
   end
 
   def user

app/controllers/test_docket_seeds_controller.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+class TestDocketSeedsController < ApplicationController
+  before_action :check_environment # , :verify_access
+  # before_action :current_user, only: [:reset_all_appeals]
+
+  def seed_dockets
+    JSON.parse(request.body.read).each do |row_entry|
+      task_name = Constants.TEST_SEEDS.to_h[row_entry["seed_type"].to_sym]
+      ENV["SEED_COUNT"] = row_entry["seed_count"].to_s
+      ENV["DAYS_AGO"] = row_entry["days_ago"].to_s
+      ENV["JUDGE_CSS_ID"] = row_entry["judge_css_id"].to_s
+
+      Rake::Task[task_name].reenable
+      Rake::Task[task_name].invoke
+
+      ENV.delete("SEED_COUNT")
+      ENV.delete("DAYS_AGO")
+      ENV.delete("JUDGE_CSS_ID")
+    end
+
+    head :ok
+  end
+
+  def reset_all_appeals
+    RequestStore[:current_user] = current_user
+    DistributionTask.where(status: "assigned").map { |t| t.update!(status: "on_hold") }
+    VACOLS::Case.where(bfcurloc: %w[81 83]).map { |c| c.update!(bfcurloc: "testing") }
+
+    head :ok
+  end
+
+  private
+
+  # def verify_access ##future work
+  #   return true if current_user&.organizations && current_user.organizations.any?(&:users_can_view_levers?)
+
+  #   session["return_to"] = request.original_url
+  #   redirect_to "/unauthorized"
+  # end
+
+  def check_environment
+    return true if Rails.env.development?
+    return true if Rails.deploy_env?(:demo)
+    return true if Rails.deploy_env?(:uat)
+
+    redirect_to "/unauthorized"
+  end
+end

app/controllers/test_seeds_controller.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require "csv"
+
+class Test::TestSeedsController < ApplicationController
+  before_action :check_environment
+  before_action :verify_access, only: [:seeds]
+  before_action :authorize_admin, only: [:seeds]
+
+  def seeds
+    # seeds
+    render "/test/seeds"
+  end
+
+  private
+
+  def check_environment
+    return true if Rails.env.development?
+    return true if Rails.deploy_env?(:demo)
+
+    redirect_to "/unauthorized"
+  end
+
+  def authorize_admin
+    error = ["UNAUTHORIZED"]
+
+    resp = {
+      status_code: 500,
+      message: error,
+      user_is_an_acd_admin: false
+    }
+    render json: resp unless CDAControlGroup.singleton.user_is_admin?(current_user)
+  end
+
+  def verify_access
+    return true if current_user&.organizations && current_user.organizations.any?(&:users_can_view_levers?)
+
+    session["return_to"] = request.original_url
+    redirect_to "/unauthorized"
+  end
+end

app/jobs/push_priority_appeals_to_judges_job.rb

@@ -57,9 +57,7 @@ def slack_report # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     docket_coordinator.dockets.each_pair do |sym, docket|
       report << "*Number of #{sym} appeals _not_ distributed*: #{docket.count(priority: true, ready: true)}"
     end
-    unless disable_legacy?
-      report << "*Number of Legacy Hearing Non Genpop appeals _not_ distributed*: #{legacy_not_genpop_count}"
-    end
+    report << "*Number of Legacy Hearing Non Genpop appeals _not_ distributed*: #{legacy_not_genpop_count}"
 
     report << ""
     report << "*Debugging information*"
@@ -181,10 +179,6 @@ def use_by_docket_date?
     FeatureToggle.enabled?(:acd_distribute_by_docket_date, user: RequestStore.store[:current_user])
   end
 
-  def disable_legacy?
-    FeatureToggle.enabled?(:acd_disable_legacy_distributions, user: RequestStore.store[:current_user])
-  end
-
   def legacy_not_genpop_count
     docket_coordinator.dockets[:legacy].not_genpop_priority_count
   end

app/models/case_distribution_lever.rb

@@ -21,7 +21,9 @@ class CaseDistributionLever < ApplicationRecord
     #{Constants.DISTRIBUTION.ama_hearing_case_affinity_days}
     #{Constants.DISTRIBUTION.cavc_affinity_days}
     #{Constants.DISTRIBUTION.ama_evidence_submission_docket_time_goals}
-    #{Constants.DISTRIBUTION.ama_hearings_docket_time_goals}
+    #{Constants.DISTRIBUTION.ama_hearing_docket_time_goals}
+    #{Constants.DISTRIBUTION.ama_hearing_start_distribution_prior_to_goals}
+    #{Constants.DISTRIBUTION.ama_evidence_submission_start_distribution_prior_to_goals}
   ).freeze
 
   FLOAT_LEVERS = %W(
@@ -30,6 +32,11 @@ class CaseDistributionLever < ApplicationRecord
     #{Constants.DISTRIBUTION.nod_adjustment}
   ).freeze
 
+  BOOLEAN_LEVERS = %W(
+    #{Constants.DISTRIBUTION.disable_legacy_priority}
+    #{Constants.DISTRIBUTION.disable_legacy_non_priority}
+  ).freeze
+
   def history_value
     if combination_lever?
       combination_value
@@ -184,6 +191,8 @@ def method_missing_value(name)
           Integer(lever)
         elsif FLOAT_LEVERS.include?(name)
           Float(lever)
+        elsif BOOLEAN_LEVERS.include?(name)
+          ActiveModel::Type::Boolean.new.cast(lever)
         else
           lever
         end

app/models/concerns/by_docket_date_distribution.rb

@@ -32,12 +32,10 @@ def requested_distribution
     priority_rem = priority_target.clamp(0, @rem)
     distribute_priority_appeals_from_all_dockets_by_age_to_limit(priority_rem, style: "request")
 
-    unless FeatureToggle.enabled?(:acd_disable_nonpriority_distributions, user: RequestStore.store[:current_user])
-      # Distribute the oldest nonpriority appeals from any docket if we haven't distributed {batch_size} appeals
-      # @nonpriority_iterations guards against an infinite loop if not enough cases are ready to distribute
-      until @rem <= 0 || @nonpriority_iterations >= MAX_NONPRIORITY_ITERATIONS
-        distribute_nonpriority_appeals_from_all_dockets_by_age_to_limit(@rem)
-      end
+    # Distribute the oldest nonpriority appeals from any docket if we haven't distributed {batch_size} appeals
+    # @nonpriority_iterations guards against an infinite loop if not enough cases are ready to distribute
+    until @rem <= 0 || @nonpriority_iterations >= MAX_NONPRIORITY_ITERATIONS
+      distribute_nonpriority_appeals_from_all_dockets_by_age_to_limit(@rem)
     end
     @appeals
   end
@@ -59,7 +57,7 @@ def distribute_nonpriority_appeals_from_all_dockets_by_age_to_limit(limit, style
     end
   end
 
-  # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+  # rubocop:disable Metrics/MethodLength
   def ama_statistics
     priority_counts = { count: priority_count }
     nonpriority_counts = { count: nonpriority_count }
@@ -69,19 +67,15 @@ def ama_statistics
       nonpriority_counts[sym] = docket.count(priority: false, ready: true)
     end
 
-    unless FeatureToggle.enabled?(:acd_disable_legacy_distributions, user: RequestStore.store[:current_user])
-      priority_counts[:legacy_hearing_tied_to] = legacy_hearing_priority_count(judge)
-      nonpriority_counts[:legacy_hearing_tied_to] = legacy_hearing_nonpriority_count(judge)
-    end
+    priority_counts[:legacy_hearing_tied_to] = legacy_hearing_priority_count(judge)
+    nonpriority_counts[:legacy_hearing_tied_to] = legacy_hearing_nonpriority_count(judge)
 
     nonpriority_counts[:iterations] = @nonpriority_iterations
 
     sct_appeals_counts = @appeals.count { |appeal| appeal.try(:sct_appeal) }
 
     settings = {}
     feature_toggles = [
-      :acd_disable_legacy_distributions,
-      :acd_disable_nonpriority_distributions,
       :specialty_case_team_distribution
     ]
     feature_toggles.each do |sym|
@@ -110,7 +104,7 @@ def ama_statistics
                #{error.class}: #{error.message}, #{error.backtrace.first}"
     }
   end
-  # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
+  # rubocop:enable Metrics/MethodLength
 
   def ama_distributed_cases_tied_to_ineligible_judges
     @appeals.filter_map do |appeal|

app/models/concerns/distribution_concern.rb

@@ -64,7 +64,7 @@ def cancel_previous_judge_assign_task(appeal, judge_id)
   # rubocop:disable Metrics/MethodLength
   # :reek:FeatureEnvy
   def create_sct_appeals(appeals_args, limit)
-    appeals = appeals(appeals_args)
+    appeals = ready_priority_nonpriority_appeals(appeals_args)
       .limit(limit)
       .includes(:request_issues)
 

app/models/distribution.rb

@@ -92,8 +92,6 @@ def judge_tasks
   end
 
   def judge_legacy_tasks
-    return [] if FeatureToggle.enabled?(:acd_disable_legacy_distributions, user: RequestStore.store[:current_user])
-
     legacy_tasks = QueueRepository.tasks_for_user(judge.css_id)
 
     @judge_legacy_tasks ||= legacy_tasks.select { |task| task.assigned_to_attorney_date.nil? }