Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release R2.1.0 FY24Q4.1.0 #22255

Closed
wants to merge 6 commits into from
Closed

Release R2.1.0 FY24Q4.1.0 #22255

wants to merge 6 commits into from

Conversation

craigrva
Copy link
Contributor

@craigrva craigrva commented Jul 22, 2024

Release R2.1.0 FY24Q4.1

  • APPEALS-46239 ACD: Distribution Stats improvements
  • APPEALS-46266 ACD: Push Priority Slack Message improve and cleanup
  • APPEALS-44287: When multiple Hearings exist a postponed Hearing can result in the Appeal being treated as genpop instead of its affinity
  • APPEALS-46639 SCT Bulk Assign Backend Pagination & AOD Filter
  • APPEALS-51237: Optimize spec/feature/intake/appeal/edit_spec.rb
  • APPEALS-51536: Optimize feature tests in spec/feature/automatic_case_distribution

Acceptance Criteria

  • Code compiles correctly

zurbergram and others added 3 commits July 19, 2024 10:06
* APPEALS-42221 Distribution Stats: Break statistics into columns (#21717)

* rebuild branch

* Create 20240506140249_add_cols_to_distribution_stats.rb

* unit tests and linting

* APPEALS-46244, APPEALS-46245 (#22077)

* remove unnecessary reporting

* send slack message to console if on local or demo

* add excluded judges to slack report

* reporting method cleanup

* added affinity date stats to distribution_stats for each docket

* Update docket.rb

* Update distribution_scopes.rb

* unit tests and linting

* unit tests and linting

* Slack message update

* Update push_priority_appeals_to_judges_job.rb

* Update push_priority_appeals_to_judges_job_spec.rb

* code climate and code review changes (#22148)

* code climate and code review changes

* move code out to its own class

* lint fixes

* revert

* disable reek checks

* fix method calls
… for distribution (#22140)

* first run at an SQL query removing duplicate appeals from distribution

* code refactor and excluding disposition held and select that appeal for distribution

* automated test for the duplicate hearing bug

* fix rubocop offense SpaceInsideBlockBraces

---------

Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
* Initial commit and turning off queue tab variables used for the frontend pagination for the bulk assign tab for the specialty case team.

* Altered the queue actions to work with the new task selection action and a new redux action to remove tasks from a cached queue state. Also updated queue table to work with the redux caching instead of local state caching.

* Added in task selection function changes to TaskTable to work
with the altered task selection redux action. Also added the ability to pass down the redux cache property to queue table. Refactored the UnassignedCasesPage to allow for backend pagination of queue table instead of only working via frontend loaded data from the redux store.

* Added the queueTableCache reducer slice. Added a :advanced_on_docket trait to the task factory for specialty_case_team_assign_tasks. Added the caching combined reducer to the queue table reducers.

* Moved columnsFromConfig and createColumnObject functions out of QueueTableBuilder.jsx into a utils file so it can be used in multiple components around the app.

* Updated the setSelectionOfTaskOfUser to work with the new action and data that it should be expecting.

* Updated the selectedTasksSelector to work with the new task selection reducer and action.

* Added a parameter for useReduxCache for TaskTable to send down to queue table instead of always setting it to true. Removed some comments from the queueTableCacheSlice removeTaskIdsFromCache reducer method/action. Passed in the new useReduxCache property to TaskTable in the UnassignedCasesPage component for the sct bulk assign queue.

* Removed code out of QueueTableBuilder that is now in queueTableUtils.js.

* Fixed a bug if queueConfig was an empty hash in the UnassignedCasesPage component.

* Serializer optimizations for contested issues and issue categories. Also included request issues in the includes for the sct queue to take advantage of these optimizations.

* Fixed a bug where clear filters was not properly updating the get parameters anymore for queue table.

* Added cavc_type trait to the sct assign task factory.

* Fix code climate issues.

---------

Co-authored-by: = <tyler.broyles@va.gov>
Copy link

codeclimate bot commented Jul 22, 2024

Code Climate has analyzed commit 3d26a20 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Performance 2

View more on Code Climate.

craigrva and others added 3 commits July 22, 2024 15:01
…22150)

* refactoring edit_spec

* move one assertion and remove duplicate test

* refactor withdraw issues context

* move duplicate test assertions

* move duplicate test assertions to existing tests and remove duplicate tests

* move assertion and remove duplicate test

* consolidate SCT appeal tests

* refactor SCT tests to use step blocks

* consolidate a individual test into a step

* move CC appeal task tests to appeals_controller_spec intead of a feature test

* remove unnecessary code comments

* modify edit spec to use case details page instead of searching again
* consolidate member not admin tests

* remove commented portions of test

* move tests from affinity_days_levers_spec.rb

* move tests from affinity_days_levers_spec.rb, last commit was from audit_lever_history_table_spec.rb

* remove ama_np_dist_goals_by_docket_lever_spec.rb

* remove batch_size_levers_spec.rb

* remove inactive_data_elements_levers_spec.rb

* remove lever_buttons_spec.rb

* refactor

* move jest file for convention, add snapshot

* move test for admin ui not interactable for non-admins to a jest test

* remove unnecessary comments, whitespace

* restore jest folder structure

* modify assertions

* remove TODO comment

* add assertion to allow async save actions to be executed

* add check to ensure banner is gone before trying to save

* refactor assertions for lever history display

* fix failing dependency report tests
@craigrva craigrva closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants