Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/appeals 34965 demo #22265

Closed
wants to merge 455 commits into from
Closed

Feature/appeals 34965 demo #22265

wants to merge 455 commits into from

Conversation

cacevesva
Copy link
Contributor

Resolves Jira Issue Title

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  • For feature branches merging into master: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

cacevesva and others added 30 commits March 15, 2024 08:36
* remove unused route and fix typo

* standardize prop names

* use standardized prop names

* use standardized prop names and abstract magic strings

* remove unnecessary scoping

* CorrespondenceIntakeTask status in_progress on create

* update spec for changes

* update helper to reflect workflow

* correspondence intake task status in progress on creation

* efolder upload failed task no longer needs task url since its not displayed on the table

* rubocop style fix

* rubocop fix extra blank line
* Fix Code Climate Issues

* Improve Code

- Add class comments to service files.

- Add underscores to unused method params in the fake BGS Service.

* Fix Bad Method Invocation

* Fix Param Causing Spec Failures
* Fix Code Climate Issues

* Improve Code

- Add class comments to service files.

- Add underscores to unused method params in the fake BGS Service.

* Fix Bad Method Invocation

* Fix Param Causing Spec Failures

* Make BGS Service Method Static

- This will allow the other static methods to use the init_client_params
method.
* adding correspondence intake controller

* moving methods that seem to be suited for the intake-specific controller

* refactor conditional

* updating the routes

* Updating the remainder of intake routes

* removing a repeated method found

* moving intake specs to new intake controller spec

* fixing file for failing tests

* Fixing failing specs

---------

Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: Jim Foley <james.foley4@va.gov>
* modified to show error in date filter

* modified datecomplete

* change name in header

* fix style issue

* Fix spec file

* Add new test in spec file
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* sorting query for date completed column on correspondence tables

* optimize task query for your correspondence completed tab

* optimize task query for corresepondence cases completed tab

* update correspondence task filter for new column name

* add name props to avoid console errors

* correct prop types

* update with new column name

* update seeds to reflect expected workflow

* update broken tests

* remove unnecessarily bloated test case setup

* update broken test expectation
* Fix Code Climate Issues

* Improve Code

- Add class comments to service files.

- Add underscores to unused method params in the fake BGS Service.

* Fix Bad Method Invocation

* Fix Param Causing Spec Failures

* Make BGS Service Method Static

- This will allow the other static methods to use the init_client_params
method.

* Fix Misc. UAT Issues

- Handle errors raised by the BGS service.

- Update the auto assign status ping to include the correct
assigned count.

- Fix bug that caused CorrespondenceAutoAssignRunVerifier to
incorrectly report that runs are OK.

* Fix Incorrect Field Checked for Run Verification
…21202)

* mostly finished modal

* added conditional rendering of textarea

* updated RadioField name

* added redux setup for selected veteran details.

* added RadioFieldWithChildren component.

* Added complete modal for reassign

* stored veteran details on click

* added diasbled button logic for confirm

* wired button for remove package task.

* Wired banner message prototype

* fixed crash

* task now reassigns properly

* implemented failure banner and reject option

* fixed banner messages.

* fixed sizing issue and added textarea to reject

* fixed frontend css

* improved backend logic.

* fixed modal closing X button

* fixed error in method call, commented data changing code

* backbone for reassign and remove modal tests

* added parent_task_url

* Implemented taskurl for remove/ reassign task

* delete binding pry

* tests suite for correspondence cases

* refactored logic

* data seeding and minor refactors

* fix test suit

* uncommented experimental code

* added remove modal

* cleaned up controller logic

* final AC work in progress

* Fixes for linting and update reviewpackagetask error

* futher reduced code climate issues

* mode code climate fixes

* fixed more code climate issues

* fixed linting errors. fixed submit disable logic

* refined logic for cleaner user experience

* added seed data for reassign / remove package task

* fixed bug on buildMailUserData

* swapped mismatched messages

* finished spec tests

* Hot fix to remove Intake from Veterans Details (#21087)

* fix feature test

* Revert "fix feature test"

This reverts commit 948d637.

* pushing up tests for ryan to run

* feature tests

* remove Intake from Veteran Details

* resolve pr conflicts

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Khalin/appeals 35818 - Bug Fix (#21091)

* WIP for new seeds file

* Updated query so data shows in table

* Revert "WIP for new seeds file"

This reverts commit ea1dd11.

* Updated query so data shows in table

* Your Correspondence completed tab completed test spec

* The completed tab now showing dates

* Bug Fix

* created completed_by_date and added business logic to root task (#21103)

* APPEALS-35488: Update UAT Seed Scripts for Correspondence (#21129)

* refactored correspondence seeds to accept vet and user. refactored create_correspondence.

* refactored seed to create intake correspondence with upload failed task

* updated seed to create correspondence with intake task

* refactored rest of queue correspondence seed to be able to accept a user and veteran.

* lowered count for correspondence seeds

* refactored multi_correspondences to create review package tasks, handle user input, and use queue helpers

* disabled linting check

* added multi correspondence and queue correspondence seeds to rake task

* cleaned up correspondence rake to be more DRY

* Khalin/appeals 35818 Date Completed Column Filtering Bug Fix (#21134)

* WIP for new seeds file

* Updated query so data shows in table

* Revert "WIP for new seeds file"

This reverts commit ea1dd11.

* Updated query so data shows in table

* Your Correspondence completed tab completed test spec

* The completed tab now showing dates

* Bug Fix

* Date Completed Filtering Fixed

* Updated changes

* Fixing Failing test

---------

Co-authored-by: Jim Foley <james.foley4@va.gov>

* updated completed filter to filter on closed_at value (#21166)

* Edit VA DOR access for InboundOpsTeamAdmin user (#21150)

* 🔀 jcroteau/APPEALS-38492 - Fix duplicate results from joins on certain AR associations (#21097)

* refactored seed scripts for correspondence to have more detailed notes (#21170)

* Wmedders21/appeals 41493 (#21162)

* remove unused route and fix typo

* standardize prop names

* use standardized prop names

* use standardized prop names and abstract magic strings

* remove unnecessary scoping

* CorrespondenceIntakeTask status in_progress on create

* update spec for changes

* update helper to reflect workflow

* correspondence intake task status in progress on creation

* efolder upload failed task no longer needs task url since its not displayed on the table

* rubocop style fix

* rubocop fix extra blank line

* updated props to new branch props

* sanitized string with react

* fixed missing end in queue_correspondence

* sanitize newUrl attempt #2

* fixed buildMailUserData

* added missing end statement

* fixed linting

* modified per github feedback

* refactored redundant code

* linting fix. refactored correspondence_controller logic

* linting fix

* partial refactor with code migrated to correspondence_controller_util

* refactored a very large amount of code to the CorrespondenceControlletUtil

* Justin/APPEALS-42009 (#21118)

* adding correspondence intake controller

* moving methods that seem to be suited for the intake-specific controller

* refactor conditional

* updating the routes

* Updating the remainder of intake routes

* removing a repeated method found

* moving intake specs to new intake controller spec

* fixing file for failing tests

* Fixing failing specs

---------

Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: Jim Foley <james.foley4@va.gov>

* Piedram/appeals 41494 (#21196)

* modified to show error in date filter

* modified datecomplete

* change name in header

* fix style issue

* Fix spec file

* Add new test in spec file

* Error banner now working as intended (#21206)

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* added comment

* Justin/APPEALS-42009 (#21118)

* adding correspondence intake controller

* moving methods that seem to be suited for the intake-specific controller

* refactor conditional

* updating the routes

* Updating the remainder of intake routes

* removing a repeated method found

* moving intake specs to new intake controller spec

* fixing file for failing tests

* Fixing failing specs

---------

Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: Jim Foley <james.foley4@va.gov>

* Piedram/appeals 41494 (#21196)

* modified to show error in date filter

* modified datecomplete

* change name in header

* fix style issue

* Fix spec file

* Add new test in spec file

* Wmedders21/appeals 42552 (#21209)

* sorting query for date completed column on correspondence tables

* optimize task query for your correspondence completed tab

* optimize task query for corresepondence cases completed tab

* update correspondence task filter for new column name

* add name props to avoid console errors

* correct prop types

* update with new column name

* update seeds to reflect expected workflow

* update broken tests

* remove unnecessarily bloated test case setup

* update broken test expectation

* updated linting

* fixed linting issues

---------

Co-authored-by: IsaiahBar <isaiah.barnett@va.gov>
Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com>
Co-authored-by: Jim Foley <james.foley4@va.gov>
Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: piedram <110848569+piedram@users.noreply.github.com>
* Initial commit for search bar

* Search bar chnages and removed post request

* Modified the search results display

* Removed unused code

* Removed searchValue from unnecessary places

* Search results on page load

* APPEALS-38964 - Search criteria for all columns

* moved search logic from table builder into queue table

* Removed unused method

* Made the changes back for tabPaginationOptions

* Remove Console Log

* Feature test cases for Search bar

* Added few more feature test cases for Search bar

* Added pagination spec

* Failing spec

* Added few more test cases

* APPEALS-38964 - Additioanl RSpec tests, Fixed page visits

* Edit VA DOR access for InboundOpsTeamAdmin user (#21150)

* 🔀 jcroteau/APPEALS-38492 - Fix duplicate results from joins on certain AR associations (#21097)

* refactored seed scripts for correspondence to have more detailed notes (#21170)

* Modified the test spec for sorted by veteran details

* APPEALS-38964 - Updated Flaky Test

* APPEALS-38964 - Notes Update

* Added serializer for few more columns

* Added serializer for label and closed_at columns

* APPEALS-38964 - Linting, Assigned_By

* Sort and pagination column fix

* Removed logic for sort and pagination fix

* Modified column_names with self class in all the tab class

* DRY all the tabs

* Extra Linting and Test Updates

* Can able to search with number

* Updates for tabs and linting

* Linting

* fix for completed date serializer

* Reverting Conditional for VetDetails and VADOR

---------

Co-authored-by: KiMauVA <Ki.Mau@va.gov>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
…umn (#21228)

* fixed select column appearing in superuser table

* linting fixes

* fixed linter issues

* fixed merge conflicts

---------

Co-authored-by: Jim Foley <james.foley4@va.gov>
* prevent overwriting correspondence uuid on page load

* provide saved redux store to view if the intake form has been previously worked

* Update test expectations

* Merge with feature
* fixed missing text

* updated instructions text

* added instructions to action required tasks

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
cacevesva and others added 27 commits July 16, 2024 09:39
* APPEALS-42516 - CSS Updates

* APPEALS-42516 - Additional CSS for View all link

* Deleting empty rulesets for linter

* Lintagain

* &nsp removal

---------

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* Completed Tabs link code modifications

* Modified the code changes as commented
…22218)

* return the updated serialized correspondence when updating

* removed unused veteranInformation (#22221)
…ews Dropdown (#22230)

* added correspondence dropdown checks on the user model

* refactored Switch Views dropdown to populate values from backend

* removed unused props

* added missing param that was passed to method.
* filtered attorney tasks to not include correspondence

* added correspondence filtering for other Appeal Queues.
…22218)

* return the updated serialized correspondence when updating

* removed unused veteranInformation (#22221)
…ews Dropdown (#22230)

* added correspondence dropdown checks on the user model

* refactored Switch Views dropdown to populate values from backend

* removed unused props

* added missing param that was passed to method.
* filtered attorney tasks to not include correspondence

* added correspondence filtering for other Appeal Queues.
* overriding method for all caseflow users to access correspondence details page

* Adding tests for other caseflow users on correspondence details page

* updating lint failure

* Linting fix

* adding back true, hopefully fixing lint errors
…sks. (#22256)

* overriding method for all caseflow users to access correspondence details page

* Adding tests for other caseflow users on correspondence details page

* updating lint failure

* Linting fix

* adding back true, hopefully fixing lint errors

* adding temporary under_constructions task urls for merge and split tasks.
Copy link

codeclimate bot commented Jul 23, 2024

Code Climate has analyzed commit 047c13b and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 6
Security 1

View more on Code Climate.

@cacevesva cacevesva closed this Jul 26, 2024
@cacevesva cacevesva deleted the feature/APPEALS-34965-demo branch July 26, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.