Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test node 18 [Don't merge] #22352

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
- name: install node version
uses: actions/setup-node@v4
with:
node-version: '16.16.0'
node-version: '18.20.2'

# If we don't explicitly set this, the runner doesn't find the path when trying to save the cache
- name: Set yarn cache directory
Expand Down Expand Up @@ -297,7 +297,7 @@ jobs:
- name: install node version
uses: actions/setup-node@v4
with:
node-version: '16.16.0'
node-version: '18.20.2'

- name: validate node version
run: ./ci-bin/capture-log "node -v"
Expand Down Expand Up @@ -350,7 +350,7 @@ jobs:
- name: install node version
uses: actions/setup-node@v4
with:
node-version: '16.16.0'
node-version: '18.20.2'

- name: Install Node Dependencies
run: ./ci-bin/capture-log "cd client && yarn install --frozen-lockfile"
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.16.0
18.20.2
4 changes: 1 addition & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ RUN apt -y update && \
# Install node
RUN mkdir /usr/local/nvm
ENV NVM_DIR /usr/local/nvm
ENV NODE_VERSION 16.16.0
ENV NODE_VERSION 18.20.2
ENV NVM_INSTALL_PATH $NVM_DIR/versions/node/v$NODE_VERSION
RUN curl --silent -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash
RUN source $NVM_DIR/nvm.sh \
Expand Down Expand Up @@ -84,5 +84,3 @@ RUN bundle install && \

# Run the app
ENTRYPOINT ["/bin/bash", "-c", "/caseflow/docker-bin/startup.sh"]


29 changes: 15 additions & 14 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "none",
"version": "0.0.1",
"engines": {
"node": "16.16.0"
"node": "18.20.2"
},
"scripts": {
"analyze": "yarn run analyze:build && yarn run analyze:view",
Expand All @@ -28,7 +28,7 @@
"dev": "yarn run dev:clear-build && NODE_ENV=development yarn run build -w",
"dev:hot": "webpack-dev-server",
"storybook": "start-storybook -p 6006",
"build:storybook": "build-storybook -o ../public/storybook"
"build:storybook": "NODE_OPTIONS=--openssl-legacy-provider build-storybook -o ../public/storybook"
},
"cacheDirectories": [
"node_modules",
Expand Down Expand Up @@ -64,24 +64,25 @@
"@fortawesome/fontawesome-free": "^5.3.1",
"@hookform/resolvers": "^2.0.0-beta.5",
"@reduxjs/toolkit": "^1.9.7",
"@storybook/addon-a11y": "^6.3.8",
"@storybook/addon-actions": "^6.3.8",
"@storybook/addon-controls": "^6.3.8",
"@storybook/addon-docs": "^6.3.8",
"@storybook/addon-a11y": "^6.5.16",
"@storybook/addon-actions": "^6.5.16",
"@storybook/addon-controls": "^6.5.16",
"@storybook/addon-docs": "^6.5.16",
"@storybook/addon-knobs": "^6.3.1",
"@storybook/addon-links": "^6.3.8",
"@storybook/addons": "^6.3.8",
"@storybook/react": "^6.3.8",
"@storybook/testing-react": "^0.0.22",
"@storybook/addon-links": "^6.5.16",
"@storybook/addons": "^6.5.16",
"@storybook/builder-webpack4": "^6.5.16",
"@storybook/react": "^6.5.16",
"@storybook/testing-react": "^1.2.2",
"babel-jest": "^26.2.2",
"babel-loader": "^8.1.0",
"babel-loader": "^8.3.0",
"babel-plugin-lodash": "^3.3.4",
"classnames": "^2.2.5",
"core-js": "^3.4.1",
"css-loader": "^3.6.0",
"date-fns": "^2.16.1",
"detect-browser": "^2.4.0",
"dompurify": "^2.0.17",
"dotenv-webpack": "^8.1.0",
"draft-js": "^0.10.5",
"draftjs-to-html": "^0.8.3",
"expose-loader": "^0.7.3",
Expand All @@ -98,7 +99,7 @@
"moment": "^2.24.0",
"moment-range": "^4.0.2",
"moment-timezone": "^0.5.27",
"node-sass": "^6.0.0",
"node-sass": "^8.0.0",
"pdf-annotate.js": "^1.0.0",
"pdfjs-dist": "2.6.347",
"picocolors": "^1.0.1",
Expand Down Expand Up @@ -144,7 +145,7 @@
"vis-data": "^7.1.2",
"vis-network": "^9.0.4",
"vis-timeline": "^7.4.9",
"webpack": "^4.42.1",
"webpack": "^4.47.0",
"webpack-cli": "^3.3.11",
"yup": "^0.32.9"
},
Expand Down
Loading
Loading