Tracking PR for feature/APPEALS-49626 #22783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as/APPEALS-25117 akonhilas/APPEALS-25117
…APPEALS-34501 APPEALS-34501
…RT-phase-1-CC-cleanup HRT Phase 1 CC Fixes
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
* APPEALS-48462 api patch request * APPEALS-48462 component rerenders on state change * APPEALS-48462 added jest tests for toggles
* APPEALS-48366 index method in transcription_contractors_controller now returns new transcription count attribute for each one * APPEALS-48366 query for getting count of transcriptions now only gets count for this week * APPEALS-48366 transcriptions_count for the week now displays in the UI * APPEALS-48366 wrote rspec tests in controller spec * APPEALS-48366 added jest tests * APPEALS-48366 added a new scope for the query * APPEALS-48366 turned console.log mock back on
* APPEALS-48366 fixed undefined display when toggling work assignment * APPEALS-48366 edit goal modal now validates value when attempting to submit instead of on display * APPEALS-48366 removed unused useAffect * APPEALS-49626 fixed jest test * APPEALS-49626 fixed jest test * APPEALS-48366 removed console.log
* APPEALS-44287: Excluding disposition held and select that appeal for distribution (#22277) * first run at an SQL query removing duplicate appeals from distribution * code refactor and excluding disposition held and select that appeal for distribution * automated test for the duplicate hearing bug * fix rubocop offense SpaceInsideBlockBraces --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: samasudhirreddy <sudhirreddy.sama@va.gov> * APPEALS-51237, APPEALS-51536: Optimize feature tests in intake/appeal/edit_spec.rb and optimize automatic case distribution tests (#22280) * refactoring edit_spec * move one assertion and remove duplicate test * refactor withdraw issues context * move duplicate test assertions * move duplicate test assertions to existing tests and remove duplicate tests * move assertion and remove duplicate test * consolidate SCT appeal tests * refactor SCT tests to use step blocks * consolidate a individual test into a step * move CC appeal task tests to appeals_controller_spec intead of a feature test * remove unnecessary code comments * consolidate member not admin tests * remove commented portions of test * move tests from affinity_days_levers_spec.rb * move tests from affinity_days_levers_spec.rb, last commit was from audit_lever_history_table_spec.rb * remove ama_np_dist_goals_by_docket_lever_spec.rb * remove batch_size_levers_spec.rb * remove inactive_data_elements_levers_spec.rb * remove lever_buttons_spec.rb * refactor * move jest file for convention, add snapshot * move test for admin ui not interactable for non-admins to a jest test * remove unnecessary comments, whitespace * restore jest folder structure * modify edit spec to use case details page instead of searching again * modify assertions * remove TODO comment * add assertion to allow async save actions to be executed * add check to ensure banner is gone before trying to save * refactor assertions for lever history display * fix failing dependency report tests * APPEALS-53151: Update ECR Workflow to Utilize OIDC Flow (#22348) * Reconfigure ECR login workflow to utilize Github's OIDC flow * Add permissions * Update AWS account number to one for VAEC * Update account number for main CI workflow * Try using a separate secret in test * Try using a separate secret in test * Change name of secret --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * Fix snapshots --------- Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: samasudhirreddy <sudhirreddy.sama@va.gov> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
#22328) * add link for transcription settings * fixing jest tests * added the space between icon and text * fixing jest tests
* APPEALS-48373 - Initial basic version of date picker without many bells and whistles * APPEALS-48373 - New version of picker that handles data going in and out better * APPEALS-48373 - Fix bug related to clearing filters and trying to re-apply dates * APPEALS-48373 - Building out the dropdown UI * APPEALS-48373 - Fix the backend to allow filter by date and fix some front end issues * APPEALS-48373 - Write jest tests for date picker and update snapshots * APPEALS-48373 - UI fixes after seeing the filter on other tables * APPEALS-48373 - Use copy JSON * APPEALS-48373 - Update how clear filter button works and write a test * APPEALS-48373 - Allow custom front end filtering on QueueTable with DatePicker * APPEALS-48373 - Test date picker wrapped in a front end sorting queue table * APPEALS-48373 - Test date picker wrapped in a back end sorting queue table * APPEALS-48373 - Move tests out of DatePicker into QueueTable where they belong and add more tests * APPEALS-48373 - Keep DateFilter icon still selected when filtering by date instead of just when open
* APPEALS-43157 basic modal now appears when clicking on package button * APPEALS-43157 basic modal calculates return date including business days * APPEALS-43157 populating dropdown and added new controller action for the contractor names only * APPEALS-43157 added some jest tests * APPEALS-43157 work order now generating and new controller route created for task_id * APPEALS-43157 added jest tests * APPEALS-43157 added documentation * APPEALS-43157 fixed linting errors * APPEALS-43157 fixed broken tests * APPEALS-43157 seeding transcriptions * APPEALS-43157 update snapshot and scope * APPEALS-43157 updated seed file * APPEALS-43157 added triggers for task_id sequencing in transcriptions * APPEALS-43157 added triggers for task_id sequencing in transcriptions * APPEALS-43157 added triggers for task_id sequencing in transcriptions * APPEALS-43157 new transcription_sequence_id class added to services * APPEALS-43157 added modal controller action for testing sequencing
…an… (#22441) * ading jest tests for Select All/Individual Files, Unassigned tab Transcription File Dispatch page * fix for lint errors
* APPEALS-43238 add service * APPEALS-43238 add dependencies * APPEALS-43238 upload job spec * APPEALS-43238 alphebetize gemfile * APPEALS-43238 add insert and upsert * APPEALS-43238 add transcription_files update * APPEALS-43238 cleanup * APPEALS-43238 va box service spec * APPEALS-43238 remove test folder fix lint * APPEALS-43238 update bundler * APPEALS-43238 remove redundancy * APPEALS-43238 remove empty line
* APPEALS-43169 added basic modal after clicking package files button * APPEALS-43169 cancel and modify buttons are now working * APPEALS-43169 added form information from modal * APPEALS-43169 added in controller action and routes for getting selected files and their info * APPEALS-43169 table now rendered with information in the modal * APPEALS-43169 added a template for a controller action for dispatching files * APPEALS-43169 added jest tests * APPEALS-43169 added rspec tests * APPEALS-43169 fixed an rspec test * APPEALS-43169 fixed up the dates to exclude holidays only
* APPEALS-43169 added basic modal after clicking package files button * APPEALS-43169 cancel and modify buttons are now working * APPEALS-43169 added form information from modal * APPEALS-43169 added in controller action and routes for getting selected files and their info * APPEALS-43169 table now rendered with information in the modal * APPEALS-43169 added a template for a controller action for dispatching files * APPEALS-43169 added jest tests * APPEALS-43169 added rspec tests * APPEALS-43169 fixed an rspec test * APPEALS-43169 fixed up the dates to exclude holidays only * APPEALS-43169 data sent to controller is now a JSON object
* Create Model View Controller for package management activities * removed foreign key * removed foreign key * removed empty line * removed unused code * APPEALS-55525: Disable tests for seed files and lock Chrome version to v127 in Github Actions (#22567) * add exclude pattern to github actions rspec command * add test file exclude pattern constant * lock chrome version to 127.0.6533.119 * Removed outdated transcription id field * added specs * renaming model name * change route name * removed work order package file * update snapshot --------- Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
* APPEALS-49234 - Add new table for assigned view using mock backend data * APPEALS-49234 - Refactor testing and set up basic test for assigned tab * APPEALS-49234 - Cleanup of styles and language * APPEALS-49234 - Add consistency to styles and elements for tabs * APPEALS-55525 - Prevent table from having a scroll bar sometimes * APPEALS-55525 - Adjust spacing around icon in the table * APPEALS-55525 - Forgot to update snapshots * APPEALS-55525 - UI changes from review * APPEALS-55525 - Change spacing around switch views dropdown * APPEALS-55525 - Attempt to fix a flapping spec test * APPEALS-55525 - Stub out setinterval to hopefully prevent test timeouts * APPEALS-55525 - Maintain the correct tab on page refresh * APPEALS-55525 - Remove test code * APPEALS-55525 - Reset pagenation values when tab changes * APPEALS-55525 - Broken snapshot * APPEALS-55525 - A better fix for the tab params reset logic * APPEALS-55525 - Test fix --------- Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
* APPEALS-43211 work_order work flow * APPEALS-43211 update jest tests * APPEALS-43211 update specs * APPEALS-43211 update lint * APPEALS-43211 fix lint * APPEALS-43211 add space
* APPEALS-43183 solved merge conflict * APPEALS-43183 added some fake data and css styling * APPEALS-43183 populating modal and tweaked controller action for additional required information * APPEALS-43183 added comments * APPEALS-43183 added in jest testing * APPEALS-43183 fixed an rspec test * APPEALS-55495 - Seed transcription package data and start to use it * APPEALS-55495 - Do a little cleanup and get seed file ready * APPEALS-55495 - Set up a relationship between transcription package and transcription * APPEALS-55495 - Updated front end tests for URL change * APPEALS-55495 - Fix seed files to prevent class name conflicts * APPEALS-55495 - Fix contractor seed calls * APPEALS-55495 - Move seeds to end of the file so they’ll have good hearings * APPEALS-43183 applied new seed file and tweaked response for wo_contents * APPEALS-43183 fixed some tests * APPEALS-43183 removed transcription package spec --------- Co-authored-by: Adam Ducker <adam.ducker@va.gov>
* Display work order summary * fix date issue * Fixed spec * Added bold text for Docket number * Added close button
* APPEALS-55495 - Update transcription file seed to use task numbers and transcription records * APPEALS-55495 - Starting to make progress on testing * APPEALS-55495 - More cleanup and testing # Conflicts: # spec/models/hearings/transcription_package_spec.rb * APPEALS-55495 - Even more cleanup and testing * APPEALS-55495 - Snapshot update after rebase * APPEALS-55495 - Add back missing test method
|
Code Climate has analyzed commit 2834ee8 and detected 68 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* APPEALS-43184 create WorkOrderUnassignModal * APPEALS-43184 use modal component * APPEALS-43184 backend connection * APPEALS-43184 add route * APPEALS-43184 update dispatchtablecolumn * APPEALS-43184 add unassign_by_task_number * APPEALS-43184 remove id from FileDispatchTable * APPEALS-43184 add transcription_package method * APPEALS-43184 add error logic to controller * APPEALS-43184 clean up modal * APPEALS-43184 update file and import name * APPEALS-43184 update Unassigning_work_order * APPEALS-43184 lint * APPEALS-43184 lint * APPEALS-43184 update timeout * APPEALS-43184 change tests * APPEALS-43184 test-test changes * APPEALS-43184 update tests * APPEALS-43184 update jest test * APPEALS-43184 update snapshots * APPEALS-43184 update snapshot * APPEALS-43184 fix for violations test * APPEALS-43184 snapshot updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.jsalongsideMyComponent.jsx)Backend
Database Changes
Only for Schema Changes
created_at,updated_at) for new tablesCaseflow::Migration, especially when adding indexes (useadd_safe_index) (see Writing DB migrations)migrate:rollbackworks as desired (changesupported functions)make check-fks; add any missing foreign keys or add toconfig/initializers/immigrant.rb(see Record associations and Foreign Keys)belongs_tofor associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling