Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/APPEALS-57834 (#22799) #22800

Merged
merged 1 commit into from
Sep 11, 2024
Merged

hotfix/APPEALS-57834 (#22799) #22800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/app/components/Accordion.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const Accordion = (
headerClass={
classnames(headerClass, { disabled: sectionIsDisabled })
}
key={`${sectionId}-${sectionTitle}`}
key={sectionTitle}
header={headerElement}
>
<div className="usa-accordion-content" {...sectionProps}>
Expand Down
9 changes: 1 addition & 8 deletions spec/feature/reader/reader_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,6 @@ def clear_filters
find("#addComment").send_keys(:arrow_right)
expect(page).to have_content "Form 9"

find("h3", text: "Issue tags").click
fill_in "tags", with: "tag content"
find("#tags").send_keys(:arrow_left)
expect(page).to have_content "Form 9"
Expand Down Expand Up @@ -752,8 +751,6 @@ def element_position(selector)
click_on documents[0].type
page.driver.browser.manage.window.resize_to(1024, 1024)

find("h3", text: "Comments").click

element_id = "cf-sidebar-accordion"
scroll_to(id: element_id, value: 0)

Expand All @@ -780,7 +777,6 @@ def element_position(selector)
visit "/reader/appeal/#{appeal.vacols_id}/documents"

click_on(documents[0].type, wait: 10)
find("h3", text: "Comments", wait: 5).click
expect(page).to have_content(annotations[0].comment)

# Wait for PDFJS to render the pages
Expand Down Expand Up @@ -1039,7 +1035,6 @@ def cats_in_header
find(".cf-pdf-header .cf-pdf-doc-type-button-container", text: "BVA Decision")
expect(cats_in_header).to match_array [cats[:procedural], cats[:case_summary]]

find("h3", text: "Categories").click
find(".checkbox-wrapper-procedural", wait: 12).click
find(".checkbox-wrapper-medical").click

Expand Down Expand Up @@ -1112,7 +1107,7 @@ def cats_in_header
context "Tags" do
let(:new_tag_text) { "Foo" }

xscenario "adding and deleting tags" do
scenario "adding and deleting tags" do
TAG1 = "Medical"
TAG2 = "Law document"

Expand All @@ -1122,7 +1117,6 @@ def cats_in_header

visit "/reader/appeal/#{appeal.vacols_id}/documents"
click_on(documents[0].type, wait: 10)
find("h3", text: "Issue tags", wait: 5).click

fill_in "tags", with: TAG1

Expand All @@ -1142,7 +1136,6 @@ def cats_in_header
visit "/reader/appeal/#{appeal.vacols_id}/documents"
click_on documents[1].type

find("h3", text: "Issue tags", wait: 10).click
# tags for first document are shared in tag auto suggestions for second document
page.find("#tags", wait: 10).click
tag_options = find_all(".cf-select__option", wait: 10)
Expand Down
Loading