APPEALS-59528: Fix test spec/feature/switch_user_spec.rb #23003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberttravispierce
previously approved these changes
Sep 27, 2024
craigrva
force-pushed
the
dev-support/APPEALS-59528
branch
from
a98f8ba
to
5fa7358
Compare
craigrva
changed the base branch from
release/FY24Q4.6.0
to
release/FY24Q4.6.1
craigrva
force-pushed
the
dev-support/APPEALS-59528
branch
from
5fa7358
to
b024f43
Compare
craigrva
dismissed
roberttravispierce’s stale review
The base branch was changed.
|
Code Climate has analyzed commit c519a02 and detected 0 issues on this pull request. View more on Code Climate. |
hawkespoulterva
pushed a commit
that referenced
this pull request
Oct 23, 2024
hawkespoulterva
pushed a commit
that referenced
this pull request
Oct 23, 2024
hawkespoulterva
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-59528
Description
Replace setting the env variable DEPLOY_ENV with a mock to
Rails.deploy_env?to not adversely affect tests which are run after this testAdditionally removes the
vbms_ext_claimtable from schema.rb. This table shouldn't be in the schema because it doesn't exist in the production database. It is created to fake a VBMS integration in local/demo. Running the commandmake migrateremoves the table and re-adds it afterward, where runningrails db:migrate:primarywill not remove that table and add it to the schema.rb file.Acceptance Criteria
Testing Plan
Run the example test files in order and ensure that they both pass: