APPEALS-53424 | Decision Review Requirement | Feature Branch Tracking PR #23095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the get params if there was more than one filter present due to overwritten filter params during the QueueTable deep linking.
|
Code Climate has analyzed commit 8f4e32c and detected 0 issues on this pull request. View more on Code Climate. |
…23239) * Added missing constants for DatePicker * Added constants for vha date picker options * removed/added code from main into QueueTable * removed the predefinedColumns from completed tab in NonCompTabs * Added vhaTaskCompletedDateColumn to TaskTableColumns * Added conditional for vhaTaskCompleted or default one * Added vha options and logic for onChange * added tabName prop for completed tab in NonCompTabs * added tabName vaildation for completed tab in TaskTableTab * added logic for the additional options and hiding the date elements * cleaned up some lint * added tests to DatePicker.test for the new vha options * moved openFilter into utils file * running the tests again * snapshots * added missing props in test for DatePicker * updated logic for options in DatePicker * added missing click for apply button and formatting for expects * fixed spelling of button * added missing word * added missing comma * fixed incorrect date in test * changed the name of the column and added a label * snapshots * slight change to the name of the options * chagned the name of the additionalOptions and similplied the logic for showing the startDate * changed some props and valueName for the completedColumn * simplied some logic and updated the props * Update yarn.lock * added logic to disable button if between is mode and startDate is after endDate * updated props in test and added a new test for the start and end date logic * added validation for before and after options for the DatePicker * cleaned up some lint * added the on case to the validation * Update CaseWorkerIndex snapshot * added setting the start date for the all mode option * snapshot * small fix for a test in Queue Table * fixed the rspec test that was failing because of the new filter --------- Co-authored-by: Clay Sheppard <17840614+csheepy@users.noreply.github.com> Co-authored-by: Brandon Dorner <brandonleedorner@gmail.com> Co-authored-by: Robert Travis Pierce <1078402+roberttravispierce@users.noreply.github.com>
…n date (#23128) * Initial commit that alters the business line logic to accept a date filter for the tasks completed at column and logic to support and filter by it via the database query. * Added new tests for the tasksClosedAt filter to the business line spec. Adjusted the between lambda filter to work for either ordering of the start date or end date as the first chronological date in the query. Optimized the business line spec by swapping to before all loops and instance variables to shorten the time it takes to run the test. * Rewrote a bit more of the business line spec to speed it up via one time test data setup rather than for each test. * Updated the vha business line spec file. Fixed a code climate warning. * Removed some commented out code and changed the database cleaner to Task.delete all to be a bit more specific on cleanup before the change history tests. * Removed QueueTable code that was unrelated to the DatePicker that was causing errors. * Updated the wording in the filter summary for the closedAt filter to say Date Compeleted instead of closedAt. * Fixed a bug where the filter preservation was not working with the way the date filter params were added to the get params. Altered the Completed tasks tab description based on the Date Completed filter. Started adding a feature test for the completed date filtering. * Updated the formatting of the date in the completed tasks tab description to match mm/dd/yyyy format. Finished up the feature spec test for the completed date filtering. * Updated the expected values from the DatePicker to match what was in the feature branch. Updated the completed tasks tab description to once again be last 7 days for any business line that is not the VHA. Fixed a code climate issue with the new regex used for the filter preservation hook. Updated the new vha completed by date column to match the old column value so sorting and filtering will work correctly. * Updated the aria label in the new column. * Fixed failing tests related to the completed date column, completed tasks description, and the clear filters change from the DatePicker. * Changed single quotes to double quotes in ruby. * Fixed a few more test failures. * Altered the date picker validation code to disable the button if no date is selected for on, before, or after. * Updated the completed tasks tab description filtered by completed text to be less verbose. Change .nil? to .blank? in the closed_at filter parsing. Updated the test to reflect the new wording. --------- Co-authored-by: Brandon Lee Dorner <51007432+brandondorner@users.noreply.github.com>
…to feature/APPEALS-53424
* Initial commit that alters the business line logic to accept a date filter for the tasks completed at column and logic to support and filter by it via the database query. * Added new tests for the tasksClosedAt filter to the business line spec. Adjusted the between lambda filter to work for either ordering of the start date or end date as the first chronological date in the query. Optimized the business line spec by swapping to before all loops and instance variables to shorten the time it takes to run the test. * Rewrote a bit more of the business line spec to speed it up via one time test data setup rather than for each test. * Updated the vha business line spec file. Fixed a code climate warning. * Removed some commented out code and changed the database cleaner to Task.delete all to be a bit more specific on cleanup before the change history tests. * Removed QueueTable code that was unrelated to the DatePicker that was causing errors. * Updated the wording in the filter summary for the closedAt filter to say Date Compeleted instead of closedAt. * Fixed a bug where the filter preservation was not working with the way the date filter params were added to the get params. Altered the Completed tasks tab description based on the Date Completed filter. Started adding a feature test for the completed date filtering. * Updated the formatting of the date in the completed tasks tab description to match mm/dd/yyyy format. Finished up the feature spec test for the completed date filtering. * Updated the expected values from the DatePicker to match what was in the feature branch. Updated the completed tasks tab description to once again be last 7 days for any business line that is not the VHA. Fixed a code climate issue with the new regex used for the filter preservation hook. Updated the new vha completed by date column to match the old column value so sorting and filtering will work correctly. * Updated the aria label in the new column. * Fixed failing tests related to the completed date column, completed tasks description, and the clear filters change from the DatePicker. * Changed single quotes to double quotes in ruby. * Fixed a few more test failures. * Altered the date picker validation code to disable the button if no date is selected for on, before, or after. * Updated the completed tasks tab description filtered by completed text to be less verbose. Change .nil? to .blank? in the closed_at filter parsing. Updated the test to reflect the new wording. * Updated the Completed Cases text to contain no colon for the vha decision review queue. Fixed a bug in the date picker where the View All was not resetting the filter correctly. * Fixed a few jest tests. * Fixed a bug that could occur if you are trying to filter by a column that does not exist in a different queue. * Updated feature test with the new vha all completed cases description text without a colon. * Fixed a text issue when swapping between business lines with the same user that has a filter from the vha business line. --------- Co-authored-by: Brandon Lee Dorner <51007432+brandondorner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Tracking PR is for APPEALS-53424 Decision Review Requirement feature branch in order to facilitate syncing with master throughout the development cycle.