APPEALS-45267 | Saved Search - Change History | Feature Branch Tracking PR #23096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit aef8e3e and detected 0 issues on this pull request. View more on Code Climate. |
* first pass at creating blank saved search page * remove unused imports * basic storybook * refactor, add tests, use absolute links * add a probably temporary route to get admin restriction * refactor to make code climate leave me alone * remove unused imports * remove a trailing slash * fix frontend tests and more linter fixes * remove trailing slash in spec * DRY up noncomp store creation * Update client/app/nonComp/pages/SavedSearches.jsx Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> * move test into a step * put text into constant, refactor test * Update client/app/nonComp/pages/SavedSearches.jsx Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> * delete feature notes and unused code * fix test typo --------- Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* Added new model and spec files * rubocop linting * rubocop fixing linting error * fixing schema file * changes from PR feedback * added add_foreign_key for savedsearch * updated factory attribute names --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
* initial commit before merging dependent ticket - APPEALS-45336 * merge feature branch and fix merges * addressing PR comments * more PR feedbacks * adding MarginLeft --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
# Conflicts: # db/schema.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Tracking PR is for APPEALS-45267 Saved Search - Change History feature branch in order to facilitate syncing with master throughout the development cycle.