-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 39909 #23102
Draft
cacevesva
wants to merge
585
commits into
main
Choose a base branch
from
feature/APPEALS-39909
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/appeals 39909 #23102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for merge conflict
* Moved the 3 checks to public method initial commit * Modified the code as per the suggestions * Lint fixes * Updated the spec fixes
* fixed css causing searchbar errors * removed dead css attributes * improved edge matching on searchbar width
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Inital commit for Remove of MAX_QUEUED_ITEMS * Modified current_user * added auto assign permission check to process_tasks_if_applicable * Banner modifications for unassignable_reason in auto_assignable_user_finder.rb file * fixed duplicate warnings * bug fix for user permission checker * updated NOD error message to reflect ACs * removed redundant permission check * updated the error message for bulk capacity failure. * Updated sensitivity error message * Updated the spec file issues * fixed failing tests * Nod permission check spec * changed query type --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov>
* new branch for inbound_ops_team_user changes * more changes * changes for database * updated changes for InboundOpsTeam * update inbound name * update name * update spec test * remove comma * namespace validation * fixed plurality * change namespace for correspondence verification * fix plurality changes * remove brackets * fixing spec test * update naming * update spec tests... again :) * update affilaited * updated correspondence access check to handle if no user is present, and removed old checks that are not needed * excluded admins from inbound ops team user check * added comment for validation check * added check for system users and allow system users to create correspondence tasks * updated seeds and correspondence validation to check current session user * fixed linting issues * updated factory to sign out system user, removed other org checks from the controller validation, and added back in guard clause for correspondence intake task creation. * reverted mail team change from inbound ops * added saftey operator to system user check * removed factory changes and added validations to correspondence create_from_params methods * moved created methods to self and updated failing test * fixed failing tests * fixed failing correspondence tests * fixed failing tests by adding test user back into MailTeam org * fixed failing test in review package spec by adding back in MailTeam or assignment * updated failing tests and linting issues in tests * fix linting issues in organization users scss * pshing up linting fixes for correspondence.scss * finish lint clean up * fixed test failures * resolved linting issues in stylesheet * resolved failing test in intake spec * resolved failing test * fixed permission check to check current user * fixed styling issue with pagination buttons * removed Jolly Postman from seed data * upped wait time. * updated verify_correspondence_access to accept a user param * fixed linting issues in _correspondence.scss * fixed correspondence_intake_spec test and fixed linting issues on _correspondence.scss stylesheet * fixed method name on inbound ops team seed member creation in correspondence_auto_assign.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Ki/APPEALS-41707 - Intake: Update and remove fields (#21473) * APPEALS-41707 - Functionality and some CSS * APPEALS-41707 - Updates * APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes * APPEALS-41707 - Additional Linting * APPEALS-41707 - More Clean up * APPEALS-42281 - displaying NOD of correspondence in review package page (#21528) * APPEALS-42281 - displaying NOD of correspondence in review package page * fixing package document type alignment * Khalin/appeals 41705 (#21450) * WIP * VA DOR update * VA DOR date text area working as intended * Functionality working as intended * Styling * CPM info removed * Fixed some failing tests * WIP * VA DOR Read Only Styling * Edit CMP Test Passing * Fix Jest Job Test * Jest test fix WIP * Jest test fix WIP #2 * ReviewForm.test.js Provider Store Update * Styling * style * styling * remove unused --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> * Package document type styling (#21546) * bug fix for NOD update (#21544) * bug fix for NOPD update * APPEALS-42281-bug-fix - fix to update the nod on selection of correspondence document * Add data for VA 10182 (#21553) * Review Package General Info Section Spacing Change (#21559) * Review Package text spacing (#21560) * Ki/APPEALS-45367 - Intake - Confirm 3 - Package Document Type (#21571) * APPEALS-45367 - Fixed Linting. Fixed unnecessary delete * Rspec fixes * update package document type NOD/NON-NOD (#21584) * update NOD * fix rubocop issues * Khalin/appeals 45567 Request Package Action Modals Updated (#21590) * Functionally complete * Jest test fix * Khalin/appeals 41706 Intake: Remove Mail Tasks (#21572) * 'Returned or undeliverable mail' and 'Sent to ROJ' to be removed * Fix faling tests wip * Fixed test * Update correspondence_intake_processor.rb * Update tasks.js --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Mail Task Position Correction (#21597) * added changes to display intake appeal button based on NOD NON-NOD (#21618) * added changes to display intake appeal button based on NOD NON-NOD * updated to display intake appeal button after editing the document type * fixing lint issues * Update correspondence_review_package_controller.rb Updated syntax instead of each to find_each --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Khalin/Appeals 45367 - NOD/Non-NOD Bug Fix (#21619) * Bug Fixed NOD/Non-NOD Functioning Correctly * Triggering test --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Khalin/appeals 45367 NON/Non-NOD Status Fix v2 (#21664) * NOD/Non-NOD status Fix * Kicking off tests * Kicing off tests * Caceves/appeals 46003 (#21661) * Add inbound ops super user & adjust inbound ops normal user, disable VA DOR logic for super user * Add automatic seeding of inbound ops team super user * fix for continue button on select of yes no (#21721) * Sivakesh/appeals 44110 - Correspondence CSS Issues (#21763) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * Khalin/appeals 45867 (#21703) * WIP * Reverting changes * Save Changes Bug Fixed * Return To Queue button working as intended * Prevents save action in case of errorMessage * WIP * WIP * Working as intended * Removing comments * fixing tests * fixing lint error --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> * Sivakesh/appeals 44110 (#21775) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * #44110 - lint errors * Remove old seed data (#21780) --------- Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com>
…correspondence_nod
* added previous work to new branch * removed magic strings
…djustment (#21797) * fix team management verbiage * fix verbiage spec test
…ondences.rb (#21805) * refactored seed data to prevent bug where a user wasn't available. * moved auto assign logic higher up and updated superuser selection
…0 success message. (#21820)
* Created new file for correspondence and modified some changes from correspondence_auto_assign to user * Shifted the auto_assign_permissions method to users.rb file * Nod Permissions method is shifted to users * Modified the create! method with find_or_create_by * Fix for inbound_ops_team_superuser check * Moved correspondence_types and package_document_types into new seed file * Move code from queue_correspondence to new seed * Added a document type for every correspondence * Removed all the related correspondences seed files * Deleted the merged files again * Modified the rake tasks file and renamed the file to correspondence * Modified the appeals creation for veteran from 10 to 15 * Updated the spec files with seed class * Users sepec count update
…down (#21826) * draft pr * DELETE COMMENT * satisfy line length * pushing up changes for "Create Record" button * refactored correspondence button check in review package workflow * removed useEffect that was causing the button to become enabled when it shouldn't * disable create record button if there is no correspondence type on the correspondence --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Renamed the vbms types file * Renamed the vbms types file old file
* Removed aria-label for link in veteran details * Modified the spec file of aria-label --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* remove redundant find_by's * removed comma * removed commas --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Caceves/appeals 41709 v5 (#21878) * APPEALS-41709 - Uncorrupted Branch; First commit - Remove Columns from Correspondences * APPEALS-41709 - Drop package_document_types Table * Update remove * Updating Serializer for Correspondence * Removing portal_entry_date * Removing source_type * Removing cmp_packet_number * Removing cmp_queue_id * Removing package_document_type_id * package_document_type * Fix merge issues with table * Update Migration inheritance * Remove package_document_type from correspondence model * WIP working on safely removing old package document type * Restore queue_column * Restore correspondence_queue_column.rb * Restore client test correspondence.js * More package doc type removals * Remove unused package document type * Remove package document type and fix closing end statement * Remove package document type from spec * Fix 2 linter issues * Update queue_helpers to not use package_doc_type * Adjust docket_number & docket_name because was getting an error on the explain page * Fixed lint issue --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> * Update migration to have safety assured * Siva-Khalin/Appeals 43239 (#21811) * Setting up skeleton for future ACs * #43239 - AC 2 * #43239 - create new route and verify access is added * #43239 - #AC2 added link to queue tab * AC1 WIP * Updating access_allowed method * WIP * #43239 - #AC4 added new correspondence_admin feature toggle * AC1 Done * #43239 - added AC5.1 and AC5.2 * #43239 - moved text to constants * AC 5 WIP * #43239 - added number field and submit button * #43239 - limiting veteran file numbers to 10 * AC 5 continued WIP * #43239 - CSS Updates * #43239 - AC 5.6.2 and AC 5.6.4 * file_number check method * invalid_file_num_error_message ruby Method * #43239 - correspondence controller specs * #43239 - removed unused code * Routes WIP * Get Correspondence Test Route Working * #43239 - generate correspondence route * #43239 - Added FE changes for success response * #43239 - removed correspondence size in the api response * Fix various minor rubocop offenses * WIP generate_correspondence * #47513 - Test Correspondence Jest Tests * #47518 - Generate Correspondence updates * #47518 #47512 - specs for BE methods * #43239 - lint * #41709 - removed columns * removed unused code * lint * lint fixes * revert Gemfile.lock --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com> --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com>
* Removing requirement for correspondence_type_id to be assigned * removing correspondence_type_id from being built in seeds files in queue_helpers
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
… Information (#22937) * filtered related correspondece values * added new correspondence_details serializer * created new appeal serializer and updated frontend to handle new values * added correspondence type to serializer * fixed bug where appeal id was not matching with previously linked appeals * fixed failing test * fixed failing tests
* #APPEALS-58115 - added collapsible header * #APPEALS-58115 - updated box border color * #APPEALS-58115 - added a jest test to verify there is plus button * #APPEALS-58115 - added a jest test to verify there is plus button * #APPEALS-58115 - fixed a failing a jest test * #APPEALS-58115 - fixed a failing a spec
* WIP all styles have been moved * Fixing linting warnings * Aria-label added * Kicking off tests --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* mostly fixed * fixed css issues on grey timeline. * fixed missing key issue * fixed labels and data shape. * Fixed staged data to use real data. * removed redundant prop * Fixed task action dropdown * fixed linting issue * Kev ma/appeals 55015 (#22764) * Typo fix * Added safe navigation operator * Remove permissions from ruby view props * Update component to save value to state instead of from props * rename hash key * updated var ref to state * Update for code spacing * Bugfix for sticky checkbox logic * Div/appeals 57463 (#22779) * Added missing columns in the serializer prepareAppealForSearchStore function * Removed console log * Removed unused imports --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * added polymorphic association to correspondence task Correspondence relation * fixed null task issue * updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence. * setup way to load appeals into the Queue redux store to display task actions * created logic to load serialized tasks into store (but they overwrite each other) * created logic to add appeal tasks to the redux store. * added TaskSnapshot to display appeal task actions * pushed up fix that resolved routing crashes from correspondence * removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements. * Refactored component to use different name. * fixed 6 failing tests * fixed several failing tests. * changed shape of mocked data in details test * adding more data to staged props in test * fixed task display for tasks added when empty * reverted jest test files from their extreme size. * added back in correspondenceAppeal map * removed console log * fixed dead import. * fixed failing tests from div wrappers hiding task actions * updated tests to be less flaky --------- Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
… Edit Information (#22944) * APPEALS-42563 - Working Modal, minus Save patch request * APPEALS-42563 - Fixed Modal, missing ApiSave * APPEALS-42563 - ApiUtil fix * APPEALS-42563 * Test Updates * Remove loadCorrespondence * Removed unused correspondenceInfo action; linting --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* unlinked checkboxes now sort by vaDateOfReceipt * Post method added --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* Fixed the duplication of correspondence appeals adding to the database * Removed puts * fixing the jest fails * fixing the jest fails * Trying to fix the lint issues --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* Provided the instructional text * Jest fixes * Adjusted the paragraph text --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* bug fixes * fix rspec * fix rspec --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
…ng an appeal (#23045) * fix to the sorting issue * resolving bugs * resolved conflicts with branch changes and feature changes * added state refresh logic to CaseListTable --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* update search count * remove nested ternary operator --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* APPEALS-42563 - User Access Fix * Spec test user access update --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* fix checkbox across different pages * Database realtion fix * Lint fixes --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* TimeFix * Format
* fix save changes button * Fix for checkboxes in intake form to be selected --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov>
* Sucess banner fix * Cutting down on return statments * Removing unused
* making label changes and fixing feature tests * seeding data for inactive appeals for each veteran * Adding base info for task type options. Will be filtered later * Changing the inactive list to only include the 12 * fixing line length * working on creating tests for tasks related to inactive appeals * writing a helper method to create tasks related to inactive appeals * adding active attribute into the search serializer and view * simplifying the call in view * Editing spec helpers to fix the root tasks * Finishing up test writing for the workflow * removing leftover empty method --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Code Climate has analyzed commit 3bf67fc and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
…move Evidence Submission Window Action Dropdown (#23083) * is_waivable? method added * serializer fallback change * Khalin/appeals 52975 (#22994) * WIP all styles have been moved * Fixing linting warnings * Aria-label added * Kicking off tests --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Task Added to Appeal no longer being displayed after merge. (#22771) * mostly fixed * fixed css issues on grey timeline. * fixed missing key issue * fixed labels and data shape. * Fixed staged data to use real data. * removed redundant prop * Fixed task action dropdown * fixed linting issue * Kev ma/appeals 55015 (#22764) * Typo fix * Added safe navigation operator * Remove permissions from ruby view props * Update component to save value to state instead of from props * rename hash key * updated var ref to state * Update for code spacing * Bugfix for sticky checkbox logic * Div/appeals 57463 (#22779) * Added missing columns in the serializer prepareAppealForSearchStore function * Removed console log * Removed unused imports --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * added polymorphic association to correspondence task Correspondence relation * fixed null task issue * updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence. * setup way to load appeals into the Queue redux store to display task actions * created logic to load serialized tasks into store (but they overwrite each other) * created logic to add appeal tasks to the redux store. * added TaskSnapshot to display appeal task actions * pushed up fix that resolved routing crashes from correspondence * removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements. * Refactored component to use different name. * fixed 6 failing tests * fixed several failing tests. * changed shape of mocked data in details test * adding more data to staged props in test * fixed task display for tasks added when empty * reverted jest test files from their extreme size. * added back in correspondenceAppeal map * removed console log * fixed dead import. * fixed failing tests from div wrappers hiding task actions * updated tests to be less flaky --------- Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Fixed Correspondence Intake: Tab name doesn't match page (#23005) * populating task with dropdown working * change to get task rendering * frontend fixes * added waivable to appeal and task work queue serializers * added logic to only show evidence window task that is waivable. * set up task drodown to only show evidence tasks that are waivable. * fixed failing tests * refactored waivable? check to fix linting issue. * removed unused code --------- Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
…owing in correspondence workflow (#23152) * added logic to include waivable task in correspondence task workflow * consolidated action check to resolve linting issue
* renaming previous method that runs for each user * Creating appeals for our veterans in the create_veterans file * editing the inactive appeals for users to create 3 of each type at the beginning of the list * Minor edit to some code comments * code climate fix --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* Added feature test for docketswitchmailtask * Added test case testing for appropriate task assignor and assignee
* update restrictions to add task * update check_inbound_ops_team_user method * update specs * update specs
* Add feature test setup for all inactive appeal tasks * Deepak/appeals 56223 (#23310) * update restrictions to add task * update check_inbound_ops_team_user method * update specs * update specs * test for creation & association of task objs * remove comment * refactor and add more test checks * feature test updates * combined into one it block to speed up testing * Add BvaDispatch task exception * correct conditional stmt * added retry helper method when element not found * Wrap flaky portion of test in retry block * define action in method * add logging to retry * update test --------- Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling