Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/appeals 60433 DRAFT PR #23151

Draft
wants to merge 618 commits into
base: main
Choose a base branch
from
Draft

Feature/appeals 60433 DRAFT PR #23151

wants to merge 618 commits into from

Conversation

HunJerBAH
Copy link
Contributor

Resolves Jira Issue Title

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  • For feature branches merging into main: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

Rnmarshall93 and others added 30 commits June 18, 2024 13:36
* comment for source change to register

* refactored appeals_controller to use params safely. regression test clean.

* untested correspondence_controller params change.

* refactored correspondence_document_controller. regression tested.

* refactored unsafe params. regression tested.

* removed shared params inside concern (bad practice)

* refactored param safety. regression tested.

* refactored unsafe code. manually tested

* refactored params to be secure. regression tested.

* broke params into multiple lines

* refactored missing params into secure ones. regression tested again.

* refactored potential incorrect param

* minor param refactor.

* removed binding.pry and updated params.permit. regression tested again.

* fixed param issue

* updated params.permit

* fixed params issue

* another param fix

* second attempted fix

* might have actually fixed it

* another fix attempt

* fixed linting issues

* removed unused default params

* fixed rubocop complains with helper methods

* changed helper methods to be a constant

* moved pdf_params into separate method in correspondence_review_package_controller

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* #44296 - Updated labels

* #44296 - Updated specs

* #44296 - Updated labels to sync with every other label in file
* Initial commit for multiple assignement

* Provided the conditional logic for single and multiple

* Updated the error message

* changed the way errors are gathered

* Modified the text message to display

* Line break fix

* changed messages so they only populate if there are errors

* removed unless statement

* Modified the code changes to fix rubocop issues

* added back return false statement

* adjusted display of bullet points

* Modified the code due to rubocop fixes

* Spec fixes for single and multiple batch assignment

* removed commented code.

* Moved the constants to constant file

* Modified the constants file to a new file

* made changes to grammar and updated unit tests to match

* refactored banner logic to let auto user finder be the source of truth for assignment errors

* refactored logger to log the most recent unassignable reason from the auto assign user finder.

* fixed linting errors

---------

Co-authored-by: divyadasari-va <divya.dasari@va.gov>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
…kage modal on Review Package form (#21964)

* initial commit

* added .match.params to handle history props in QueueApp routing

* displaying banners for the correspondence review package actions

* Removing debugger

* removing the comment

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Passing rspec tests

* correspondence_review_package_controller_spec.rb fix

* Fixing checkbox test spec
* Initial commit for multiple assignement

* Provided the conditional logic for single and multiple

* Updated the error message

* changed the way errors are gathered

* Modified the text message to display

* Line break fix

* changed messages so they only populate if there are errors

* removed unless statement

* Modified the code changes to fix rubocop issues

* added back return false statement

* adjusted display of bullet points

* Modified the code due to rubocop fixes

* updating failed assignment header texts

* Spec fixes for single and multiple batch assignment

* updating failed assignment reason errors

* updating tests to pass with new messages

* removed commented code.

* Moved the constants to constant file

* Modified the constants file to a new file

* Changing the banner text method name to match incoming changes from feature

* adding build method for single error message

* fixing a mistake in my switch case code

* Fixing up some reasons for single errors

* correcting capacity error wording from multiple assignments ticket

* adding "to user" text and matching messages across single and multiple assignment errors

* Updating comments and spacing for code readability

* Reverting to feature from tests because of wacky failures

* updating mail team user to inbound ops team user in test descriptions

* updating single assignment and batch assignment tests to match new labels

* removing deprecated methods

* fixed linting errors

---------

Co-authored-by: divyadasari-va <divya.dasari@va.gov>
Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>
Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
#21939)

* APPEALS-48218 - edit_cmp_information_rspec Updates

* #48582 - Corrected test data and added initial states

* APPEALS-48218 - CodeClimate Updates

* APPEALS-48218 - CodeClimate Updates

* Lint

* Linting

* CC Updates

---------

Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov>
…or does not show (#22029)

* fixing an accidental bug where a bullet point containing a single error does not show

* updating name
* CodeClimate TL Approved Comments

* CodeClimate Updates 2

* Reek Update

* Reek 2
…ment Type (#22019)

* update nod

* update nod

* push up changes for nod

* update parameters for create_correspondence_document

* remove method

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* fix for the save changes button

* fixing jest and rspecs

* fix rspec
…eview (#22066)

* created testCommits git command

* updated git-test-commits namespace and reorged file to run ruby tests then js tests

* added clean push command

* added clean test and user input to script

* updated namespace of clean-pr and refactored to allow the use of a branch parameter

* test commit

* reverted test commit change

* refactored git commit and reverted test code change in correspondence.rb

* added formatting, fasterer, scss-lint, lint, and prettier tests

* added scss commit changes

* added safe auto correct option to clean-pr command
…Creating Correspondences (#22115)

* added guard clause to response

* added document creation to UAT test correspondence workflow

* remove domplexity note creation
psivakeshva and others added 30 commits October 16, 2024 17:17
* APPEALS-58227: Resolved bug where evidence submission task was not showing in correspondence workflow (#23152)

* added logic to include waivable task in correspondence task workflow

* consolidated action check to resolve linting issue

* #APPEALS-58114 - created collapsible section

* #APPEALS-58114 - Jest tests

* #APPEALS-58114 - lint

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* merging the save_correspondence_appeals to update_correspondence

* adding specs

* fixing the lint error

* refactoring code

* minor refactoring

* addressing PR comments

* resolved linting issues in details page

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Initial commit for modal window

* Update the db logic for waive evidence window

* Added alert

* Updated the alert banner

* Added banner for inividual appeal submition for waive evidence

* added instructions and remaning time to new task creation

* Modified 90 day window

* Lint fixes

* Updating assigned_at with end_date

* Moved corAppealTasks into redux action

* Updated the correspondencedetails with existing code

* Updated the correspondence in reduce action

* Added controller method changes

* uuid fix

* Updated the UUID issue

* Removed prop of a function

* test commit to return only updated correspondence appeal tasks

* put back in commented code

* added ability to remove an ama task from the Queue task store

* added guard clause to not reload appeals if appeal info is already loaded

* Updated the styles for banner

* Css gray dotted line fix

* Added spec file for banner verification for waive removel

* Lint fixes

* Lint fixes

* Lint warnings

* Fix for banner alert that is coming in Tasks not related to appeal section

* Modified the changes that are mentioned

* toggle function fix

* Merge conflicts

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: divyadasari-va <divyadasari-va@users.noreply.github.com>
Co-authored-by: divyadasari-va <divyadasari-va@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.