-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 60433 DRAFT PR #23151
Draft
HunJerBAH
wants to merge
618
commits into
main
Choose a base branch
from
feature/APPEALS-60433
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* comment for source change to register * refactored appeals_controller to use params safely. regression test clean. * untested correspondence_controller params change. * refactored correspondence_document_controller. regression tested. * refactored unsafe params. regression tested. * removed shared params inside concern (bad practice) * refactored param safety. regression tested. * refactored unsafe code. manually tested * refactored params to be secure. regression tested. * broke params into multiple lines * refactored missing params into secure ones. regression tested again. * refactored potential incorrect param * minor param refactor. * removed binding.pry and updated params.permit. regression tested again. * fixed param issue * updated params.permit * fixed params issue * another param fix * second attempted fix * might have actually fixed it * another fix attempt * fixed linting issues * removed unused default params * fixed rubocop complains with helper methods * changed helper methods to be a constant * moved pdf_params into separate method in correspondence_review_package_controller --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* #44296 - Updated labels * #44296 - Updated specs * #44296 - Updated labels to sync with every other label in file
* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * Spec fixes for single and multiple batch assignment * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * made changes to grammar and updated unit tests to match * refactored banner logic to let auto user finder be the source of truth for assignment errors * refactored logger to log the most recent unassignable reason from the auto assign user finder. * fixed linting errors --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
…kage modal on Review Package form (#21964) * initial commit * added .match.params to handle history props in QueueApp routing * displaying banners for the correspondence review package actions * Removing debugger * removing the comment --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Passing rspec tests * correspondence_review_package_controller_spec.rb fix * Fixing checkbox test spec
* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * updating failed assignment header texts * Spec fixes for single and multiple batch assignment * updating failed assignment reason errors * updating tests to pass with new messages * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * Changing the banner text method name to match incoming changes from feature * adding build method for single error message * fixing a mistake in my switch case code * Fixing up some reasons for single errors * correcting capacity error wording from multiple assignments ticket * adding "to user" text and matching messages across single and multiple assignment errors * Updating comments and spacing for code readability * Reverting to feature from tests because of wacky failures * updating mail team user to inbound ops team user in test descriptions * updating single assignment and batch assignment tests to match new labels * removing deprecated methods * fixed linting errors --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
#21939) * APPEALS-48218 - edit_cmp_information_rspec Updates * #48582 - Corrected test data and added initial states * APPEALS-48218 - CodeClimate Updates * APPEALS-48218 - CodeClimate Updates * Lint * Linting * CC Updates --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov>
…or does not show (#22029) * fixing an accidental bug where a bullet point containing a single error does not show * updating name
* CodeClimate TL Approved Comments * CodeClimate Updates 2 * Reek Update * Reek 2
…ment Type (#22019) * update nod * update nod * push up changes for nod * update parameters for create_correspondence_document * remove method --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* fix for the save changes button * fixing jest and rspecs * fix rspec
…was removed when merging master
…eview (#22066) * created testCommits git command * updated git-test-commits namespace and reorged file to run ruby tests then js tests * added clean push command * added clean test and user input to script * updated namespace of clean-pr and refactored to allow the use of a branch parameter * test commit * reverted test commit change * refactored git commit and reverted test code change in correspondence.rb * added formatting, fasterer, scss-lint, lint, and prettier tests * added scss commit changes * added safe auto correct option to clean-pr command
…Creating Correspondences (#22115) * added guard clause to response * added document creation to UAT test correspondence workflow * remove domplexity note creation
* APPEALS-58227: Resolved bug where evidence submission task was not showing in correspondence workflow (#23152) * added logic to include waivable task in correspondence task workflow * consolidated action check to resolve linting issue * #APPEALS-58114 - created collapsible section * #APPEALS-58114 - Jest tests * #APPEALS-58114 - lint --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* merging the save_correspondence_appeals to update_correspondence * adding specs * fixing the lint error * refactoring code * minor refactoring * addressing PR comments * resolved linting issues in details page --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Initial commit for modal window * Update the db logic for waive evidence window * Added alert * Updated the alert banner * Added banner for inividual appeal submition for waive evidence * added instructions and remaning time to new task creation * Modified 90 day window * Lint fixes * Updating assigned_at with end_date * Moved corAppealTasks into redux action * Updated the correspondencedetails with existing code * Updated the correspondence in reduce action * Added controller method changes * uuid fix * Updated the UUID issue * Removed prop of a function * test commit to return only updated correspondence appeal tasks * put back in commented code * added ability to remove an ama task from the Queue task store * added guard clause to not reload appeals if appeal info is already loaded * Updated the styles for banner * Css gray dotted line fix * Added spec file for banner verification for waive removel * Lint fixes * Lint fixes * Lint warnings * Fix for banner alert that is coming in Tasks not related to appeal section * Modified the changes that are mentioned * toggle function fix * Merge conflicts --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: divyadasari-va <divyadasari-va@users.noreply.github.com>
Co-authored-by: divyadasari-va <divyadasari-va@users.noreply.github.com>
…EALS-61261 Div/appeals 61261
…APPEALS-53951 Khalin/appeals 53951
…EALS-56950 Div/appeals 56950
…APPEALS-53951 UI Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling