-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 49667 #23153
Closed
Closed
Feature/appeals 49667 #23153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add remove_comp_and_pen_intake feature toggle to intakes controller * Add new compensation and pension removal message to COPY.json * Disable comp and pen radio buttons if remove_comp_and_pen_intake toggle is on * Frontend test updates * Add tooltip checks for review page integration tests * fix frontend test lint errors * frontend tests changes * Fix linter errors --------- Co-authored-by: kshiflett88 <kodishiflett@gmail.com> Co-authored-by: root <root@DESKTOP-IBDKNPF>
* Add remove_comp_and_pen_intake feature toggle to intakes controller * Add new compensation and pension removal message to COPY.json * Disable comp and pen radio buttons if remove_comp_and_pen_intake toggle is on * Frontend test updates * Add tooltip checks for review page integration tests * fix frontend test lint errors * frontend tests changes * Add banner for non-vha * Add banner for VHA employee * Refactor conditionals * Refactor logic for banners to display * Add dangerouslySetHtml to banner * Add test for no VHA employee with vha_claim_review_establishment disabled. * Add VHA employee scenario to display REMOVE_INTAKE_COMP_AND_PEN * Complete non vha user scenarios * Complete VHA employee scenarios * Remove comments * Fix linter errors * Remove spaces preceding question marks * Correct linting errors --------- Co-authored-by: Chris-Martine <christopher.martine@va.gov> Co-authored-by: kshiflett88 <kodishiflett@gmail.com> Co-authored-by: root <root@DESKTOP-IBDKNPF>
* Create EditDisabledBanner * Add banner displaying logic and pageroute to IntakeEditFrame * Add IntakeEditFrame jest tests for removeCompAndPenIntake feature toggle * Edit displayEditDisabledBanner to use the disableEditingForCompensationAndPension method * Re-add intakeEditFrame jest tests, re-add and move testProps * Refactor intakeEditFrame jest tests * Edit change testProps into static variable * Add another test for intakeEditFrame * Change testProps back into function return * Change comp and pen removal text * Change Intake Remove string back, add Intake Edit Disabled string, changed banner and tests to use this
…dit issue options from drop down (#22637) * ksarlett/APPEALS-50368 - Disable dropdown * rermove console.log * spec refactor * spec fix * spec refactor * change test name --------- Co-authored-by: Matt Ray <matthew.ray@va.gov>
* Add disabled logic to add issue and edit claim label buttons * Add test buttons are disabled When benefit is compensation * Test buttons are disabled in supplemental_claim Add issue and Edit claim label are disabled when benefits pension or compensation are present * Test buttons are disabled in HLR Add issue and Edit claim label are disabled when benefits pension or compensation are present * Refactor to remove redundancy * Test refactoring --------- Co-authored-by: Matt Ray <matthew.ray@va.gov> Co-authored-by: kshiflett88 <kodishiflett@gmail.com>
Code Climate has analyzed commit 75dfe26 and detected 0 issues on this pull request. View more on Code Climate. |
… when feature toggle enabled (#23194) * Pass disableEditingForCompAndPen toggle to EditContentionTitle, enable/disable edit button depending on toggle status * add feature tests for contention title disable * remove byebug --------- Co-authored-by: kshiflett88 <kodishiflett@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling