Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J hoang/appeals 57366 #23184

Merged
merged 11 commits into from
Oct 21, 2024
Merged

Conversation

jonathanh-va
Copy link
Contributor

@jonathanh-va jonathanh-va commented Oct 11, 2024

Resolves APPEALS-57366

Description

Restricted the date selector in the Disposition component for VHA HLR/SC decision reviews. The decision date will now range from the form receipt date to the current date.

Acceptance Criteria

  • Code compiles correctly
  • As a developer, I need to ensure the date range is restricted on the frontend.

Testing Plan

  1. Login as VHAADMIN
  2. Go to VHA Decision Review Queue
  3. Click on any in progress task
  4. Fill out the disposition for each issue
  5. Open the decision date selector and ensure that you can only select dates from the form receipt date to the current date.

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Copy link

codeclimate bot commented Oct 11, 2024

Code Climate has analyzed commit 4d83b24 and detected 0 issues on this pull request.

View more on Code Climate.

@jonathanh-va jonathanh-va marked this pull request as ready for review October 11, 2024 05:03
@seancva seancva added Stakeholder: VHA Functionality associated with Veterans Health Administration workflows/feature requests ART: VHA labels Oct 11, 2024
@jonathanh-va jonathanh-va reopened this Oct 11, 2024
@TylerBroyles TylerBroyles changed the base branch from main to feature/APPEALS-55409 October 16, 2024 21:03
Copy link
Contributor

@TylerBroyles TylerBroyles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Great job!

@roberttravispierce roberttravispierce merged commit dc9c19c into feature/APPEALS-55409 Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ART: VHA Stakeholder: VHA Functionality associated with Veterans Health Administration workflows/feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants