Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bad merge #23236

Closed
wants to merge 588 commits into from
Closed

Revert bad merge #23236

wants to merge 588 commits into from

Conversation

msteele96
Copy link
Contributor

@msteele96 msteele96 commented Oct 16, 2024

Resolves Jira Issue Title

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  • For feature branches merging into main: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

mchbidwell and others added 30 commits October 26, 2023 08:50
…on/APPEALS-32381

lthompson/APPEALS-32381
…as/APPEALS-25117

akonhilas/APPEALS-25117
…RT-phase-1-CC-cleanup

HRT Phase 1 CC Fixes
msteele96 and others added 24 commits July 1, 2024 14:24
* APPEALS-49560 moved non-virtual conference link creation to hearing concern

* APPEALS-49560 moved non_virtual conference creation inside of reschedule method

* APPEALS-49560 added a new spec test to test link creation

* APPEALS-49560 refactored rspec

* APPEALS-49560 removed additional method in after_create to prevent risk of duplication

* APPEALS-49560 removed additional method in after_create to prevent risk of duplication

* APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask

* Update app/models/concerns/hearing_concern.rb

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

---------

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
* remediated code climate issues

* remediated code climate issues

* remediated code climate issues

* fixed duplicate code issues

* fixed duplicate code issues

* fixed duplicate code issues

* APPEALS-50859 added new concern to abstract duplicate code

* APPEALS-50859 fixed new concern climate issues

* APPEALS-50859 added new config method for rooms endpoints to concern

* APPEALS-50859 added new config method for rooms endpoints to concern

* APPEALS-50859 added new config method for instant connect to concern

* APPEALS-50859 added new config method for instant connect to concern
* APPEALS-59152: removed unnecessary logic, color.primary

* APPEALS-59152: update snapshot tests
@msteele96 msteele96 changed the title Hotfix/APPEALS-59907 (#23100) Revert bad merge Oct 16, 2024
Copy link

codeclimate bot commented Oct 16, 2024

Code Climate has analyzed commit 26e6129 and detected 0 issues on this pull request.

View more on Code Climate.

@msteele96 msteele96 deleted the test-revert-branch branch October 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants