Al/appeals 45664

app/controllers/saved_searches_controller.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+class SavedSearchesController < ApplicationController
+  include ValidationConcern
+
+  before_action :react_routed, :verify_vha_admin
+
+  PERMITTED_PARAMS = [
+    :name,
+    :description,
+    saved_search: {}
+  ].freeze
+
+  def index
+    searches = SavedSearch.all_saved_searches
+    my_search = SavedSearch.my_saved_searches(current_user)
+    respond_to do |format|
+      format.html { render "index" }
+      format.json do
+        render json:
+         { all_searches: SavedSearchSerializer.new(searches).serializable_hash[:data],
+           user_searches: SavedSearchSerializer.new(my_search).serializable_hash[:data] }
+      end
+    end
+  end
+
+  def show
+    search = SavedSearch.find_by_id(params[:id])
+    respond_to do |format|
+      format.html { render "show" }
+      format.json { render json: SavedSearchSerializer.new(search).serializable_hash[:data] }
+    end
+  end
+
+  def create
+    @search = current_user.saved_searches.new(save_search_create_params)
+
+    return render json: { message: "Search has been successfully created" }, status: :created if @search.save
+
+    render json:  { message: "Error creating save search" }, status: :unprocessable_entity
+  end
+
+  def destroy
+    @search = current_user.saved_searches.find(params[:id])
+    @search.destroy!
+    render json: { status: :ok }
+  end
+
+  private
+
+  def save_search_create_params
+    params.require(:search).permit(PERMITTED_PARAMS)
+  end
+
+  def verify_vha_admin
+    return true if current_user.vha_business_line_admin_user?
+
+    redirect_to_unauthorized
+  end
+
+  def redirect_to_unauthorized
+    Rails.logger.info("User with roles #{current_user.roles.join(', ')} "\
+      "couldn't access #{request.original_url}")
+
+    session["return_to"] = request.original_url
+    redirect_to "/unauthorized"
+  end
+end

app/models/saved_search.rb

@@ -7,6 +7,10 @@ class SavedSearch < CaseflowRecord
   validates :description, presence: true, length: { maximum: 1000 }
   validate :saved_search_limit
 
+  scope :all_saved_searches, -> { order(created_at: :desc) }
+
+  scope :my_saved_searches, ->(user) { where(user_id: user).order(created_at: :desc) }
+
   private
 
   def saved_search_limit

app/serializers/saved_search_serializer.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class SavedSearchSerializer
+  include FastJsonapi::ObjectSerializer
+
+  attribute :name
+  attribute :description
+  attribute :saved_search
+  attribute :createdAt, &:created_at
+  attribute :userCssId do |object|
+    object.user.css_id
+  end
+  attribute :userFullName do |object|
+    object.user.full_name
+  end
+  attribute :userId do |object|
+    object.user.id
+  end
+end

app/views/saved_searches/index.html.erb

@@ -0,0 +1,15 @@
+<% content_for :full_page_content do %>
+  <%= react_component("NonComp", props: {
+    userDisplayName: current_user.display_name,
+    dropdownUrls: dropdown_urls,
+    applicationUrls: application_urls,
+    feedbackUrl: feedback_url,
+    buildDate: build_date,
+    flash: flash,
+    serverNonComp: {
+      currentUserCssId: current_user.css_id,
+    },
+    savedSearches: {
+    }
+  }) %>
+<% end %>

app/views/saved_searches/show.html.erb

@@ -0,0 +1,15 @@
+<% content_for :full_page_content do %>
+  <%= react_component("NonComp", props: {
+    userDisplayName: current_user.display_name,
+    dropdownUrls: dropdown_urls,
+    applicationUrls: application_urls,
+    feedbackUrl: feedback_url,
+    buildDate: build_date,
+    flash: flash,
+    serverNonComp: {
+      currentUserCssId: current_user.css_id,
+    },
+    savedSearches: {
+    }
+  }) %>
+<% end %>

client/app/nonComp/pages/SavedSearches.jsx

@@ -18,19 +18,19 @@ const SavedSearches = () => {
 
   const ALL_TABS = [
     {
-      key: 'my_saved_searches',
+      key: 'my_saved',
       label: 'My saved searches',
       // this section will later changed to backend call
       page: <SearchTable
-        eventRows={savedSearchesData.savedSearches.rows.filter((rows) => rows.userCssId === currentUserCssId)}
+        eventRows={savedSearchesData.savedSearches.all.filter((rows) => rows.userCssId === currentUserCssId)}
         searchPageApiEndPoint
       />
     },
     {
-      key: 'all_saved_searches',
+      key: 'all_saved',
       label: 'All saved searches',
       page: <SearchTable
-        eventRows={savedSearchesData.savedSearches.rows}
+        eventRows={savedSearchesData.savedSearches.all}
         searchPageApiEndPoint
       />
     }

client/test/data/nonComp/savedSearchesData.js

@@ -15,7 +15,7 @@ export default {
   savedSearches: {
     status: 'idle',
     error: null,
-    rows: [
+    all: [
       {
         id: 1,
         name: 'Search Name',
@@ -279,6 +279,9 @@ export default {
           }
         }
       }
+    ],
+    my: [
+
     ],
     fetchIndividualHistory: {
       status: 'succeeded'

config/routes.rb

@@ -316,8 +316,8 @@
       end
     end
     get "report", to: "decision_reviews#generate_report", on: :member, as: :report, format: false
-    get "report/searches", to: "decision_reviews#generate_report", on: :member, as: :saved_searches, format: false
     get "/(*all)", to: "decision_reviews#index"
+
   end
 
   resources :unrecognized_appellants, only: [:update] do
@@ -337,6 +337,7 @@
     patch "/messages/:id", to: "inbox#update"
   end
 
+  resources :saved_searches, only: [:index, :create, :destroy, :show]
   resources :users, only: [:index, :update] do
     resources :task_pages, only: [:index], controller: 'users/task_pages'
     get 'represented_organizations', on: :member

spec/controllers/saved_searches_controller_spec.rb

@@ -0,0 +1,136 @@
+# frozen_string_literal: true
+
+describe SavedSearchesController, :postgres, type: :controller do
+  let(:user) { create(:user, :vha_admin_user, :with_saved_search_reports) }
+  let(:saved_search) { create(:saved_search, user: user) }
+
+  let(:default_user) { create(:user) }
+  let(:vha_business_line) { VhaBusinessLine.singleton }
+  let(:options) { { format: :json } }
+
+  before do
+    User.stub = user
+  end
+
+  describe "#create" do
+    let(:valid_params) do
+      {
+        search: {
+          name: Faker::Name.name,
+          description: Faker::Lorem.sentence,
+          saved_search: {
+            report_type: "event_type_action",
+            events: {
+              "0": "added_issue_no_decision_date"
+            },
+            timing: {
+              range: "last_7_days"
+            },
+            decision_review_type: {
+              "0": "HigherLevelReview", "1": "SupplementalClaim"
+            },
+            business_line_slug: "vha"
+          }
+        }
+      }
+    end
+
+    context "VHA user creating saved search" do
+      it "should create search" do
+        expect { post :create, params: valid_params }
+          .to change(SavedSearch, :count).by(1)
+
+        expect(response).to have_http_status(:created)
+      end
+    end
+  end
+
+  describe "#destory /saved_searches/:id" do
+    context "VHA user saved search exists" do
+      it "should delete search" do
+        delete :destroy, params: { id: user.saved_searches.first.id }
+
+        expect(response).to have_http_status(:ok)
+      end
+    end
+
+    context "VHA user saved search not exists" do
+      it "retunrs a not found error" do
+        delete :destroy, params: { id: 0 }
+
+        expect(response).to have_http_status(:not_found)
+      end
+    end
+  end
+
+  describe "#index" do
+    before do
+      vha_business_line.add_user(default_user)
+      User.stub = default_user
+    end
+    context "get saved search" do
+      subject do
+        get :index,
+            params: options
+      end
+
+      context "user is not an vha admin" do
+        it "returns unauthorized" do
+          subject
+
+          expect(response.status).to be 302
+          expect(response.body).to match(/unauthorized/)
+        end
+      end
+
+      context "user is vha admin" do
+        before do
+          OrganizationsUser.make_user_admin(default_user, vha_business_line)
+        end
+
+        let!(:user_searches) { create_list(:saved_search, 5, user: default_user) }
+        let!(:other_user_searches) { create_list(:saved_search, 10) }
+
+        it "returns a successful response" do
+          subject
+
+          expect(response.status).to eq 200
+          expect(JSON.parse(response.body)["all_searches"].count).to eq(16)
+          expect(JSON.parse(response.body)["user_searches"].count).to eq(5)
+        end
+      end
+    end
+  end
+
+  describe "#show" do
+    before do
+      OrganizationsUser.make_user_admin(default_user, vha_business_line)
+      User.stub = default_user
+    end
+
+    context "get single saved search" do
+      let(:saved_search) do
+        create(:saved_search,
+               user: default_user,
+               name: "Timing Specification Before",
+               description: "Timing range before date")
+      end
+
+      subject do
+        get :show,
+            params: { id: saved_search.id, format: :json }
+      end
+
+      it "returns specific saved search" do
+        subject
+
+        expect(subject.response_code).to eq 200
+
+        response = JSON.parse(subject.body)
+
+        expect(response["attributes"]["name"]).to eq "Timing Specification Before"
+        expect(response["attributes"]["description"]).to eq "Timing range before date"
+      end
+    end
+  end
+end

spec/models/serializers/saved_search_serializer_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+describe SavedSearchSerializer, :postgres do
+  describe "#as_json" do
+    let(:user) { create(:user, :vha_admin_user) }
+    let(:saved_search) do
+      create(
+        :saved_search,
+        user: user,
+        name: "my_first_search",
+        description: "my first search",
+        saved_search: "{report_type: 'event_type_action'}"
+      )
+    end
+
+    subject { described_class.new(saved_search) }
+
+    it "renders saved search data" do
+      serializable_hash = {
+        name: "my_first_search",
+        description: "my first search",
+        saved_search: "{report_type: 'event_type_action'}",
+        createdAt: saved_search.created_at,
+        userCssId: user.css_id,
+        userFullName: user.full_name,
+        userId: user.id
+      }
+      expect(subject.serializable_hash[:data][:attributes]).to eq(serializable_hash)
+    end
+  end
+end