Poulter/APPEALS-46624-react-18-upgrade-final (#23333) #23334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* react 18 test upgrade * styled-components * EditPOAInformation test refactor, in progrss NonratingRIUModal test * additional tests refactored * Refactors Enzyme -> RTL * more changes * Enzyme -> RTL refactors (cont) * Enzyme -> RTL refactor (cont) * Enzyme -> RTL refactor (cont) * Enzyme -> RTL refactor (cont) * Enzyme -> RTL refactor (cont) * Cherry-picking from v2 branch --cont * fixed badge test * Enzyme -> RTL (establishClaim-test) * Enzyme -> RTL (cont, Batch 3) * Batch 3 refactor cont * Batch 3 In Progress * Batch 3 to review * Batch 4 updates * ScheduleVeteran.test refactor finished * Batch 4 and cleanups * Batch 4 continued * Outstanding Enzyme -> RTL refactors * batch 4 changes and non used enzyme test removal * clean up * snapshot and failing test clean up * Test updates and Snapshot fixes * Package updates with a couple fixed tests * Make test less brittle * switch to for...of instead of forEach to fix async problems * remove unnecessary import * lint fixes * disable linters * APPEALS-55525: Disable tests for seed files and lock Chrome version to v127 in Github Actions (#22567) * add exclude pattern to github actions rspec command * add test file exclude pattern constant * lock chrome version to 127.0.6533.119 * React Dependency upgrade * force wepback-bundle.js * Fix for bva_dispatch_return_flow_spec * fixed spec method to click pdf * Fixed task_queue_spec.rb * add indicated_for_contested_claims flag to legacy appeals * update legacy appeal spec * fix for scm_judge_assignment_spec.rb * force state update * fixed admin_ui_spec.rb * fixed user_organization_spec.rb * flow modal refactor to functional component and fix state renders, remove null saveSuccessful * fixed motion_to_vacate_spec.rb * revert changes * revert all changes * stop letting null pass * revert more changes * test null condition * comment * revert test * add flushsync * remove enzyme and update snapshots * fixed EmailConfirmationModal.test.js * fixed NonratingRequestIssueModal-test.js * fixed Timezone.test.js * fixed ScheduleVeteranForm.test.js * fixed HearingTime.test.js * fixed IssueTags.test.js * linting * updated daily_docket_spec.rb * fix duplicated code for code climate * fix more shared test setup * hopefully the last duplicate code * remove sleeps * update for daily_docket_spec.rb * add flush sync and add initialState back in * added waits to vso_change_hearing_request_type_spec.rb * remove legacy appeal flag * Remove debugging statement * revert change spec and fix state sync * remove file changes * fix snapshot * Merge branch 'main' into Poulter/46624-react-18-upgrade-1 * fixed tests * revert unnecesarry change * remove old spec changes * fix syncable job * update ftk reference * snapshot fix --------- Co-authored-by: Griffin Dooley <dooleygriffin@gmail.com> Co-authored-by: AdamShawBAH <adam.shaw@va.gov> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
|
Code Climate has analyzed commit 1b18b9e and detected 14 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
sbashamoni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Update React 18. The biggest changes here are removing enzyme in favor of React Test Library and adjusting some components to still work with concurrent rendering introduced by createRoot.
Test Plans: