Skip to content

Commit

Permalink
MBMS-77352 Added NCA error emails to email notifications
Browse files Browse the repository at this point in the history
  • Loading branch information
ksantiagoBAH committed Oct 25, 2024
1 parent ededfe7 commit 70da660
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 2 additions & 0 deletions config/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1332,6 +1332,8 @@ vanotify:
form21_4142_error_email: form21_4142_error_email_template_id
form21_4142_received_email: form21_4142_received_email_template_id
form40_0247_confirmation_email: form40_0247_confirmation_email_template_id
form40_0247_error_email: form40_0247_error_email_template_id
form40_10007_error_email: form40_10007_error_email_template_id
form526_confirmation_email: fake_template_id
form526_submission_failed_email: fake_template_id
form5490_confirmation_email: form5490_confirmation_email_template_id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ class NotificationEmail
},
'vba_40_0247' => {
confirmation: Settings.vanotify.services.va_gov.template_id.form40_0247_confirmation_email,
error: nil,
error: Settings.vanotify.services.va_gov.template_id.form40_0247_error_email,
received: nil
},
'vba_40_10007' => {
confirmation: nil,
error: Settings.vanotify.services.va_gov.template_id.form40_10007_error_email,
received: nil
}
}.freeze
Expand Down Expand Up @@ -160,6 +165,8 @@ def get_email_address_from_form_data
form20_10207_contact_info[0]
when 'vba_40_0247'
form_data['applicant_email']
when 'vba_40_10007'
form_data.dig('application', 'claimant', 'email')

Check failure on line 169 in modules/simple_forms_api/app/services/simple_forms_api/notification_email.rb

View workflow job for this annotation

GitHub Actions / Linting and Security

Layout/TrailingWhitespace: Trailing whitespace detected.
end
end

Expand All @@ -183,6 +190,8 @@ def get_first_name_from_form_data
form20_10207_contact_info[1]
when 'vba_40_0247'
form_data.dig('applicant_full_name', 'first')
when 'vba_40_10007'
form_data.dig('application', 'claimant', 'name', 'first')

Check failure on line 194 in modules/simple_forms_api/app/services/simple_forms_api/notification_email.rb

View workflow job for this annotation

GitHub Actions / Linting and Security

Layout/TrailingWhitespace: Trailing whitespace detected.
end
end

Expand Down

0 comments on commit 70da660

Please sign in to comment.