Adjust feature flag to allow specs to pass

modules/covid_vaccine/spec/sidekiq/covid_vaccine/expanded_registration_email_job_spec.rb

@@ -21,6 +21,10 @@
   end
 
   describe '#perform' do
+    before do
+      allow(Flipper).to receive(:enabled?).with(:notification_creation).and_return(false)
+    end
+
     it 'logs message to sentry and raises if no submission exists' do
       with_settings(Settings.sentry, dsn: 'T') do
         expect(VaNotify::Service).not_to receive(:new)

modules/va_notify/lib/va_notify/service.rb

@@ -23,19 +23,31 @@ def initialize(api_key)
     end
 
     def send_email(args)
-      response = with_monitoring do
-        notify_client.send_email(args)
+      if Flipper.enabled?(:notification_creation)
+        response = with_monitoring do
+          notify_client.send_email(args)
+        end
+        create_notification(response)
+      else
+        with_monitoring do
+          notify_client.send_email(args)
+        end
       end
-      create_notification(response) if Flipper.enabled?(:notification_creation)
     rescue => e
       handle_error(e)
     end
 
     def send_sms(args)
-      response = with_monitoring do
-        notify_client.send_sms(args)
+      if Flipper.enabled?(:notification_creation)
+        response = with_monitoring do
+          notify_client.send_sms(args)
+        end
+        create_notification(response)
+      else
+        with_monitoring do
+          notify_client.send_sms(args)
+        end
       end
-      create_notification(response) if Flipper.enabled?(:notification_creation)
     rescue => e
       handle_error(e)
     end