general save

spec/sidekiq/form526_submission_failure_email_job_spec.rb

@@ -17,7 +17,7 @@
 
   describe '#perform' do
     context 'when a user has additional form and files with their submission' do
-    let!(:form526_submission) { create(:form526_submission, :with_uploads_and_ancillary_forms) }
+      let!(:form526_submission) { create(:form526_submission, :with_uploads_and_ancillary_forms) }
 
       let(:expected_params) do
         {
@@ -54,12 +54,6 @@
 
     context 'when a user has no additional additional forms their submission' do
       let!(:form526_submission) { create(:form526_submission, :with_uploads) }
-      before do
-        form526_submission.form['form526_uploads'].each do |upload|
-          create(:supporting_evidence_attachment, :with_file_data, guid: upload['confirmationCode'])
-        end
-      end
-
       let(:expected_params) do
         {
           email_address: 'test@email.com',
@@ -73,6 +67,12 @@
         }
       end
 
+      before do
+        form526_submission.form['form526_uploads'].each do |upload|
+          create(:supporting_evidence_attachment, :with_file_data, guid: upload['confirmationCode'])
+        end
+      end
+
       it 'replaces the forms list variable with a placeholder' do
         expect(email_service).to receive(:send_email).with(expected_params)