general save

department-of-veterans-affairs · Oct 24, 2024 · a872cf4 · a872cf4
1 parent 422641c
commit a872cf4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/sidekiq/form526_submission_failure_email_job.rb b/app/sidekiq/form526_submission_failure_email_job.rb
@@ -86,13 +86,13 @@ def personalisation
     {
       first_name: submission.get_first_name,
       date_submitted: submission.format_creation_time_for_mailers,
-      forms_submitted: list_forms_submitted.blank? ? 'None' : list_forms_submitted,
-      files_submitted: list_files_submitted.blank? ? 'None' : list_files_submitted
+      forms_submitted: (list_forms_submitted.presence || 'None'),
+      files_submitted: (list_files_submitted.presence || 'None')
     }
   end
 
   def list_forms_submitted
-     @list_forms_submitted ||= [].tap do |forms|
+    [].tap do |forms|
       forms << FORM_DESCRIPTIONS['form4142'] if form['form4142'].present?
       forms << FORM_DESCRIPTIONS['form0781'] if form['form0781'].present?
       forms << FORM_DESCRIPTIONS['form0781a'] if form.dig('form0781', 'form0781a').present?