Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests to code checks #17871

Closed
wants to merge 15 commits into from
Closed

add unit tests to code checks #17871

wants to merge 15 commits into from

Conversation

stevenjcumming
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 14:56 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 15:12 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 15:18 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 17:34 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 17:40 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 17:50 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 18:24 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 18:30 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 18:42 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 19:43 Inactive
Copy link

github-actions bot commented Aug 5, 2024

This PR requires approval from backend-review-group. Please add backend-review-group as reviewers (if they're not already listed).

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-code-health-ut/main/main August 5, 2024 19:49 Inactive
Copy link

github-actions bot commented Aug 5, 2024

Coverage Report for Unit Tests

Group Name Covered Percent
Controllers 43.87%
Channels 100.00%
Models 76.60%
Mailers 63.31%
Helpers 39.22%
Jobs 50.70%
Libraries 81.88%
Services 57.19%
Sidekiq 70.81%
Uploaders 90.34%
Policies 86.87%
Ungrouped 96.11%
AVERAGE 71.41%

Your average coverage across all groups is 71.41% 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants